testsAndMisc/cloud_gallery/src/components/gallery.test.tsx
Krzysztof kuhy Rudnicki c6f1b85c78 cloud_gallery: fix build, 100% coverage, aggressive lint; whitelist dufs_client
- dufs-client.test.ts: type fetch mocks as vi.fn<typeof fetch>() (fixes the
  TS2493/TS2352 tuple/undefined build errors that broke `pnpm build`)
- dufs-client.ts: explicit method arg drops the unreachable `?? "GET"` branch
- gallery/grid: -1 viewer-index sentinel + pass media entry, removing three
  unreachable defensive guards; onOpenMedia now takes the entry
- use-hash-path: extract serverPath() so the SSR snapshot is covered
- eslint: strict+stylistic type-checked, react-hooks, reportUnusedDisable
  Directives; drop eslint-plugin-react (incompatible with ESLint 10)
- add grid.test.tsx + use-listing.test.ts; coverage thresholds 100/100/100/100
  (62 tests: statements/branches/functions/lines all 100%)
- phone_focus_mode/config.sh: whitelist com.kuhy.dufs_client

Deployed live via setup_cloud_gallery.sh (render-spa); fixed ffmpeg by
renaming a stale /usr/local/bin shadow linking the removed libvpx.so.11;
regenerated thumbnails (10 made, 0 failed). APK installed + launch-verified.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0126QvdMrv2WNeUVShFiLTc3
2026-07-12 17:29:39 +02:00

257 lines
9.5 KiB
TypeScript

import { describe, it, expect, vi, beforeEach } from "vitest";
import { render, screen, waitFor, fireEvent } from "@testing-library/react";
import userEvent from "@testing-library/user-event";
import { Gallery } from "./gallery.tsx";
import type { DufsClient } from "../api/dufs-client.ts";
import type { DirEntry } from "../api/types.ts";
function entry(name: string, kind: "dir" | "file"): DirEntry {
return { name, path: `/${name}`, kind, size: 10, mtimeMs: 0 };
}
function makeClient(overrides: Partial<DufsClient> = {}): DufsClient {
return {
list: vi.fn(() =>
Promise.resolve([
entry("Media", "dir"),
entry("pic.jpg", "file"),
entry("clip.mp4", "file"),
entry("notes.txt", "file"),
]),
),
fileUrl: (p: string) => p,
thumbUrl: (p: string) => `/.thumbs${p}.jpg`,
upload: vi.fn(() => Promise.resolve()),
remove: vi.fn(() => Promise.resolve()),
readText: vi.fn(() => Promise.resolve("hello world")),
writeText: vi.fn(() => Promise.resolve()),
...overrides,
};
}
beforeEach(() => {
window.location.hash = "";
});
describe("Gallery", () => {
it("renders a directory listing", async () => {
render(<Gallery client={makeClient()} />);
expect(await screen.findByText("Media")).toBeInTheDocument();
expect(screen.getByText("pic.jpg")).toBeInTheDocument();
expect(screen.getByText("clip.mp4")).toBeInTheDocument();
});
it("opens an image in the viewer and closes it", async () => {
render(<Gallery client={makeClient()} />);
await userEvent.click(await screen.findByText("pic.jpg"));
await waitFor(() => {
expect(document.querySelector(".viewer-img")).not.toBeNull();
});
await userEvent.click(screen.getByLabelText("Close"));
await waitFor(() => {
expect(document.querySelector(".viewer-img")).toBeNull();
});
});
it("plays a video in the viewer", async () => {
render(<Gallery client={makeClient()} />);
await userEvent.click(await screen.findByText("clip.mp4"));
await waitFor(() => {
expect(document.querySelector("video")).not.toBeNull();
});
});
it("edits a text file and saves it", async () => {
const client = makeClient();
render(<Gallery client={client} />);
await userEvent.click(await screen.findByText("notes.txt"));
const area = await screen.findByDisplayValue("hello world");
await userEvent.clear(area);
await userEvent.type(area, "new text");
await userEvent.click(screen.getByRole("button", { name: "Save" }));
await waitFor(() => {
expect(client.writeText).toHaveBeenCalledWith("/notes.txt", "new text");
});
});
it("deletes a file after confirming", async () => {
const client = makeClient();
render(<Gallery client={client} />);
await screen.findByText("pic.jpg");
await userEvent.click(screen.getByLabelText("Delete pic.jpg"));
await userEvent.click(screen.getByRole("button", { name: "Delete" }));
await waitFor(() => {
expect(client.remove).toHaveBeenCalledWith("/pic.jpg");
});
});
it("uploads picked files", async () => {
const client = makeClient();
const { container } = render(<Gallery client={client} />);
await screen.findByText("pic.jpg");
const input = container.querySelector<HTMLInputElement>(
'input[type="file"]',
);
expect(input).not.toBeNull();
const file = new File(["x"], "up.png", { type: "image/png" });
if (input) fireEvent.change(input, { target: { files: [file] } });
await waitFor(() => {
expect(client.upload).toHaveBeenCalled();
});
});
it("navigates between media in the viewer", async () => {
render(<Gallery client={makeClient()} />);
await userEvent.click(await screen.findByText("pic.jpg"));
await waitFor(() => {
expect(document.querySelector(".viewer-img")).not.toBeNull();
});
fireEvent.keyDown(window, { key: "ArrowRight" });
await waitFor(() => {
expect(document.querySelector("video")).not.toBeNull();
});
});
it("surfaces an upload error", async () => {
const client = makeClient({
upload: vi.fn(() => Promise.reject(new Error("uperr"))),
});
const { container } = render(<Gallery client={client} />);
await screen.findByText("pic.jpg");
const input = container.querySelector<HTMLInputElement>(
'input[type="file"]',
);
if (input) {
fireEvent.change(input, {
target: { files: [new File(["x"], "u.png")] },
});
}
expect(await screen.findByText(/uperr/)).toBeInTheDocument();
});
it("surfaces a delete error", async () => {
const client = makeClient({
remove: vi.fn(() => Promise.reject(new Error("delerr"))),
});
render(<Gallery client={client} />);
await screen.findByText("pic.jpg");
await userEvent.click(screen.getByLabelText("Delete pic.jpg"));
await userEvent.click(screen.getByRole("button", { name: "Delete" }));
expect(await screen.findByText(/delerr/)).toBeInTheDocument();
});
it("cancels a delete", async () => {
const client = makeClient();
render(<Gallery client={client} />);
await screen.findByText("pic.jpg");
await userEvent.click(screen.getByLabelText("Delete pic.jpg"));
await userEvent.click(screen.getByRole("button", { name: "Cancel" }));
expect(client.remove).not.toHaveBeenCalled();
});
it("shows an error when listing fails", async () => {
const client = makeClient({
list: vi.fn(() => Promise.reject(new Error("boom"))),
});
render(<Gallery client={client} />);
expect(await screen.findByText(/boom/)).toBeInTheDocument();
});
it("navigates via a breadcrumb", async () => {
render(<Gallery client={makeClient()} />);
await screen.findByText("pic.jpg");
await userEvent.click(screen.getByRole("button", { name: "cloud" }));
expect(window.location.hash).toBe("#/");
});
it("opens the file picker from the Upload button", async () => {
render(<Gallery client={makeClient()} />);
await screen.findByText("pic.jpg");
// Should not throw; exercises the hidden-input click path.
await userEvent.click(screen.getByRole("button", { name: "Upload" }));
expect(screen.getByRole("button", { name: "Upload" })).toBeInTheDocument();
});
it("steps to the previous media with ArrowLeft (wrapping)", async () => {
render(<Gallery client={makeClient()} />);
await userEvent.click(await screen.findByText("pic.jpg"));
await waitFor(() => {
expect(document.querySelector(".viewer-img")).not.toBeNull();
});
// media = [pic.jpg, clip.mp4]; from index 0, prev wraps to the video.
fireEvent.keyDown(window, { key: "ArrowLeft" });
await waitFor(() => {
expect(document.querySelector("video")).not.toBeNull();
});
});
it("shows an empty-folder message", async () => {
const client = makeClient({ list: vi.fn(() => Promise.resolve([])) });
render(<Gallery client={client} />);
expect(await screen.findByText("This folder is empty.")).toBeInTheDocument();
});
it("renders breadcrumb separators for nested paths", async () => {
window.location.hash = "#/Media/2026";
render(<Gallery client={makeClient()} />);
await screen.findByText("pic.jpg");
expect(screen.getByRole("button", { name: "Media" })).toBeInTheDocument();
expect(screen.getByRole("button", { name: "2026" })).toBeInTheDocument();
expect(document.querySelectorAll(".crumb-sep").length).toBeGreaterThan(0);
});
it("ignores an upload with no files selected", async () => {
const client = makeClient();
const { container } = render(<Gallery client={client} />);
await screen.findByText("pic.jpg");
const input = container.querySelector<HTMLInputElement>(
'input[type="file"]',
);
if (input) fireEvent.change(input, { target: { files: null } });
expect(client.upload).not.toHaveBeenCalled();
});
it("stringifies a non-Error upload rejection", async () => {
const client = makeClient({
// eslint-disable-next-line @typescript-eslint/prefer-promise-reject-errors
upload: vi.fn(() => Promise.reject("plain-up")),
});
const { container } = render(<Gallery client={client} />);
await screen.findByText("pic.jpg");
const input = container.querySelector<HTMLInputElement>(
'input[type="file"]',
);
if (input) {
fireEvent.change(input, {
target: { files: [new File(["x"], "u.png")] },
});
}
expect(await screen.findByText("plain-up")).toBeInTheDocument();
});
it("stringifies a non-Error delete rejection", async () => {
const client = makeClient({
// eslint-disable-next-line @typescript-eslint/prefer-promise-reject-errors
remove: vi.fn(() => Promise.reject("plain-del")),
});
render(<Gallery client={client} />);
await screen.findByText("pic.jpg");
await userEvent.click(screen.getByLabelText("Delete pic.jpg"));
await userEvent.click(screen.getByRole("button", { name: "Delete" }));
expect(await screen.findByText("plain-del")).toBeInTheDocument();
});
it("closes the text editor and reloads", async () => {
const client = makeClient();
render(<Gallery client={client} />);
await userEvent.click(await screen.findByText("notes.txt"));
await screen.findByDisplayValue("hello world");
await userEvent.click(screen.getByRole("button", { name: "Close" }));
await waitFor(() => {
expect(screen.queryByDisplayValue("hello world")).toBeNull();
});
// reload() re-invokes list (initial + after close).
expect((client.list as ReturnType<typeof vi.fn>).mock.calls.length).toBeGreaterThan(1);
});
});