mirror of
https://github.com/kuhyx/testsAndMisc.git
synced 2026-11-11 19:34:03 +01:00
Krzysztof kuhy Rudnicki
7e967de79b
10-recon.sh, install_exercism.sh, fix_arch_performance.sh, format_sd_card.sh, setup_dot_resolver.sh, fix_unity.sh and 20-dump-stock.sh, all now under the cap. Splitting a file twice is the risky move: the second cut on 20-dump-stock.sh dropped the first cut's source line, leaving verify_dump called but never defined, and the repair then landed the line inside the lib instead of the entry script. Both fixed - the entry sources both libs and no lib sources another. Grep the source lines after any double split. fix_unity.sh's desktop_dir is read across the seam; renamed to DESKTOP_DIR to match the file's own convention for globals. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011w2Pj4Ek3ZNMQVYcFHgXDY
19 lines
1.7 KiB
JSON
19 lines
1.7 KiB
JSON
{
|
|
"title": "Split seven more linux_configuration scripts across mtk_root, utils, fixes and features",
|
|
"objective": "Bring 10-recon.sh (349), install_exercism.sh (330), fix_arch_performance.sh (326), format_sd_card.sh (323), setup_dot_resolver.sh (309), fix_unity.sh (302) and 20-dump-stock.sh (295) under the 250-line cap.",
|
|
"acceptance_criteria": [
|
|
"All seven entry scripts and all eight new libs are at most 250 lines.",
|
|
"bash -n and shellcheck pass on every touched file, with no new suppression and no shellcheck disable directive.",
|
|
"The stubbed run reports every moved function as defined, for all seven scripts.",
|
|
"When a script is split twice, the second split must not remove the first split's source line: every lib a script's functions live in is sourced by the entry script, and no lib sources another.",
|
|
"No script is executed. These read partitions over USB, format SD cards, install certificates and register MIME handlers.",
|
|
"The desktop_dir global read across the fix_unity split is resolved by matching the file's naming convention for globals, not by a suppression."
|
|
],
|
|
"out_of_scope": [
|
|
"Executing any recon, dump, format or install step. The mtk_root scripts in particular talk to a phone over USB.",
|
|
"The remaining no-main scripts (setup_passwordless_system.sh, nvidia_troubleshoot.sh, main.sh and the test harnesses), which need the by-hand treatment.",
|
|
"Changing what any script does when run."
|
|
],
|
|
"verifier": "scratchpad/verify_split.sh per script (bash -n + shellcheck -x + stubbed run), plus check_file_length.sh showing none of the fifteen files, plus pre-commit run --files and the real git commit for jscpd."
|
|
}
|