mirror of
https://github.com/kuhyx/todo-app.git
synced 2026-11-10 21:27:01 +01:00
Krzysztof kuhy Rudnicki
2ed9267e06
Replaces the inline ColorScheme.fromSeed(Colors.deepPurple) theme with a new lib/ui/theme.dart built from explicit light/dark ColorSchemes on the frozen unified-design-system tokens (same shared spacing/radius/type-scale constants as diet-guard/habit_stack's theme.dart), and adds darkTheme (previously absent). Fixes 2 of 3 violations in DESIGN_AUDIT_TODO.md: - settings_screen.dart's one hardcoded Colors.red -> colorScheme.error, matching every other error-state text in the app - markdown_view.dart and note_editor.dart's raw-mode TextField now cap their reading/editing column at kProseMaxWidth (640) via Center+ConstrainedBox -- the desktop build is an arbitrarily wide Chrome --app window, so text was running the full viewport. Deliberately no extra Column introduced around the raw-mode TextField, per its own documented expands:true/nested-Column regression history. The 3rd violation (a few off-scale SizedBox/EdgeInsets values, e.g. 6px vs the file's dominant 4px scale) was attempted but reverted: bumping the _EnumChips/_MultiChips/_DateRangeField 6px gaps to 8px broke 3 real tests -- the filter bottom sheet's "Apply" button is tight enough against its edge that even a 2px shift pushes it out of the hit-testable area. Not worth trading a working control for a cosmetic 2px scale nitpick; left at 6px. Verified: flutter analyze clean, dart format clean on all touched files, 188/188 tests passing (added test/theme_test.dart for the new file, which had 0% coverage on its own), 100% total line coverage maintained, re-verified identical in an isolated worktree at HEAD (narrowly staged around this repo's own pre-existing uncommitted CLAUDE.md edit, left untouched). A Flutter-web headless-Chrome screenshot check for the desktop target was attempted but blocked by a CanvasKit/WebGL rendering issue in this sandbox, unrelated to the app itself; the widget test suite (which does catch real RenderFlex overflow, as confirmed during this same rollout) passed clean for both touched screens instead. Mobile on-device verification (phone-deploy) is pending -- the phone isn't connected via ADB right now. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| capture_screen_test.dart | ||
| fake_note_repository.dart | ||
| fake_secure_storage.dart | ||
| github_device_auth_test.dart | ||
| local_backup_test.dart | ||
| markdown_view_test.dart | ||
| note_detail_screen_test.dart | ||
| note_editor_test.dart | ||
| note_repository_test.dart | ||
| note_template_test.dart | ||
| note_test.dart | ||
| notes_list_screen_test.dart | ||
| notes_markdown_test.dart | ||
| settings_screen_test.dart | ||
| sync_service_test.dart | ||
| sync_settings_test.dart | ||
| theme_test.dart | ||
| wrapper_server_test.dart | ||