mirror of
https://github.com/kuhyx/todo-app.git
synced 2026-11-10 20:07:02 +01:00
Krzysztof kuhy Rudnicki
85a45daaee
Editing an existing note looked nothing like capturing a new one: it always showed the template dropdown, the View/Guided/Raw pills and the priority/status row. The cause was one missing argument -- both screens already embedded the same NoteEditor, but NoteDetailScreen never passed advancedMode, which defaults to true in the widget while the app-wide AppSettings.advancedMode defaults to false. Extract the shared form as three single-purpose components rather than one widget owning several jobs: - note_meta_row.dart renders the priority/status row (was capture_meta_row.dart; drops the private _MetaDropdown duplicate the detail screen carried, which used DropdownButtonFormField where the shared one uses DropdownButton). - note_form_chrome_gate.dart owns chrome visibility and nothing else, replacing the _chromeVisible flag both screens copy-pasted. - note_form.dart composes those two with NoteEditor. appSettings is now a required parameter through NotesListScreen and NoteDetailScreen. Required, not defaulted: a silent default is exactly what caused this, so it must not be reintroducible. Also in the capture app bar: drop the decorative Icons.list_alt_outlined beside the note count, since the adjacent Icons.list button already names what is counted, and move the count to the right of that button. The finalize-and-clear action becomes Icons.check instead of Icons.add -- it never saved anything (every keystroke is already persisted), so a plus sign misdescribed it. 314 tests, 100% line coverage. Verified in a running web build that edit and capture render identically with advanced mode both off and on. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| capture_app_bar.dart | ||
| capture_draft.dart | ||
| capture_screen_sync.dart | ||
| capture_screen_widget.dart | ||
| capture_screen.dart | ||
| capture_status_footer.dart | ||
| capture_status.dart | ||
| capture_sync_runner.dart | ||
| confirm.dart | ||
| device_code_dialog.dart | ||
| github_mirror_screen_widget.dart | ||
| github_mirror_screen.dart | ||
| markdown_view.dart | ||
| note_actions_sheet.dart | ||
| note_date_range_field.dart | ||
| note_detail_screen.dart | ||
| note_editor_chrome.dart | ||
| note_editor_document.dart | ||
| note_editor_mode.dart | ||
| note_editor_raw_field.dart | ||
| note_editor_step_page.dart | ||
| note_editor_views.dart | ||
| note_editor_widget.dart | ||
| note_editor_wizard.dart | ||
| note_editor.dart | ||
| note_form_chrome_gate.dart | ||
| note_form.dart | ||
| note_meta_row.dart | ||
| note_tile.dart | ||
| notes_filter_sheet.dart | ||
| notes_list_navigation.dart | ||
| notes_list_screen.dart | ||
| settings_screen.dart | ||
| theme.dart | ||