mirror of
https://github.com/kuhyx/todo-app.git
synced 2026-11-10 19:07:02 +01:00
Krzysztof kuhy Rudnicki
85ba556af2
Some checks are pending
release-apk / release (APK) (push) Waiting to run
Fleet audit for the bugs found on diet-guard's desktop; two were live here. `_autoSync` and the manual `_sync` both gated on `settings.isConfigured`, which means "has a GitHub token". A device connected only to Firebase would therefore never sync and would be told to "Add a GitHub token" -- advice that is wrong now and will be wrong for every device once the mirror retires. Both accept either backend, and the prompt names Firebase first. This only escaped notice because this machine happens to hold a GitHub token; diet-guard's desktop, which does not, never synced at all. `loadAccount()` also swallowed its exception whole, hiding why a device could not read its stored account -- indistinguishable from "no account set", and the single most useful diagnostic when provisioning fails. It now logs at error level with the stack trace and still returns null, so the settings screen behaves exactly as before. The unconfigured-Sync test now asserts the routing (unconfigured -> settings) rather than one snackbar phrasing, which is the behaviour that actually matters and does not break on wording. 256 tests, analyzer clean. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0177xwzcpfpWG2qca8Mr39q9 |
||
|---|---|---|
| .. | ||
| capture_screen_test.dart | ||
| confirm_test.dart | ||
| fake_note_repository.dart | ||
| fake_secure_storage.dart | ||
| github_device_auth_test.dart | ||
| local_backup_test.dart | ||
| markdown_view_test.dart | ||
| note_detail_screen_test.dart | ||
| note_editor_test.dart | ||
| note_repository_test.dart | ||
| note_template_test.dart | ||
| note_test.dart | ||
| notes_list_screen_test.dart | ||
| notes_markdown_test.dart | ||
| port_guard_test.dart | ||
| run_sync_test.dart | ||
| settings_screen_test.dart | ||
| sync_service_test.dart | ||
| sync_settings_test.dart | ||
| sync_state_factory_io_test.dart | ||
| theme_test.dart | ||
| wrapper_server_test.dart | ||