mirror of
https://github.com/kuhyx/todo-app.git
synced 2026-11-10 19:27:01 +01:00
Krzysztof kuhy Rudnicki
9f2ffdb8a9
Some checks failed
📎 now picks any file (Android: Camera / Gallery / File; desktop: an
unfiltered dialog) and the desktop page accepts any dropped file. Photo and
screenshot formats up to 64 MB are still re-encoded and shown inline;
everything else is stored byte for byte on dufs beside the images and linked
as [name](url), shown as a row with its size that opens in the platform's
app (Android) or a new browser tab (desktop). BACKLOG.md rewrites file links
to ~/data/cloud/todo-images/ like image links.
There is no size cap, so no layer holds a file in memory: uploads and
downloads stream through DufsImageClient, writes land in a .tmp renamed when
whole (an interrupted download no longer leaves a truncated file that looks
done), the desktop page POSTs the browser's own Blob with fetch, and Android's
"File" uses file_picker, because file_selector's Android side reads the whole
file into memory on the UI thread. Verified with a 1 GB file end to end on
desktop (peak RSS +36 MB) and on an API 36 emulator.
The wrapper serves attachments from the origin that holds the GitHub token
and the notes, so only script-free types open inline (nosniff), the rest
download; writes carrying another site's Origin are refused (this also
closes cross-site overwrites of the backup files); and attachment routes run
concurrently so a long upload or a playing video cannot stall the page.
Also: cupertino_icons 2.0.0 (unused, but the freshness gate blocks the
pubspec otherwise), open_file 4.0.0 and file_picker 13.1.0 pinned.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
35 lines
1.4 KiB
Dart
35 lines
1.4 KiB
Dart
/// Opening an attached file outside the app.
|
|
///
|
|
/// Android hands the cached file to whichever app handles its type (the
|
|
/// system chooser when there is no default), through `open_file`'s
|
|
/// FileProvider. The desktop page opens the wrapper's copy in a new browser
|
|
/// tab, which shows PDFs, text and media and downloads anything else (see
|
|
/// `wrapper_attachment_serving.dart`).
|
|
library;
|
|
|
|
import 'package:open_file/open_file.dart';
|
|
import 'package:todo/attachments/image_store_api.dart';
|
|
import 'package:url_launcher/url_launcher.dart';
|
|
|
|
/// Opens [source], the file called [name]; returns why it could not, or null.
|
|
Future<String?> openAttachedFile(ImageSource source, String name) async {
|
|
switch (source) {
|
|
case LocalImageSource(:final path):
|
|
final result = await OpenFile.open(path);
|
|
return switch (result.type) {
|
|
ResultType.done => null,
|
|
ResultType.noAppToOpen => 'No app on this phone opens $name',
|
|
_ => 'Could not open $name: ${result.message}',
|
|
};
|
|
case NetworkImageSource(:final url):
|
|
final uri = Uri.parse(url);
|
|
final named = uri.replace(
|
|
queryParameters: {...uri.queryParameters, 'name': name},
|
|
);
|
|
final opened = await launchUrl(named, webOnlyWindowName: '_blank');
|
|
return opened ? null : 'Could not open $name';
|
|
case MissingImageSource():
|
|
return '$name is not on this device yet';
|
|
}
|
|
}
|