mirror of
https://github.com/kuhyx/todo-app.git
synced 2026-11-10 20:27:01 +01:00
Krzysztof kuhy Rudnicki
9f2ffdb8a9
Some checks failed
📎 now picks any file (Android: Camera / Gallery / File; desktop: an
unfiltered dialog) and the desktop page accepts any dropped file. Photo and
screenshot formats up to 64 MB are still re-encoded and shown inline;
everything else is stored byte for byte on dufs beside the images and linked
as [name](url), shown as a row with its size that opens in the platform's
app (Android) or a new browser tab (desktop). BACKLOG.md rewrites file links
to ~/data/cloud/todo-images/ like image links.
There is no size cap, so no layer holds a file in memory: uploads and
downloads stream through DufsImageClient, writes land in a .tmp renamed when
whole (an interrupted download no longer leaves a truncated file that looks
done), the desktop page POSTs the browser's own Blob with fetch, and Android's
"File" uses file_picker, because file_selector's Android side reads the whole
file into memory on the UI thread. Verified with a 1 GB file end to end on
desktop (peak RSS +36 MB) and on an API 36 emulator.
The wrapper serves attachments from the origin that holds the GitHub token
and the notes, so only script-free types open inline (nosniff), the rest
download; writes carrying another site's Origin are refused (this also
closes cross-site overwrites of the backup files); and attachment routes run
concurrently so a long upload or a playing video cannot stall the page.
Also: cupertino_icons 2.0.0 (unused, but the freshness gate blocks the
pubspec otherwise), open_file 4.0.0 and file_picker 13.1.0 pinned.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
81 lines
2.3 KiB
Dart
81 lines
2.3 KiB
Dart
import 'dart:typed_data';
|
|
|
|
import 'package:flutter/widgets.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
import 'package:todo/attachments/image_store_api.dart';
|
|
import 'package:todo/attachments/image_store_scope.dart';
|
|
import 'package:todo/images/attachment_ref.dart';
|
|
|
|
void main() {
|
|
final ref = AttachmentRef.create('n1');
|
|
|
|
test('NoImageStore refuses to attach and has nothing', () async {
|
|
final store = NoImageStore();
|
|
await expectLater(
|
|
store.attach('n1', Uint8List(1)),
|
|
throwsA(isA<ImageStoreException>()),
|
|
);
|
|
await expectLater(
|
|
store.attachFile('n1', XFile('/nonexistent')),
|
|
throwsA(isA<ImageStoreException>()),
|
|
);
|
|
await store.reconcile(['x']);
|
|
expect(store.sourceFor(ref), isA<MissingImageSource>());
|
|
expect(store.isPending(ref), isFalse);
|
|
expect(await store.sizeOf(ref), isNull);
|
|
final status = await store.status();
|
|
expect((status.configured, status.pending), (false, 0));
|
|
});
|
|
|
|
test('ImageStoreException shows its message', () {
|
|
expect(const ImageStoreException('boom').toString(), 'boom');
|
|
});
|
|
|
|
test('attachmentRefsAcross unions every note, images and files', () {
|
|
final other = AttachmentRef.create('n2');
|
|
final pdf = AttachmentRef.forFile('n3', 'a.pdf');
|
|
expect(
|
|
attachmentRefsAcross([
|
|
ref.imageMarkdown,
|
|
'${other.imageMarkdown}\n${ref.imageMarkdown}',
|
|
pdf.fileMarkdown('a.pdf'),
|
|
]),
|
|
{ref, other, pdf},
|
|
);
|
|
});
|
|
|
|
testWidgets('the scope provides its store, else a NoImageStore', (
|
|
tester,
|
|
) async {
|
|
final store = NoImageStore();
|
|
late ImageStore found;
|
|
late ImageStore read;
|
|
late ImageStore fallback;
|
|
await tester.pumpWidget(
|
|
Column(
|
|
children: [
|
|
ImageStoreScope(
|
|
store: store,
|
|
child: Builder(
|
|
builder: (context) {
|
|
found = ImageStoreScope.of(context);
|
|
read = ImageStoreScope.read(context);
|
|
return const SizedBox();
|
|
},
|
|
),
|
|
),
|
|
Builder(
|
|
builder: (context) {
|
|
fallback = ImageStoreScope.of(context);
|
|
return const SizedBox();
|
|
},
|
|
),
|
|
],
|
|
),
|
|
);
|
|
expect(found, same(store));
|
|
expect(read, same(store));
|
|
expect(fallback, isA<NoImageStore>());
|
|
});
|
|
}
|