mirror of
https://github.com/kuhyx/todo-app.git
synced 2026-11-10 22:47:01 +01:00
Every split is by test-group/concern, with the shared setup moved to a
sibling helper the splits import. All 313 tests are preserved -- the count
is unchanged and `test('…')` names are byte-identical to the originals
(verified by diffing the sorted name lists).
note_repository_test 677 -> 4 files + note_repository_helpers
capture_screen_test 660 -> 4 files + capture_screen_harness
note_editor_test 502 -> 3 files + note_editor_harness
port_guard_test 405 -> 3 files + port_guard_fakes
wrapper_server_test 402 -> 2 files + wrapper_server_harness
settings_screen_test 391 -> 2 files + settings_screen_harness
github_mirror_screen_test 365 -> 2 files + github_mirror_harness
notes_list_screen_test 347 -> 2 files + notes_list_harness
analytics_service_test 300 -> 2 files + analytics_helpers
Helpers are deliberately NOT named `*_test.dart`; the runner would collect
them and fail on the missing `main()`.
Three things did not survive a mechanical split and were handled explicitly:
* wrapper_server's `enabledOrigin` closes over the `late root` that setUp
assigns, so a top-level function cannot see it. It is now a
WrapperHarness class with an install() that registers the setUp/tearDown
pair -- the only structural change in this commit.
* note_repository's splits each repeat `setUpAll(sqfliteFfiInit)`, and
analytics' each repeat `@TestOn('vm')`. Omitting either fails quietly
(uninitialised sqflite / wrong platform) rather than loudly.
* capture_screen's `recordingMock` was declared mid-file between two
tests, so it moved to the harness rather than being dropped.
Verified: 313 tests pass (same as before the refactor), 100% coverage.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
220 lines
7.1 KiB
Dart
220 lines
7.1 KiB
Dart
import 'dart:convert';
|
|
|
|
import 'package:crdt_sync/crdt_sync.dart';
|
|
import 'package:flutter/material.dart';
|
|
import 'package:flutter/services.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
import 'package:http/http.dart' as http;
|
|
import 'package:http/testing.dart';
|
|
import 'package:plugin_platform_interface/plugin_platform_interface.dart';
|
|
import 'package:shared_preferences/shared_preferences.dart';
|
|
import 'package:todo/data/app_settings.dart';
|
|
import 'package:todo/sync/sync_settings.dart';
|
|
import 'package:todo/ui/github_mirror_screen.dart';
|
|
import 'package:url_launcher_platform_interface/link.dart';
|
|
import 'package:url_launcher_platform_interface/url_launcher_platform_interface.dart';
|
|
|
|
import 'fake_note_repository.dart';
|
|
import 'fake_secure_storage.dart';
|
|
|
|
import 'github_mirror_harness.dart';
|
|
|
|
/// Stub launcher that records the URL instead of opening it, so `_openPage`
|
|
/// can be exercised without a real platform channel.
|
|
class _FakeUrlLauncher extends UrlLauncherPlatform
|
|
with MockPlatformInterfaceMixin {
|
|
String? launched;
|
|
|
|
@override
|
|
final LinkDelegate? linkDelegate = null;
|
|
|
|
@override
|
|
Future<bool> supportsMode(PreferredLaunchMode mode) async => true;
|
|
|
|
@override
|
|
Future<bool> launchUrl(String url, LaunchOptions options) async {
|
|
launched = url;
|
|
return true;
|
|
}
|
|
}
|
|
|
|
void main() {
|
|
testWidgets('device flow connects but surfaces a post-connect sync failure', (
|
|
tester,
|
|
) async {
|
|
final mock = MockClient((req) async {
|
|
if (req.url.path.contains('device/code')) {
|
|
return http.Response(
|
|
jsonEncode({
|
|
'device_code': 'dev123',
|
|
'user_code': 'WXYZ-1234',
|
|
'verification_uri': 'https://github.com/login/device',
|
|
'interval': 0,
|
|
'expires_in': 900,
|
|
}),
|
|
200,
|
|
);
|
|
}
|
|
if (req.url.path.contains('login/oauth/access_token')) {
|
|
return http.Response(jsonEncode({'access_token': 'gho_test'}), 200);
|
|
}
|
|
return http.Response('boom', 500); // the sync's repo calls fail
|
|
});
|
|
|
|
await pumpMirror(
|
|
tester,
|
|
initial: const SyncSettings(
|
|
owner: 'o',
|
|
repo: 'r',
|
|
token: '',
|
|
clientId: 'cid',
|
|
),
|
|
httpClient: mock,
|
|
);
|
|
|
|
await tester.tap(find.text('Connect GitHub'));
|
|
await tester.pump();
|
|
await tester.pump();
|
|
await tester.pump(const Duration(milliseconds: 50));
|
|
for (var i = 0; i < 6; i++) {
|
|
await tester.pump();
|
|
}
|
|
|
|
expect(find.textContaining('sync failed'), findsOneWidget);
|
|
});
|
|
|
|
testWidgets('Save persists the settings and closes the screen', (
|
|
tester,
|
|
) async {
|
|
SharedPreferences.setMockInitialValues({});
|
|
installFakeSecureStorage();
|
|
tester.view.physicalSize = const Size(1200, 2800);
|
|
tester.view.devicePixelRatio = 1.0;
|
|
addTearDown(tester.view.resetPhysicalSize);
|
|
addTearDown(tester.view.resetDevicePixelRatio);
|
|
|
|
final repo = FakeNoteRepository();
|
|
addTearDown(repo.close);
|
|
|
|
// Push GitHubMirrorScreen over a base route so _save's Navigator.pop has
|
|
// somewhere to return to (popping the root route is a no-op and hides
|
|
// the result).
|
|
await tester.pumpWidget(
|
|
MaterialApp(
|
|
home: Builder(
|
|
builder: (context) => Scaffold(
|
|
body: Center(
|
|
child: ElevatedButton(
|
|
onPressed: () => Navigator.of(context).push(
|
|
MaterialPageRoute<SyncSettings>(
|
|
builder: (_) => GitHubMirrorScreen(
|
|
initial: const SyncSettings(
|
|
owner: 'o',
|
|
repo: 'r',
|
|
token: 'tok',
|
|
),
|
|
repository: repo,
|
|
appSettings: ValueNotifier(
|
|
const AppSettings(advancedMode: false),
|
|
),
|
|
firebaseFactory: () async => null,
|
|
stateStore: InMemorySyncStateStore(),
|
|
),
|
|
),
|
|
),
|
|
child: const Text('open'),
|
|
),
|
|
),
|
|
),
|
|
),
|
|
),
|
|
);
|
|
|
|
await tester.tap(find.text('open'));
|
|
await tester.pump();
|
|
await tester.pump(const Duration(milliseconds: 400)); // route transition
|
|
expect(find.byType(GitHubMirrorScreen), findsOneWidget); // screen is up
|
|
|
|
await tester.tap(find.text('Save'));
|
|
await tester.pump(); // run _save (persist + pop)
|
|
await tester.pump(const Duration(milliseconds: 400)); // pop transition
|
|
|
|
expect(find.text('open'), findsOneWidget); // back on the base route
|
|
final saved = await SyncSettings.load();
|
|
expect(saved.owner, 'o');
|
|
expect(saved.token, 'tok');
|
|
});
|
|
|
|
testWidgets('device dialog: failed poll shows the error and Open launches', (
|
|
tester,
|
|
) async {
|
|
final launcher = _FakeUrlLauncher();
|
|
UrlLauncherPlatform.instance = launcher;
|
|
|
|
// _openPage copies the code to the clipboard first; there's no
|
|
// clipboard plugin in the test host, so stub the channel to succeed.
|
|
final messenger =
|
|
TestDefaultBinaryMessengerBinding.instance.defaultBinaryMessenger;
|
|
messenger.setMockMethodCallHandler(
|
|
SystemChannels.platform,
|
|
(call) async => null,
|
|
);
|
|
addTearDown(
|
|
() => messenger.setMockMethodCallHandler(SystemChannels.platform, null),
|
|
);
|
|
|
|
final mock = MockClient((req) async {
|
|
if (req.url.path.contains('device/code')) {
|
|
return http.Response(
|
|
jsonEncode({
|
|
'device_code': 'dev123',
|
|
'user_code': 'WXYZ-1234',
|
|
'verification_uri': 'https://github.com/login/device',
|
|
'interval': 0,
|
|
'expires_in': 900,
|
|
}),
|
|
200,
|
|
);
|
|
}
|
|
// Token endpoint: a terminal error ends the poll loop cleanly (no
|
|
// lingering timer to trip the tester's pending-timer guard).
|
|
return http.Response(
|
|
jsonEncode({'error': 'access_denied', 'error_description': 'nope'}),
|
|
200,
|
|
);
|
|
});
|
|
|
|
await pumpMirror(
|
|
tester,
|
|
initial: const SyncSettings(
|
|
owner: 'o',
|
|
repo: 'r',
|
|
token: '',
|
|
clientId: 'cid',
|
|
),
|
|
httpClient: mock,
|
|
);
|
|
|
|
await tester.tap(find.text('Connect GitHub'));
|
|
await tester.pump(); // requestDeviceCode
|
|
await tester.pump(); // dialog builds, poll starts (interval 0)
|
|
expect(find.text('WXYZ-1234'), findsOneWidget);
|
|
|
|
await tester.pump(const Duration(milliseconds: 1)); // _delay(0) fires
|
|
await tester.pump(); // token error throws → _error set
|
|
expect(find.textContaining('nope'), findsOneWidget); // error rendered
|
|
|
|
// Tap the "open on GitHub" action: copies the code and launches the URL.
|
|
// _openPage awaits Clipboard.setData then the launcher's supportsMode +
|
|
// launchUrl; pumpAndSettle drains them (no spinner is animating now
|
|
// that the error is shown, so it settles).
|
|
await tester.tap(find.byIcon(Icons.open_in_new));
|
|
await tester.pumpAndSettle();
|
|
expect(launcher.launched, 'https://github.com/login/device');
|
|
|
|
await tester.tap(find.text('Cancel'));
|
|
await tester.pumpAndSettle(); // finish the dialog pop animation
|
|
expect(find.text('WXYZ-1234'), findsNothing); // dialog dismissed
|
|
});
|
|
}
|