mirror of
https://github.com/kuhyx/todo-app.git
synced 2026-11-11 12:47:46 +01:00
Every split is by test-group/concern, with the shared setup moved to a
sibling helper the splits import. All 313 tests are preserved -- the count
is unchanged and `test('…')` names are byte-identical to the originals
(verified by diffing the sorted name lists).
note_repository_test 677 -> 4 files + note_repository_helpers
capture_screen_test 660 -> 4 files + capture_screen_harness
note_editor_test 502 -> 3 files + note_editor_harness
port_guard_test 405 -> 3 files + port_guard_fakes
wrapper_server_test 402 -> 2 files + wrapper_server_harness
settings_screen_test 391 -> 2 files + settings_screen_harness
github_mirror_screen_test 365 -> 2 files + github_mirror_harness
notes_list_screen_test 347 -> 2 files + notes_list_harness
analytics_service_test 300 -> 2 files + analytics_helpers
Helpers are deliberately NOT named `*_test.dart`; the runner would collect
them and fail on the missing `main()`.
Three things did not survive a mechanical split and were handled explicitly:
* wrapper_server's `enabledOrigin` closes over the `late root` that setUp
assigns, so a top-level function cannot see it. It is now a
WrapperHarness class with an install() that registers the setUp/tearDown
pair -- the only structural change in this commit.
* note_repository's splits each repeat `setUpAll(sqfliteFfiInit)`, and
analytics' each repeat `@TestOn('vm')`. Omitting either fails quietly
(uninitialised sqflite / wrong platform) rather than loudly.
* capture_screen's `recordingMock` was declared mid-file between two
tests, so it moved to the harness rather than being dropped.
Verified: 313 tests pass (same as before the refactor), 100% coverage.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
107 lines
4.1 KiB
Dart
107 lines
4.1 KiB
Dart
/// The shared harness for the capture-screen test files.
|
|
///
|
|
/// `capture_screen_test.dart` was split by concern for the 250-line cap.
|
|
/// [pumpCapture] closes over the `WidgetTester`'s view and addTearDown, so it
|
|
/// takes the tester as a parameter rather than being a closure inside main().
|
|
///
|
|
/// Deliberately NOT named `*_test.dart`: the runner would collect it and fail
|
|
/// on the missing `main()`.
|
|
library;
|
|
|
|
import 'dart:convert';
|
|
|
|
import 'package:crdt_sync/crdt_sync.dart';
|
|
import 'package:flutter/material.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
import 'package:http/http.dart' as http;
|
|
import 'package:http/testing.dart';
|
|
import 'package:shared_preferences/shared_preferences.dart';
|
|
import 'package:todo/analytics/analytics_service.dart';
|
|
import 'package:todo/data/app_settings.dart';
|
|
import 'package:todo/data/note.dart';
|
|
import 'package:todo/data/note_template.dart';
|
|
import 'package:todo/sync/local_backup.dart';
|
|
import 'package:todo/sync/notes_markdown.dart';
|
|
import 'package:todo/ui/capture_screen.dart';
|
|
import 'package:todo/ui/github_mirror_screen.dart';
|
|
import 'package:todo/ui/settings_screen.dart';
|
|
|
|
import 'fake_note_repository.dart';
|
|
import 'fake_secure_storage.dart';
|
|
|
|
// A real CRDT DB schedules sqflite timers that never drain under the
|
|
// widget tester's fake clock, so these tests inject a timer-free fake.
|
|
// (NOTE: avoid pumpAndSettle — the autofocused field's cursor blink never
|
|
// settles; pump explicit frames instead.)
|
|
Future<FakeNoteRepository> pumpCapture(
|
|
WidgetTester tester, {
|
|
Map<String, Object> prefs = const {},
|
|
http.Client? httpClient,
|
|
List<Note> seed = const [],
|
|
FakeNoteRepository? repository,
|
|
LocalBackup? localBackup,
|
|
Future<FirebaseRestClient?> Function()? firebaseFactory,
|
|
// Defaults to true: these tests exercise today's full UI (priority/status
|
|
// dropdowns, sync status text, Guided). Tests for the new default-off
|
|
// behavior pass advancedMode: false explicitly.
|
|
ValueNotifier<AppSettings>? appSettings,
|
|
AnalyticsService? analytics,
|
|
}) async {
|
|
SharedPreferences.setMockInitialValues(prefs);
|
|
installFakeSecureStorage();
|
|
// Tall surface so a pushed settings screen builds its whole ListView.
|
|
tester.view.physicalSize = const Size(1200, 2800);
|
|
tester.view.devicePixelRatio = 1.0;
|
|
addTearDown(tester.view.resetPhysicalSize);
|
|
addTearDown(tester.view.resetDevicePixelRatio);
|
|
|
|
final repo = repository ?? FakeNoteRepository(seed);
|
|
addTearDown(repo.close);
|
|
// Default to an in-memory, no-op backup so tests never touch real disk
|
|
// (the production backup writes ~/todo/BACKLOG.md on the Linux test host).
|
|
final backup =
|
|
localBackup ??
|
|
LocalBackup(
|
|
fetch: repo.listNotes,
|
|
reader: () async => null,
|
|
writer: (_) async {},
|
|
debounce: Duration.zero,
|
|
);
|
|
await tester.pumpWidget(
|
|
MaterialApp(
|
|
home: CaptureScreen(
|
|
repository: repo,
|
|
appSettings:
|
|
appSettings ?? ValueNotifier(const AppSettings(advancedMode: true)),
|
|
analytics: analytics,
|
|
httpClient: httpClient,
|
|
// Both injected so the widget never reaches for the platform: the
|
|
// real factories want the OS keystore and an application-support
|
|
// directory, neither of which exists under `flutter test`.
|
|
firebaseFactory: firebaseFactory ?? () async => null,
|
|
stateStore: InMemorySyncStateStore(),
|
|
localBackup: backup,
|
|
),
|
|
),
|
|
);
|
|
await tester.pump(); // flush initial stream + settings load
|
|
return repo;
|
|
}
|
|
|
|
// Seeds a fully configured GitHub sync so the configured `_sync` path runs.
|
|
const configuredPrefs = {
|
|
'sync.owner': 'o',
|
|
'sync.repo': 'r',
|
|
'sync.token': 'tok',
|
|
};
|
|
|
|
// A MockClient that records request methods and answers the sync flow:
|
|
// repo-exists GET (not /contents/) → 200, the (empty) log listing → 404,
|
|
// and the device's own PUT → 200.
|
|
MockClient recordingMock(List<String> methods) => MockClient((req) async {
|
|
methods.add(req.method);
|
|
if (req.method == 'PUT') return http.Response('{}', 200);
|
|
if (!req.url.path.contains('/contents/')) return http.Response('{}', 200);
|
|
return http.Response('', 404);
|
|
});
|