mirror of
https://github.com/kuhyx/todo-app.git
synced 2026-11-10 19:07:02 +01:00
Krzysztof kuhy Rudnicki
ea76a04388
Some checks failed
release-apk / release (APK) (push) Has been cancelled
The Firebase backend has been wired up since the cutover commit, but nothing ever called saveAccount(). openFirebase() therefore read an account that was never written, returned null every time, and the app quietly synced over GitHub forever -- on real hardware, regardless of what the tests said. The same hole was found and fixed in diet-guard; it is still open in home_inventory, workout_app, build_your_x and leetcode-guard. Settings now has a Firebase section that stores the account and signs in immediately, so a wrong password shows up on screen instead of as a silent no-op later. A rejected sign-in clears the account rather than leaving it half-stored. The three UI problems kuhy hit in diet-guard are avoided rather than repeated: GitHub moves into "Advanced (GitHub mirror)" instead of sitting beside Firebase as a peer choice, and a connected account renders as read-only text with a Disconnect button rather than an empty-looking form that implies you still have to type something. The keystore accessors are injectable, like firebaseFactory already was, so the connect/reject/disconnect branches are testable without a platform channel. 252 tests, back to 100% line coverage. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017FH32BgGQbQLDstBhR26Xa |
||
|---|---|---|
| .. | ||
| data | ||
| desktop | ||
| sync | ||
| ui | ||
| frame_stats_io.dart | ||
| frame_stats_web.dart | ||
| frame_stats.dart | ||
| main.dart | ||