mirror of
https://github.com/kuhyx/todo-app.git
synced 2026-11-10 20:27:01 +01:00
Editing an existing note looked nothing like capturing a new one: it always showed the template dropdown, the View/Guided/Raw pills and the priority/status row. The cause was one missing argument -- both screens already embedded the same NoteEditor, but NoteDetailScreen never passed advancedMode, which defaults to true in the widget while the app-wide AppSettings.advancedMode defaults to false. Extract the shared form as three single-purpose components rather than one widget owning several jobs: - note_meta_row.dart renders the priority/status row (was capture_meta_row.dart; drops the private _MetaDropdown duplicate the detail screen carried, which used DropdownButtonFormField where the shared one uses DropdownButton). - note_form_chrome_gate.dart owns chrome visibility and nothing else, replacing the _chromeVisible flag both screens copy-pasted. - note_form.dart composes those two with NoteEditor. appSettings is now a required parameter through NotesListScreen and NoteDetailScreen. Required, not defaulted: a silent default is exactly what caused this, so it must not be reintroducible. Also in the capture app bar: drop the decorative Icons.list_alt_outlined beside the note count, since the adjacent Icons.list button already names what is counted, and move the count to the right of that button. The finalize-and-clear action becomes Icons.check instead of Icons.add -- it never saved anything (every keystroke is already persisted), so a plus sign misdescribed it. 314 tests, 100% line coverage. Verified in a running web build that edit and capture render identically with advanced mode both off and on. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
173 lines
5.6 KiB
Dart
173 lines
5.6 KiB
Dart
import 'package:flutter/material.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
import 'package:todo/data/app_settings.dart';
|
|
import 'package:todo/data/note.dart';
|
|
import 'package:todo/ui/note_detail_screen.dart';
|
|
|
|
import 'fake_note_repository.dart';
|
|
|
|
void main() {
|
|
Note seedNote(String text) => Note(
|
|
id: 'n1',
|
|
text: text,
|
|
priority: Priority.medium,
|
|
status: Status.todo,
|
|
createdAt: DateTime(2026, 6, 15, 9),
|
|
updatedAt: DateTime(2026, 6, 15, 9),
|
|
);
|
|
|
|
Future<FakeNoteRepository> pumpDetail(
|
|
WidgetTester tester,
|
|
Note note, {
|
|
bool advancedMode = true,
|
|
}) async {
|
|
tester.view.physicalSize = const Size(1200, 2400);
|
|
tester.view.devicePixelRatio = 1.0;
|
|
addTearDown(tester.view.resetPhysicalSize);
|
|
addTearDown(tester.view.resetDevicePixelRatio);
|
|
|
|
final repo = FakeNoteRepository([note]);
|
|
addTearDown(repo.close);
|
|
final settings = ValueNotifier(AppSettings(advancedMode: advancedMode));
|
|
addTearDown(settings.dispose);
|
|
await tester.pumpWidget(
|
|
MaterialApp(
|
|
home: NoteDetailScreen(
|
|
note: note,
|
|
repository: repo,
|
|
appSettings: settings,
|
|
),
|
|
),
|
|
);
|
|
await tester.pump();
|
|
return repo;
|
|
}
|
|
|
|
testWidgets('opens in Raw with the title in the app bar', (tester) async {
|
|
await pumpDetail(tester, seedNote('# My note\n\n## what\n_why_\n\nbody'));
|
|
|
|
final raw = tester.widget<TextField>(find.byType(TextField));
|
|
expect(raw.controller!.text, contains('My note'));
|
|
expect(find.text('My note'), findsOneWidget); // app bar title
|
|
});
|
|
|
|
testWidgets('changing the priority dropdown persists the note', (
|
|
tester,
|
|
) async {
|
|
final repo = await pumpDetail(tester, seedNote('# T'));
|
|
|
|
await tester.tap(
|
|
find.byWidgetPredicate((w) => w is DropdownButton<Priority>),
|
|
);
|
|
await tester.pumpAndSettle();
|
|
await tester.tap(find.text('High').last);
|
|
await tester.pumpAndSettle();
|
|
|
|
expect((await repo.listNotes()).single.priority, Priority.high);
|
|
});
|
|
|
|
testWidgets('changing the status dropdown persists the note', (tester) async {
|
|
final repo = await pumpDetail(tester, seedNote('# T'));
|
|
|
|
await tester.tap(
|
|
find.byWidgetPredicate((w) => w is DropdownButton<Status>),
|
|
);
|
|
await tester.pumpAndSettle();
|
|
await tester.tap(find.text('Done').last);
|
|
await tester.pumpAndSettle();
|
|
|
|
expect((await repo.listNotes()).single.status, Status.done);
|
|
});
|
|
|
|
testWidgets('editing the body in Raw mode persists the new text', (
|
|
tester,
|
|
) async {
|
|
final repo = await pumpDetail(tester, seedNote('# T\n\n## what\nold'));
|
|
|
|
await tester.tap(find.text('Raw'));
|
|
await tester.pump();
|
|
await tester.enterText(find.byType(TextField), '# T\n\n## what\nnew body');
|
|
await tester.pump();
|
|
|
|
expect((await repo.listNotes()).single.text, contains('new body'));
|
|
});
|
|
|
|
testWidgets(
|
|
'clearing the body then tapping Guided runs the wizard and persists the chosen priority',
|
|
(tester) async {
|
|
final repo = await pumpDetail(tester, seedNote('# T\n\n## what\nold'));
|
|
|
|
await tester.enterText(find.byType(TextField), '');
|
|
await tester.pump();
|
|
|
|
await tester.tap(find.text('Guided'));
|
|
await tester.pump();
|
|
expect(find.text('Step 1 of 2'), findsOneWidget);
|
|
// Wizard hides the Status dropdown (onChromeVisibleChanged(false)).
|
|
expect(find.text('Status'), findsNothing);
|
|
|
|
await tester.tap(find.byType(DropdownButtonFormField<Priority>));
|
|
await tester.pumpAndSettle();
|
|
await tester.tap(find.text('High').last);
|
|
await tester.pumpAndSettle();
|
|
|
|
await tester.tap(find.text('Next'));
|
|
await tester.pump();
|
|
await tester.tap(find.text('Start'));
|
|
await tester.pump();
|
|
|
|
expect((await repo.listNotes()).single.priority, Priority.high);
|
|
},
|
|
);
|
|
|
|
// The regression this screen was built to stop: it used to let
|
|
// NoteEditor.advancedMode default to true, so editing an existing note
|
|
// showed the template dropdown and the View/Guided/Raw pills even though
|
|
// capture -- with the same app-wide setting off -- showed a bare box.
|
|
testWidgets('advanced mode off hides every chrome control, as capture does', (
|
|
tester,
|
|
) async {
|
|
await pumpDetail(
|
|
tester,
|
|
seedNote('# T\n\n## what\nbody'),
|
|
advancedMode: false,
|
|
);
|
|
|
|
expect(find.text('Template'), findsNothing);
|
|
expect(find.text('Guided'), findsNothing);
|
|
expect(find.text('Raw'), findsNothing);
|
|
expect(find.text('Priority'), findsNothing);
|
|
expect(find.text('Status'), findsNothing);
|
|
// The body itself is still editable — only the chrome is gone.
|
|
expect(find.byType(TextField), findsOneWidget);
|
|
});
|
|
|
|
testWidgets('the delete action removes the note and pops', (tester) async {
|
|
final repo = await pumpDetail(tester, seedNote('# Bye'));
|
|
|
|
await tester.tap(find.byTooltip('Delete note'));
|
|
await tester.pumpAndSettle();
|
|
|
|
// Delete is now confirmed. Deleting a note is irreversible and there is no
|
|
// undo, so a single Return on a focused control must not destroy it.
|
|
expect(find.text('Delete note?'), findsOneWidget);
|
|
await tester.tap(find.text('Delete'));
|
|
await tester.pumpAndSettle();
|
|
|
|
expect(await repo.listNotes(), isEmpty);
|
|
expect(find.byType(NoteDetailScreen), findsNothing);
|
|
});
|
|
|
|
testWidgets('cancelling the delete keeps the note', (tester) async {
|
|
final repo = await pumpDetail(tester, seedNote('# Keep me'));
|
|
|
|
await tester.tap(find.byTooltip('Delete note'));
|
|
await tester.pumpAndSettle();
|
|
await tester.tap(find.text('Cancel'));
|
|
await tester.pumpAndSettle();
|
|
|
|
expect(await repo.listNotes(), hasLength(1));
|
|
expect(find.byType(NoteDetailScreen), findsOneWidget);
|
|
});
|
|
}
|