mirror of
https://github.com/kuhyx/utils.git
synced 2026-11-22 17:52:28 +01:00
Refuse to overwrite utils' own checker with the delegate shim
Some checks are pending
dependency freshness / dependencies on newest stable (push) Waiting to run
file length / file-length (push) Waiting to run
md-naming / markdown naming convention (push) Waiting to run
palette drift / palette (push) Waiting to run
shared gate tests / gate unit tests (push) Waiting to run
Some checks are pending
dependency freshness / dependencies on newest stable (push) Waiting to run
file length / file-length (push) Waiting to run
md-naming / markdown naming convention (push) Waiting to run
palette drift / palette (push) Waiting to run
shared gate tests / gate unit tests (push) Waiting to run
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
parent
570f168a78
commit
23f4322197
28
.github/workflows/dependency-freshness.yml
vendored
28
.github/workflows/dependency-freshness.yml
vendored
@ -1,12 +1,7 @@
|
|||||||
name: dependency freshness
|
name: dependency freshness
|
||||||
|
|
||||||
# Every dependency on its ecosystem's newest STABLE release, enforced on push
|
# Every dependency on its ecosystem's newest STABLE release, enforced on push
|
||||||
# as well as at commit time. This repo OWNS the gate, so unlike every other
|
# as well as at commit time. The local pre-commit hook only sees the manifests
|
||||||
# repo it runs its own copy directly instead of checking one out.
|
|
||||||
#
|
|
||||||
# Deliberately added last, after all eleven manifests here were brought
|
|
||||||
# current: installing the gate on a repo before its dependencies are upgraded
|
|
||||||
# makes it instantly and permanently red, which teaches people to ignore it. The local pre-commit hook only sees the manifests
|
|
||||||
# in a commit and can be skipped entirely by a fresh clone that never ran
|
# in a commit and can be skipped entirely by a fresh clone that never ran
|
||||||
# `pre-commit install`; this runs `--all` over the whole repo.
|
# `pre-commit install`; this runs `--all` over the whole repo.
|
||||||
#
|
#
|
||||||
@ -33,10 +28,24 @@ jobs:
|
|||||||
steps:
|
steps:
|
||||||
- uses: actions/checkout@v4
|
- uses: actions/checkout@v4
|
||||||
|
|
||||||
|
# The gate lives in the shared utils repo so every repo resolves the
|
||||||
|
# same "latest stable" the same way. Checking it out beats vendoring a
|
||||||
|
# copy, which is exactly how a gate and its survey start disagreeing.
|
||||||
|
- name: Check out the shared gate
|
||||||
|
uses: actions/checkout@v4
|
||||||
|
with:
|
||||||
|
repository: kuhyx/utils
|
||||||
|
path: .utils
|
||||||
|
|
||||||
|
# "3.x", never a pinned minor: the Python target IS the interpreter the
|
||||||
|
# gate runs under (registries/toolchain.python_installed), so a runner
|
||||||
|
# held a release behind this machine reports a repo's `requires-python`
|
||||||
|
# as excluding "latest" while the same check passes locally. flax-docs-mcp
|
||||||
|
# hit exactly that -- `>=3.14` green here, red on a 3.13 runner.
|
||||||
- name: Set up Python
|
- name: Set up Python
|
||||||
uses: actions/setup-python@v5
|
uses: actions/setup-python@v5
|
||||||
with:
|
with:
|
||||||
python-version: "3.13"
|
python-version: "3.x"
|
||||||
|
|
||||||
- name: Install the gate's two runtime dependencies
|
- name: Install the gate's two runtime dependencies
|
||||||
run: python -m pip install --upgrade pyyaml packaging
|
run: python -m pip install --upgrade pyyaml packaging
|
||||||
@ -45,8 +54,9 @@ jobs:
|
|||||||
uses: actions/cache@v4
|
uses: actions/cache@v4
|
||||||
with:
|
with:
|
||||||
path: ~/.cache/dep-freshness
|
path: ~/.cache/dep-freshness
|
||||||
key: dep-freshness-${{ hashFiles('**/pubspec.yaml', '**/package.json', '**/requirements*.txt', '**/pyproject.toml') }}
|
key: dep-freshness-${{ hashFiles('**/pubspec.yaml', '**/pyproject.toml',
|
||||||
|
'**/requirements*.txt', '**/package.json', '**/Cargo.toml', '**/go.mod') }}
|
||||||
restore-keys: dep-freshness-
|
restore-keys: dep-freshness-
|
||||||
|
|
||||||
- name: Every dependency is on newest stable
|
- name: Every dependency is on newest stable
|
||||||
run: bash scripts/check_dependency_freshness.sh --all --strict
|
run: bash .utils/scripts/check_dependency_freshness.sh --all --strict
|
||||||
|
|||||||
@ -35,7 +35,20 @@ def _template(name: str) -> str:
|
|||||||
return (TEMPLATES / name).read_text(encoding="utf-8")
|
return (TEMPLATES / name).read_text(encoding="utf-8")
|
||||||
|
|
||||||
|
|
||||||
|
def _owns_the_shared_gate(repo: Path) -> bool:
|
||||||
|
"""True for utils itself, where DELEGATE is the real checker, not a shim.
|
||||||
|
|
||||||
|
Without this the installer "fixes drift" in the one repo whose copy is
|
||||||
|
supposed to differ, and the result execs itself: the delegate resolves
|
||||||
|
the shared gate to `$HOME/utils/scripts/check_dependency_freshness.sh`,
|
||||||
|
which is the file it just overwrote.
|
||||||
|
"""
|
||||||
|
return (repo / "dep_freshness" / "check.py").is_file()
|
||||||
|
|
||||||
|
|
||||||
def _needs_delegate(repo: Path) -> bool:
|
def _needs_delegate(repo: Path) -> bool:
|
||||||
|
if _owns_the_shared_gate(repo):
|
||||||
|
return False
|
||||||
target = repo / DELEGATE
|
target = repo / DELEGATE
|
||||||
return not target.is_file() or target.read_text(encoding="utf-8") != _template(
|
return not target.is_file() or target.read_text(encoding="utf-8") != _template(
|
||||||
"delegate.sh"
|
"delegate.sh"
|
||||||
|
|||||||
@ -229,3 +229,21 @@ repos:
|
|||||||
)
|
)
|
||||||
with pytest.raises(ValueError, match="no ` - repo: local` block"):
|
with pytest.raises(ValueError, match="no ` - repo: local` block"):
|
||||||
installer.install(repo)
|
installer.install(repo)
|
||||||
|
|
||||||
|
|
||||||
|
def test_utils_own_checker_is_never_replaced_by_the_delegate(repo):
|
||||||
|
"""The one repo whose copy is meant to differ.
|
||||||
|
|
||||||
|
utils holds the real checker at the delegate's path. Overwriting it with
|
||||||
|
the shim makes the gate exec itself, because the shim resolves the shared
|
||||||
|
gate to exactly the file it just replaced.
|
||||||
|
"""
|
||||||
|
real = "#!/bin/bash\n# the real checker, not a shim\n"
|
||||||
|
write(repo, "dep_freshness/check.py", "# the shared implementation\n")
|
||||||
|
write(repo, "scripts/check_dependency_freshness.sh", real)
|
||||||
|
|
||||||
|
assert "scripts/check_dependency_freshness.sh" not in installer.plan(repo)
|
||||||
|
installer.install(repo)
|
||||||
|
assert (repo / "scripts/check_dependency_freshness.sh").read_text(
|
||||||
|
encoding="utf-8"
|
||||||
|
) == real
|
||||||
|
|||||||
Loading…
Reference in New Issue
Block a user