utils/dep_freshness/allowlist.py
Krzysztof kuhy Rudnicki 4d00d6ccde
Some checks are pending
dependency freshness / dependencies on newest stable (push) Waiting to run
file length / file-length (push) Waiting to run
md-naming / markdown naming convention (push) Waiting to run
palette drift / palette (push) Waiting to run
shared gate tests / gate unit tests (push) Waiting to run
dep_freshness: upstream: allowlist predicate for forks; Google API clients judged inside their generation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-09-12 20:32:34 +02:00

153 lines
5.8 KiB
Python

"""Parse and validate `dependency-freshness.allowlist.yaml`.
Two entry classes, and the distinction is the whole point:
* `blocked_by: transitive:<pkg>@<ver>` is a **predicate**. The blocker is
re-evaluated every run and the entry clears itself when upstream moves. It
never expires on a calendar, because a date nobody can act on turns the gate
red for a reason no commit can fix.
* `blocked_by: upstream:<owner>/<repo>` is the fork's predicate: it holds
while that repository's copy of the same manifest pins the same version
(`upstream.py`), and dies the day upstream bumps.
* anything else is **discretionary**: it needs `expires`, capped at 90 days,
and fails once past.
Malformed, expired, over-cap and no-longer-needed entries all exit 2 — an
allowlist that rots silently is a suppression, not an exception.
"""
from __future__ import annotations
import os
from datetime import date, datetime
from pathlib import Path
import yaml
from dep_freshness._tables import (
ALLOWLIST_FILE,
ALLOWLIST_MAX_DAYS,
SHARED_ALLOWLIST_ENV,
)
from dep_freshness.models import Exception_
REQUIRED = ("ecosystem", "package", "pinned", "reason", "blocked_by")
class AllowlistError(Exception):
"""The allowlist itself is wrong; the gate refuses to run against it."""
def path_for(root: Path) -> Path:
return root / ALLOWLIST_FILE
def shared_path() -> Path:
"""The fleet-wide allowlist that every repo inherits.
Lives beside the gate it belongs to. Overridable so a test -- or a machine
that keeps utils somewhere else -- is not forced to touch the real one.
"""
override = os.environ.get(SHARED_ALLOWLIST_ENV)
if override:
return Path(override).expanduser()
return Path(__file__).resolve().parent.parent / ALLOWLIST_FILE
def _parse_date(raw: object, where: str) -> date:
if isinstance(raw, date) and not isinstance(raw, datetime):
return raw
try:
return datetime.strptime(str(raw), "%Y-%m-%d").date()
except ValueError as exc:
raise AllowlistError(f"{where}: expires must be YYYY-MM-DD, got {raw!r}") from exc
def _entry(raw: object, source: Path, position: int) -> Exception_:
where = f"{source}: exceptions[{position}]"
if not isinstance(raw, dict):
raise AllowlistError(f"{where}: each exception must be a mapping")
missing = [field for field in REQUIRED if not str(raw.get(field, "")).strip()]
if missing:
raise AllowlistError(f"{where}: missing required field(s): {', '.join(missing)}")
entry = Exception_(
ecosystem=str(raw["ecosystem"]).strip(),
package=str(raw["package"]).strip(),
pinned=str(raw["pinned"]).strip(),
reason=str(raw["reason"]).strip(),
blocked_by=str(raw["blocked_by"]).strip(),
latest_known=(str(raw["latest_known"]).strip()
if raw.get("latest_known") else None),
expires=(str(raw["expires"]).strip() if raw.get("expires") else None),
source=source,
)
if entry.predicate:
if entry.expires:
raise AllowlistError(
f"{where}: a predicate entry must NOT set expires -- it clears "
"itself when the blocker lifts, and a date nobody can act on "
"only turns the gate red for no actionable reason"
)
if entry.transitive and (not entry.blocker or not all(entry.blocker)):
raise AllowlistError(
f"{where}: blocked_by must read transitive:<package>@<version>"
)
if entry.upstream and len((entry.upstream_repo or "").split("/")) != 2:
raise AllowlistError(f"{where}: blocked_by must read upstream:<owner>/<repo>")
return entry
if not entry.expires:
raise AllowlistError(f"{where}: a discretionary entry requires expires")
return entry
def check_expiry(entry: Exception_, today: date | None = None) -> None:
"""Raise if a discretionary entry is past due or reaches too far out."""
if entry.predicate or not entry.expires:
return
now = today or date.today()
when = _parse_date(entry.expires, f"{entry.source}: {entry.package}")
if when < now:
raise AllowlistError(
f"{entry.source}: {entry.ecosystem}:{entry.package} expired on {when}"
)
if (when - now).days > ALLOWLIST_MAX_DAYS:
raise AllowlistError(
f"{entry.source}: {entry.ecosystem}:{entry.package} expires {when}, "
f"more than {ALLOWLIST_MAX_DAYS} days out"
)
def load(root: Path) -> list[Exception_]:
"""Every exception in force for `root`: the shared set, then the repo's.
A repo entry for the same `ecosystem:package` replaces the shared one, so a
repo can always be stricter or state its own reason -- but nobody has to
copy a fleet-wide blocker into forty files to be able to commit.
"""
entries = {
f"{e.ecosystem}:{e.package}": e for e in _load_file(shared_path())
}
for entry in _load_file(path_for(root)):
entries[f"{entry.ecosystem}:{entry.package}"] = entry
return list(entries.values())
def _load_file(source: Path) -> list[Exception_]:
if not source.is_file():
return []
try:
data = yaml.safe_load(source.read_text(encoding="utf-8"))
except (OSError, yaml.YAMLError) as exc:
raise AllowlistError(f"{source}: unreadable ({exc})") from exc
if data is None:
return []
if not isinstance(data, dict) or "exceptions" not in data:
raise AllowlistError(f"{source}: expected a top-level 'exceptions:' list")
raw_entries = data.get("exceptions") or []
if not isinstance(raw_entries, list):
raise AllowlistError(f"{source}: 'exceptions' must be a list")
entries = [_entry(raw, source, i) for i, raw in enumerate(raw_entries)]
for entry in entries:
check_expiry(entry)
return entries