mirror of
https://github.com/kuhyx/utils.git
synced 2026-11-10 21:07:15 +01:00
firebase_auth_rest_test.dart 525 -> 153 + _google 158 + _tokens 206 + _uid 141
sync_revisions_test.dart 451 -> 223 + _peers 228 + _backends 158
+ _order 165 + _persistence 215
sync_settings_screen_test 457 -> 207 + _backup 143 + _google 145
mirror_store_test.dart 452 -> 209 + _reads 172 + _fallback 196 + _revisions 244
firebase_client_test.dart 374 -> 198 + _writes 227
firebase_config_test.dart 360 -> 138 + _client 148 + _client_google 164
device_auth_test.dart 307 -> 128 + _poll 201
github_client_test.dart 291 -> 143 + _writes 201
sync_test.dart 269 -> 160 + _skips 175
Two traps this hit, both invisible to a line count:
- _FakePersistence is declared *after* main(), so a naive cut at the last
brace dropped it; sync_revisions_persistence_test.dart failed to load
until it was carried across. Audited every other split file for trailing
top-level declarations — this was the only one.
- Copying the preamble into each sibling left helpers the sibling never
uses. `dart analyze` flagged 12; all removed rather than left as dead
code, and the analyzer is now clean.
crdt_sync_dart 280 passed, sync_settings_ui 29 passed, github_device_auth
analyze clean — all matching a clean HEAD worktree.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CFSGeWxHPY5rHUGrPqhcmG
199 lines
6.7 KiB
Dart
199 lines
6.7 KiB
Dart
import 'dart:convert';
|
|
|
|
import 'package:crdt_sync/crdt_sync.dart';
|
|
import 'package:http/http.dart' as http;
|
|
import 'package:http/testing.dart' as http_testing;
|
|
import 'package:test/test.dart';
|
|
|
|
const _databaseUrl =
|
|
'https://example-default-rtdb.europe-west1.firebasedatabase.app';
|
|
|
|
http.Response _json(int statusCode, Object? body) =>
|
|
http.Response(jsonEncode(body), statusCode);
|
|
|
|
/// A provider holding a long-lived token, so client tests never hit the auth
|
|
/// endpoints -- an HTTP call from the token provider would fail loudly here.
|
|
FirebaseTokenProvider _auth() => FirebaseTokenProvider(
|
|
apiKey: 'fake-api-key',
|
|
store: InMemoryCredentialStore(
|
|
FirebaseCredentials(
|
|
idToken: 'id-token',
|
|
refreshToken: 'refresh-token',
|
|
expiresAt: DateTime.utc(2099),
|
|
),
|
|
),
|
|
httpClient: http_testing.MockClient(
|
|
(_) async => throw StateError('auth must not be contacted'),
|
|
),
|
|
);
|
|
|
|
/// Records every request the client makes, so tests can assert on the URL
|
|
/// (which carries the key escaping and the shallow flag) as well as the
|
|
/// decoded result.
|
|
late List<http.Request> requests;
|
|
|
|
FirebaseRestClient _client(Object response, {FirebaseTokenProvider? auth}) {
|
|
requests = [];
|
|
final mock = http_testing.MockClient((request) async {
|
|
requests.add(request);
|
|
if (response is http.ClientException) throw response;
|
|
return response as http.Response;
|
|
});
|
|
return FirebaseRestClient(
|
|
databaseUrl: _databaseUrl,
|
|
auth: auth ?? _auth(),
|
|
httpClient: mock,
|
|
);
|
|
}
|
|
|
|
void main() {
|
|
group('key escaping', () {
|
|
test('escapes a .json filename into a legal RTDB key', () {
|
|
// `.` is illegal in an RTDB key, and the trailing `.json` in a REST URL
|
|
// is the format suffix -- so the name cannot be stored verbatim.
|
|
expect(encodeKey('log.json'), 'log~2Ejson');
|
|
});
|
|
|
|
test('leaves dot-free device ids untouched', () {
|
|
expect(encodeKey('pc'), 'pc');
|
|
expect(
|
|
encodeKey('32c28cf3-c0eb-423f-8bac-9bda9f158054'),
|
|
'32c28cf3-c0eb-423f-8bac-9bda9f158054',
|
|
);
|
|
});
|
|
|
|
test('escapes every character RTDB forbids, plus the escape char', () {
|
|
expect(encodeKey(r'a.b$c#d[e]f~g'), r'a~2Eb~24c~23d~5Be~5Df~7Eg');
|
|
});
|
|
|
|
test('round-trips, including a literal escape sequence in the name', () {
|
|
// A name that already looks like an escape must survive: `~` is itself
|
|
// escaped first, so `log~2Ejson` is not mistaken for `log.json`.
|
|
for (final name in [
|
|
'log.json',
|
|
'plain',
|
|
r'a.b$c#d[e]f~g',
|
|
'log~2Ejson',
|
|
'~',
|
|
'',
|
|
]) {
|
|
expect(decodeKey(encodeKey(name)), name, reason: name);
|
|
}
|
|
});
|
|
|
|
test('escapes each path segment but keeps the separators', () {
|
|
expect(
|
|
encodePath('todo-sync/notes/abc.json'),
|
|
'todo-sync/notes/abc~2Ejson',
|
|
);
|
|
});
|
|
|
|
test('drops empty segments so a root path yields an empty string', () {
|
|
expect(encodePath(''), '');
|
|
expect(encodePath('/a//b/'), 'a/b');
|
|
});
|
|
});
|
|
|
|
group('getFileText', () {
|
|
test('returns the stored text blob', () async {
|
|
final client = _client(_json(200, '{"a":1}'));
|
|
expect(await client.getFileText('ns/devices/pc/log.json'), '{"a":1}');
|
|
});
|
|
|
|
test('requests the escaped path with the auth token', () async {
|
|
final client = _client(_json(200, '{}'));
|
|
await client.getFileText('ns/devices/pc/log.json');
|
|
expect(requests.single.url.path, '/ns/devices/pc/log~2Ejson.json');
|
|
expect(requests.single.url.queryParameters['auth'], 'id-token');
|
|
});
|
|
|
|
test('returns null for a path nothing has been written to', () async {
|
|
// RTDB answers a missing path with literal `null` and a 200, so this is
|
|
// benign "no other device has synced yet", not an error.
|
|
final client = _client(_json(200, null));
|
|
expect(await client.getFileText('ns/devices/phone/log.json'), isNull);
|
|
});
|
|
|
|
test('throws when the value is not a text blob', () async {
|
|
final client = _client(_json(200, {'unexpected': 'object'}));
|
|
expect(
|
|
() => client.getFileText('ns/devices/pc/log.json'),
|
|
throwsA(isA<FirebaseSyncError>()),
|
|
);
|
|
});
|
|
|
|
test(
|
|
'raises DatabaseNotFoundError when the rules reject the uid',
|
|
() async {
|
|
final client = _client(_json(401, {'error': 'Permission denied'}));
|
|
expect(
|
|
() => client.getFileText('ns/devices/pc/log.json'),
|
|
throwsA(isA<DatabaseNotFoundError>()),
|
|
);
|
|
},
|
|
);
|
|
|
|
test('raises DatabaseNotFoundError on 403 too', () async {
|
|
final client = _client(_json(403, {'error': 'Permission denied'}));
|
|
expect(
|
|
() => client.getFileText('ns/devices/pc/log.json'),
|
|
throwsA(isA<DatabaseNotFoundError>()),
|
|
);
|
|
});
|
|
|
|
test('raises a plain FirebaseSyncError on any other non-2xx', () async {
|
|
// Spark quota exhaustion lands here. It must surface, never be
|
|
// swallowed into a null that reads as "nothing to sync".
|
|
final client = _client(_json(429, {'error': 'quota exceeded'}));
|
|
expect(
|
|
() => client.getFileText('ns/devices/pc/log.json'),
|
|
throwsA(
|
|
isA<FirebaseSyncError>().having(
|
|
(e) => e.message,
|
|
'message',
|
|
contains('429'),
|
|
),
|
|
),
|
|
);
|
|
});
|
|
|
|
test('turns a network failure into FirebaseSyncError', () async {
|
|
final client = _client(http.ClientException('offline'));
|
|
expect(
|
|
() => client.getFileText('ns/devices/pc/log.json'),
|
|
throwsA(isA<FirebaseSyncError>()),
|
|
);
|
|
});
|
|
});
|
|
|
|
group('listDirectory', () {
|
|
test('returns decoded keys and asks for a shallow read', () async {
|
|
final client = _client(_json(200, {'pc': true, 'phone': true}));
|
|
expect(await client.listDirectory('ns/devices'), ['pc', 'phone']);
|
|
// shallow=true is what keeps a listing costing bytes instead of the
|
|
// whole subtree -- the difference between ~40 MB/month and ~700 MB.
|
|
expect(requests.single.url.queryParameters['shallow'], 'true');
|
|
});
|
|
|
|
test('decodes escaped filenames back to what the caller wrote', () async {
|
|
// todo-app lists *filenames*, not device directories, so the `.json`
|
|
// must come back.
|
|
final client = _client(_json(200, {'abc~2Ejson': true}));
|
|
expect(await client.listDirectory('todo-sync/notes'), ['abc.json']);
|
|
});
|
|
|
|
test('returns empty for a prefix nothing has been written under', () async {
|
|
final client = _client(_json(200, null));
|
|
expect(await client.listDirectory('ns/devices'), isEmpty);
|
|
});
|
|
|
|
test('raises on a non-2xx response', () async {
|
|
final client = _client(_json(500, {'error': 'boom'}));
|
|
expect(
|
|
() => client.listDirectory('ns/devices'),
|
|
throwsA(isA<FirebaseSyncError>()),
|
|
);
|
|
});
|
|
});
|
|
}
|