mirror of
https://github.com/kuhyx/utils.git
synced 2026-11-10 22:47:14 +01:00
The three Python packages pinned ruff twice at different versions: requirements.txt at 0.16.7, .pre-commit-config.yaml at v0.15.2. Only the older one ever ran, so `select = ["ALL"]` was enforced two minor versions behind. Measured before aligning: v0.15.2 reports 0 findings, every 0.16.x reports CPY001 on each file -- 70 crdt-sync, 23 freedays, 71 gatelock, and no other rule. Resolved by adding the notice rather than ignoring the rule, so the gate keeps its teeth. Two gatelock modules sat at exactly the 250-line cap, so a one-line header tipped them to 251. Both are split along a real seam rather than shaved: _widget_fills.py colour arithmetic over LockConfig, no tkinter import _surfaces_focus.py selects among existing surfaces, never mutates them The focus split keeps _surfaces.py's documented containment (it stays the only module that creates, moves or destroys windows), and the static guard in test_recovery_invariants.py globs _surfaces*.py, so the new sibling is covered with no list to extend. widgets.py re-exports the fills helpers, which keeps gatelock.widgets the single public surface its tests import. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019kMvSMtsVMB3d2uoZ56pbp
197 lines
5.4 KiB
Python
197 lines
5.4 KiB
Python
# Copyright (c) 2026 Krzysztof Rudnicki
|
|
"""Tests for the pull/merge/push sync orchestration."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import json
|
|
from typing import TYPE_CHECKING
|
|
from unittest.mock import MagicMock
|
|
|
|
from crdt_sync import (
|
|
GitHubSyncClient,
|
|
LogCodec,
|
|
Record,
|
|
SyncTarget,
|
|
sync_log,
|
|
)
|
|
|
|
if TYPE_CHECKING:
|
|
from collections.abc import Callable
|
|
|
|
from crdt_sync import Hlc, Log
|
|
|
|
|
|
def _encode(log: Log) -> str:
|
|
return json.dumps(
|
|
{record_id: record.to_dict() for record_id, record in log.items()}
|
|
)
|
|
|
|
|
|
def _decode(text: str) -> Log:
|
|
return {
|
|
record_id: Record.from_dict(data)
|
|
for record_id, data in json.loads(text).items()
|
|
}
|
|
|
|
|
|
def _mock_client(
|
|
*,
|
|
devices: tuple[str, ...] = (),
|
|
files: dict[str, str] | None = None,
|
|
) -> MagicMock:
|
|
"""Build a mock ``GitHubSyncClient`` covering the methods sync_log calls."""
|
|
client = MagicMock(spec=GitHubSyncClient)
|
|
client.list_directory.return_value = list(devices)
|
|
resolved_files = files or {}
|
|
client.get_file_text.side_effect = resolved_files.get
|
|
return client
|
|
|
|
|
|
class TestSyncLog:
|
|
"""Sync log."""
|
|
|
|
def test_pushes_local_log_when_no_other_devices_have_synced(
|
|
self, make_hlc: Callable[..., Hlc]
|
|
) -> None:
|
|
"""Pushes local log when no other devices have synced."""
|
|
local_log = {"a": Record(id="a", fields={"text": ("hello", make_hlc(100))})}
|
|
client = _mock_client()
|
|
|
|
merged = sync_log(
|
|
SyncTarget(
|
|
client=client,
|
|
device_id="pc",
|
|
path_prefix="devices",
|
|
),
|
|
local_log,
|
|
LogCodec(
|
|
decode=_decode,
|
|
encode=_encode,
|
|
),
|
|
)
|
|
|
|
assert merged == local_log
|
|
client.put_file_text.assert_called_once()
|
|
assert client.put_file_text.call_args.args[0] == "devices/pc/log.json"
|
|
|
|
def test_skips_its_own_device_id_when_listing(self) -> None:
|
|
"""Skips its own device id when listing."""
|
|
client = _mock_client(
|
|
devices=("pc", "phone"), files={"devices/phone/log.json": "{}"}
|
|
)
|
|
|
|
sync_log(
|
|
SyncTarget(
|
|
client=client,
|
|
device_id="pc",
|
|
path_prefix="devices",
|
|
),
|
|
{},
|
|
LogCodec(
|
|
decode=_decode,
|
|
encode=_encode,
|
|
),
|
|
)
|
|
|
|
client.get_file_text.assert_called_once_with("devices/phone/log.json")
|
|
|
|
def test_skips_its_legacy_device_id_as_well_as_its_current_one(self) -> None:
|
|
"""A migrated device must not re-merge its own pre-migration log.
|
|
|
|
Without this the old path looks like a peer, so the device pulls
|
|
back everything it pushed under its former id every single tick.
|
|
"""
|
|
client = _mock_client(
|
|
devices=("pc", "new-uuid", "phone"),
|
|
files={"devices/phone/log.json": "{}"},
|
|
)
|
|
|
|
sync_log(
|
|
SyncTarget(
|
|
client=client,
|
|
device_id="new-uuid",
|
|
legacy_device_id="pc",
|
|
path_prefix="devices",
|
|
),
|
|
{},
|
|
LogCodec(
|
|
decode=_decode,
|
|
encode=_encode,
|
|
),
|
|
)
|
|
|
|
client.get_file_text.assert_called_once_with("devices/phone/log.json")
|
|
|
|
def test_pulls_the_old_path_when_no_legacy_id_is_declared(self) -> None:
|
|
"""Sanity check the previous test: absent the legacy id, it *is* pulled."""
|
|
client = _mock_client(
|
|
devices=("pc", "new-uuid"), files={"devices/pc/log.json": "{}"}
|
|
)
|
|
|
|
sync_log(
|
|
SyncTarget(
|
|
client=client,
|
|
device_id="new-uuid",
|
|
path_prefix="devices",
|
|
),
|
|
{},
|
|
LogCodec(
|
|
decode=_decode,
|
|
encode=_encode,
|
|
),
|
|
)
|
|
|
|
client.get_file_text.assert_called_once_with("devices/pc/log.json")
|
|
|
|
def test_merges_in_a_remote_devices_entries(
|
|
self, make_hlc: Callable[..., Hlc]
|
|
) -> None:
|
|
"""Merges in a remote devices entries."""
|
|
remote_log = {
|
|
"b": Record(id="b", fields={"text": ("from phone", make_hlc(100))})
|
|
}
|
|
client = _mock_client(
|
|
devices=("phone",),
|
|
files={"devices/phone/log.json": _encode(remote_log)},
|
|
)
|
|
|
|
merged = sync_log(
|
|
SyncTarget(
|
|
client=client,
|
|
device_id="pc",
|
|
path_prefix="devices",
|
|
),
|
|
{},
|
|
LogCodec(
|
|
decode=_decode,
|
|
encode=_encode,
|
|
),
|
|
)
|
|
|
|
assert merged == remote_log
|
|
|
|
def test_uses_a_custom_filename_and_commit_message(self) -> None:
|
|
"""Uses a custom filename and commit message."""
|
|
client = _mock_client()
|
|
|
|
sync_log(
|
|
SyncTarget(
|
|
client=client,
|
|
device_id="pc",
|
|
path_prefix="devices",
|
|
),
|
|
{},
|
|
LogCodec(
|
|
commit_message="custom message",
|
|
decode=_decode,
|
|
encode=_encode,
|
|
filename="notes.json",
|
|
),
|
|
)
|
|
|
|
client.put_file_text.assert_called_once_with(
|
|
"devices/pc/notes.json",
|
|
"{}",
|
|
message="custom message",
|
|
)
|