mirror of
https://github.com/kuhyx/utils.git
synced 2026-11-11 15:54:11 +01:00
Extracts the three-method remote surface GitHub was reached through into a `RemoteStore` interface, then implements it against Firebase Realtime Database over REST, so apps can move backend with a constructor change. Why REST and not the SDKs: official FlutterFire has no Linux desktop support, and `wake_alarm`'s PC side is a dependency-free systemd job. The RTDB REST endpoints are plain HTTPS and behave identically on Linux, Android and headless. Firebase is a transport, never the datastore -- each app keeps its local log as the source of truth, so offline-first survives. Why RTDB and not Firestore: on the Spark plan RTDB bills only storage and bandwidth with no per-operation quota, so a runaway loop cannot exhaust a daily budget and silently stop syncing mid-day. Two savings make the no-cost tier a guarantee rather than a hope. Measured against the GitHub-backed history this replaces: 4894 of 5542 commits (88.3%) were byte-identical no-ops, and every tick re-downloaded every peer's whole log. Both are now driven by one sha256 revision -- an unchanged log is not re-pushed, and an unchanged peer is not re-fetched. That turns egress from "ticks x log size" (~700 MB/month, and growing with the log) into "edits" (~40 MB/month against a 10 GiB cap). Revisions are one node per device, written only by its owner, rather than one shared map -- a whole-map write would erase every peer's entry, after which those peers would look permanently unchanged and never be fetched again. Per-device keys make that impossible rather than merely avoided. `.` is illegal in an RTDB key and the REST `.json` is a format suffix, so paths get a reversible `~XX` escape (`log.json` -> `log~2Ejson`). Lossy extension-stripping would break `todo`, whose listings return filenames. `MirrorStore` / `MirrorSyncClient` dual-writes during the cutover. Reads consult *both* backends: with primary-only reads a migrated device would never see an un-migrated peer's writes while still mirroring its own back -- silent one-directional convergence with no error raised. Writes are asymmetric on purpose: a primary failure fails the tick, a mirror failure is logged and survived. Auth is Firebase email/password over identitytoolkit REST, with mandatory refresh-token rotation. No service-account key anywhere: it would bypass the security rules and is trivially extractable from an APK. Verified live against a real database, not only mocks: sign-in and refresh, key escaping round-tripping byte-for-byte, an unchanged tick writing nothing, two devices converging, a revoked session throwing rather than returning null, and a log written by the Python client being read by the Dart one. No app is migrated by this commit; every app still runs on GitHub. Dart: 194 tests. Python: 203 tests at 100% branch coverage. No lint suppressions added.
375 lines
13 KiB
Dart
375 lines
13 KiB
Dart
import 'dart:convert';
|
|
|
|
import 'package:crdt_sync/crdt_sync.dart';
|
|
import 'package:http/http.dart' as http;
|
|
import 'package:http/testing.dart' as http_testing;
|
|
import 'package:test/test.dart';
|
|
|
|
const _databaseUrl = 'https://example-default-rtdb.europe-west1.firebasedatabase.app';
|
|
|
|
http.Response _json(int statusCode, Object? body) =>
|
|
http.Response(jsonEncode(body), statusCode);
|
|
|
|
/// A provider holding a long-lived token, so client tests never hit the auth
|
|
/// endpoints -- an HTTP call from the token provider would fail loudly here.
|
|
FirebaseTokenProvider _auth() => FirebaseTokenProvider(
|
|
apiKey: 'fake-api-key',
|
|
store: InMemoryCredentialStore(
|
|
FirebaseCredentials(
|
|
idToken: 'id-token',
|
|
refreshToken: 'refresh-token',
|
|
expiresAt: DateTime.utc(2099),
|
|
),
|
|
),
|
|
httpClient: http_testing.MockClient(
|
|
(_) async => throw StateError('auth must not be contacted'),
|
|
),
|
|
);
|
|
|
|
/// Records every request the client makes, so tests can assert on the URL
|
|
/// (which carries the key escaping and the shallow flag) as well as the
|
|
/// decoded result.
|
|
late List<http.Request> requests;
|
|
|
|
FirebaseRestClient _client(
|
|
Object response, {
|
|
FirebaseTokenProvider? auth,
|
|
}) {
|
|
requests = [];
|
|
final mock = http_testing.MockClient((request) async {
|
|
requests.add(request);
|
|
if (response is http.ClientException) throw response;
|
|
return response as http.Response;
|
|
});
|
|
return FirebaseRestClient(
|
|
databaseUrl: _databaseUrl,
|
|
auth: auth ?? _auth(),
|
|
httpClient: mock,
|
|
);
|
|
}
|
|
|
|
void main() {
|
|
group('key escaping', () {
|
|
test('escapes a .json filename into a legal RTDB key', () {
|
|
// `.` is illegal in an RTDB key, and the trailing `.json` in a REST URL
|
|
// is the format suffix -- so the name cannot be stored verbatim.
|
|
expect(encodeKey('log.json'), 'log~2Ejson');
|
|
});
|
|
|
|
test('leaves dot-free device ids untouched', () {
|
|
expect(encodeKey('pc'), 'pc');
|
|
expect(encodeKey('32c28cf3-c0eb-423f-8bac-9bda9f158054'),
|
|
'32c28cf3-c0eb-423f-8bac-9bda9f158054');
|
|
});
|
|
|
|
test('escapes every character RTDB forbids, plus the escape char', () {
|
|
expect(encodeKey(r'a.b$c#d[e]f~g'), r'a~2Eb~24c~23d~5Be~5Df~7Eg');
|
|
});
|
|
|
|
test('round-trips, including a literal escape sequence in the name', () {
|
|
// A name that already looks like an escape must survive: `~` is itself
|
|
// escaped first, so `log~2Ejson` is not mistaken for `log.json`.
|
|
for (final name in [
|
|
'log.json',
|
|
'plain',
|
|
r'a.b$c#d[e]f~g',
|
|
'log~2Ejson',
|
|
'~',
|
|
'',
|
|
]) {
|
|
expect(decodeKey(encodeKey(name)), name, reason: name);
|
|
}
|
|
});
|
|
|
|
test('escapes each path segment but keeps the separators', () {
|
|
expect(
|
|
encodePath('todo-sync/notes/abc.json'),
|
|
'todo-sync/notes/abc~2Ejson',
|
|
);
|
|
});
|
|
|
|
test('drops empty segments so a root path yields an empty string', () {
|
|
expect(encodePath(''), '');
|
|
expect(encodePath('/a//b/'), 'a/b');
|
|
});
|
|
});
|
|
|
|
group('getFileText', () {
|
|
test('returns the stored text blob', () async {
|
|
final client = _client(_json(200, '{"a":1}'));
|
|
expect(await client.getFileText('ns/devices/pc/log.json'), '{"a":1}');
|
|
});
|
|
|
|
test('requests the escaped path with the auth token', () async {
|
|
final client = _client(_json(200, '{}'));
|
|
await client.getFileText('ns/devices/pc/log.json');
|
|
expect(
|
|
requests.single.url.path,
|
|
'/ns/devices/pc/log~2Ejson.json',
|
|
);
|
|
expect(requests.single.url.queryParameters['auth'], 'id-token');
|
|
});
|
|
|
|
test('returns null for a path nothing has been written to', () async {
|
|
// RTDB answers a missing path with literal `null` and a 200, so this is
|
|
// benign "no other device has synced yet", not an error.
|
|
final client = _client(_json(200, null));
|
|
expect(await client.getFileText('ns/devices/phone/log.json'), isNull);
|
|
});
|
|
|
|
test('throws when the value is not a text blob', () async {
|
|
final client = _client(_json(200, {'unexpected': 'object'}));
|
|
expect(
|
|
() => client.getFileText('ns/devices/pc/log.json'),
|
|
throwsA(isA<FirebaseSyncError>()),
|
|
);
|
|
});
|
|
|
|
test('raises DatabaseNotFoundError when the rules reject the uid', () async {
|
|
final client = _client(_json(401, {'error': 'Permission denied'}));
|
|
expect(
|
|
() => client.getFileText('ns/devices/pc/log.json'),
|
|
throwsA(isA<DatabaseNotFoundError>()),
|
|
);
|
|
});
|
|
|
|
test('raises DatabaseNotFoundError on 403 too', () async {
|
|
final client = _client(_json(403, {'error': 'Permission denied'}));
|
|
expect(
|
|
() => client.getFileText('ns/devices/pc/log.json'),
|
|
throwsA(isA<DatabaseNotFoundError>()),
|
|
);
|
|
});
|
|
|
|
test('raises a plain FirebaseSyncError on any other non-2xx', () async {
|
|
// Spark quota exhaustion lands here. It must surface, never be
|
|
// swallowed into a null that reads as "nothing to sync".
|
|
final client = _client(_json(429, {'error': 'quota exceeded'}));
|
|
expect(
|
|
() => client.getFileText('ns/devices/pc/log.json'),
|
|
throwsA(
|
|
isA<FirebaseSyncError>().having(
|
|
(e) => e.message,
|
|
'message',
|
|
contains('429'),
|
|
),
|
|
),
|
|
);
|
|
});
|
|
|
|
test('turns a network failure into FirebaseSyncError', () async {
|
|
final client = _client(http.ClientException('offline'));
|
|
expect(
|
|
() => client.getFileText('ns/devices/pc/log.json'),
|
|
throwsA(isA<FirebaseSyncError>()),
|
|
);
|
|
});
|
|
});
|
|
|
|
group('listDirectory', () {
|
|
test('returns decoded keys and asks for a shallow read', () async {
|
|
final client = _client(_json(200, {'pc': true, 'phone': true}));
|
|
expect(await client.listDirectory('ns/devices'), ['pc', 'phone']);
|
|
// shallow=true is what keeps a listing costing bytes instead of the
|
|
// whole subtree -- the difference between ~40 MB/month and ~700 MB.
|
|
expect(requests.single.url.queryParameters['shallow'], 'true');
|
|
});
|
|
|
|
test('decodes escaped filenames back to what the caller wrote', () async {
|
|
// todo-app lists *filenames*, not device directories, so the `.json`
|
|
// must come back.
|
|
final client = _client(_json(200, {'abc~2Ejson': true}));
|
|
expect(await client.listDirectory('todo-sync/notes'), ['abc.json']);
|
|
});
|
|
|
|
test('returns empty for a prefix nothing has been written under', () async {
|
|
final client = _client(_json(200, null));
|
|
expect(await client.listDirectory('ns/devices'), isEmpty);
|
|
});
|
|
|
|
test('raises on a non-2xx response', () async {
|
|
final client = _client(_json(500, {'error': 'boom'}));
|
|
expect(
|
|
() => client.listDirectory('ns/devices'),
|
|
throwsA(isA<FirebaseSyncError>()),
|
|
);
|
|
});
|
|
});
|
|
|
|
group('putFileText', () {
|
|
test('writes the text as a JSON string leaf', () async {
|
|
final client = _client(_json(200, '{"a":1}'));
|
|
await client.putFileText(
|
|
'ns/devices/pc/log.json',
|
|
'{"a":1}',
|
|
message: 'ignored by rtdb',
|
|
);
|
|
expect(requests.single.method, 'PUT');
|
|
expect(requests.single.body, jsonEncode('{"a":1}'));
|
|
expect(requests.single.url.path, '/ns/devices/pc/log~2Ejson.json');
|
|
});
|
|
|
|
test('raises on a non-2xx response', () async {
|
|
final client = _client(_json(400, {'error': 'bad'}));
|
|
expect(
|
|
() => client.putFileText('ns/devices/pc/log.json', '{}', message: 'm'),
|
|
throwsA(isA<FirebaseSyncError>()),
|
|
);
|
|
});
|
|
|
|
test('turns a network failure into FirebaseSyncError', () async {
|
|
final client = _client(http.ClientException('offline'));
|
|
expect(
|
|
() => client.putFileText('ns/devices/pc/log.json', '{}', message: 'm'),
|
|
throwsA(isA<FirebaseSyncError>()),
|
|
);
|
|
});
|
|
});
|
|
|
|
group('patchValues', () {
|
|
test('PATCHes rather than PUTs, so sibling keys survive', () async {
|
|
// A PUT on the shared revs map would wipe every other device's entry,
|
|
// after which those devices would look permanently unchanged and never
|
|
// be fetched again.
|
|
final client = _client(_json(200, {'pc': 'abc'}));
|
|
await client.patchValues('ns/revs', {'pc': 'abc'});
|
|
expect(requests.single.method, 'PATCH');
|
|
expect(requests.single.body, jsonEncode({'pc': 'abc'}));
|
|
});
|
|
|
|
test('raises on a non-2xx response', () async {
|
|
final client = _client(_json(500, {'error': 'boom'}));
|
|
expect(
|
|
() => client.patchValues('ns/revs', {'pc': 'abc'}),
|
|
throwsA(isA<FirebaseSyncError>()),
|
|
);
|
|
});
|
|
|
|
test('turns a network failure into FirebaseSyncError', () async {
|
|
final client = _client(http.ClientException('offline'));
|
|
expect(
|
|
() => client.patchValues('ns/revs', {'pc': 'abc'}),
|
|
throwsA(isA<FirebaseSyncError>()),
|
|
);
|
|
});
|
|
});
|
|
|
|
group('getStringMap', () {
|
|
test('returns the map with keys decoded', () async {
|
|
final client = _client(_json(200, {'pc': 'sha-1', 'phone': 'sha-2'}));
|
|
expect(await client.getStringMap('ns/revs'), {
|
|
'pc': 'sha-1',
|
|
'phone': 'sha-2',
|
|
});
|
|
});
|
|
|
|
test('degrades to empty when absent', () async {
|
|
final client = _client(_json(200, null));
|
|
expect(await client.getStringMap('ns/revs'), isEmpty);
|
|
});
|
|
|
|
test('skips non-string entries rather than failing the sync', () async {
|
|
// The revs node is an optimisation; a corrupt one must degrade into
|
|
// "fetch everything", never into a failed tick.
|
|
final client = _client(_json(200, {'pc': 'sha-1', 'phone': 42}));
|
|
expect(await client.getStringMap('ns/revs'), {'pc': 'sha-1'});
|
|
});
|
|
|
|
test('raises on a non-2xx response', () async {
|
|
final client = _client(_json(500, {'error': 'boom'}));
|
|
expect(
|
|
() => client.getStringMap('ns/revs'),
|
|
throwsA(isA<FirebaseSyncError>()),
|
|
);
|
|
});
|
|
});
|
|
|
|
group('deleteFile', () {
|
|
test('sends a DELETE to the escaped path', () async {
|
|
final client = _client(_json(200, null));
|
|
await client.deleteFile('ns/devices/pc/log.json');
|
|
expect(requests.single.method, 'DELETE');
|
|
expect(requests.single.url.path, '/ns/devices/pc/log~2Ejson.json');
|
|
});
|
|
|
|
test('raises on a non-2xx response', () async {
|
|
final client = _client(_json(500, {'error': 'boom'}));
|
|
expect(
|
|
() => client.deleteFile('ns/devices/pc/log.json'),
|
|
throwsA(isA<FirebaseSyncError>()),
|
|
);
|
|
});
|
|
|
|
test('turns a network failure into FirebaseSyncError', () async {
|
|
final client = _client(http.ClientException('offline'));
|
|
expect(
|
|
() => client.deleteFile('ns/devices/pc/log.json'),
|
|
throwsA(isA<FirebaseSyncError>()),
|
|
);
|
|
});
|
|
});
|
|
|
|
group('canAccessRemote', () {
|
|
test('is true when the database root reads', () async {
|
|
expect(await _client(_json(200, {'ns': true})).canAccessRemote(), isTrue);
|
|
});
|
|
|
|
test('is false when the rules reject the token', () async {
|
|
expect(await _client(_json(401, {'error': 'denied'})).canAccessRemote(),
|
|
isFalse);
|
|
});
|
|
|
|
test('is false on a network error', () async {
|
|
expect(
|
|
await _client(http.ClientException('offline')).canAccessRemote(),
|
|
isFalse,
|
|
);
|
|
});
|
|
|
|
test('is false when no session is stored, rather than throwing', () async {
|
|
// "cannot get a token" is exactly "cannot access the remote", and a
|
|
// settings screen's Test-connection button must not blow up.
|
|
final client = _client(
|
|
_json(200, {}),
|
|
auth: FirebaseTokenProvider(
|
|
apiKey: 'k',
|
|
store: InMemoryCredentialStore(),
|
|
httpClient: http_testing.MockClient((_) async => _json(200, {})),
|
|
),
|
|
);
|
|
expect(await client.canAccessRemote(), isFalse);
|
|
});
|
|
});
|
|
|
|
group('RemoteStore contract', () {
|
|
test('FirebaseRestClient is a RemoteStore', () {
|
|
expect(_client(_json(200, null)), isA<RemoteStore>());
|
|
});
|
|
|
|
test('DatabaseNotFoundError is catchable as either error type', () {
|
|
final error = DatabaseNotFoundError('gone');
|
|
expect(error, isA<FirebaseSyncError>());
|
|
expect(error, isA<RemoteNotFoundError>());
|
|
expect(error, isA<RemoteSyncError>());
|
|
});
|
|
|
|
test('a trailing slash on the database URL is tolerated', () async {
|
|
final client = FirebaseRestClient(
|
|
databaseUrl: '$_databaseUrl/',
|
|
auth: _auth(),
|
|
httpClient: http_testing.MockClient((request) async {
|
|
requests.add(request);
|
|
return _json(200, 'ok');
|
|
}),
|
|
);
|
|
requests = [];
|
|
await client.getFileText('ns/x.json');
|
|
expect(requests.single.url.toString(), startsWith('$_databaseUrl/ns/'));
|
|
});
|
|
|
|
test('close releases the HTTP client', () {
|
|
expect(_client(_json(200, null)).close, returnsNormally);
|
|
});
|
|
});
|
|
}
|