utils/github_device_auth/lib/github_device_auth.dart
Krzysztof kuhy Rudnicki 795a8eae62 github_device_auth: extract the GitHub device flow from four apps
todo, home_inventory, diet-guard and wake-alarm each carried the OAuth
device-flow client and the modal that drives it -- ~650 lines, with two
pairs byte-for-byte identical (todo/home_inventory's clients, and
diet-guard/wake-alarm's dialogs).

Deliberately its own package rather than part of `sync_settings_ui`. That
package is Firebase-only by an explicit 2026-08-12 decision recorded as
"do not re-add a GitHub section without kuhy asking again", so folding a
GitHub flow into it would reverse a standing decision. The GitHub mirror
in these apps is legacy-but-load-bearing code that was explicitly not
authorised for deletion, so it gets its own home instead of being merged
into the Firebase path or dropped.

One behaviour change, made once here instead of four times: the dialog
catches `on Object`, not `on Exception`. An `Error` is not an `Exception`
in Dart, so `ArgumentError` -- notably from URI parsing -- escaped
`_poll()` and left the dialog spinning on "Waiting for authorization…"
forever with nothing shown. That is the same trap that silently killed the
Firebase sync tick across these apps in 2026-08. A test pins it with a
mock that throws an Error rather than an Exception, so it cannot regress
back to `on Exception` unnoticed.

20 tests, 100% line coverage, clean under very_good_analysis, with the
same CI gate the other Dart package holds. Consumers are migrated
separately so each app's own suite gates its own swap.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01U4Rj3s7K2qzrLNgJqqPhno
2026-08-15 15:57:19 +02:00

23 lines
1.0 KiB
Dart

/// GitHub OAuth **Device Flow** for kuhy's Flutter apps: the auth client and
/// the modal that drives it.
///
/// Four apps (todo, home_inventory, diet-guard, wake-alarm) each carried a
/// copy of both halves — the todo and home_inventory clients were
/// byte-identical, as were the diet-guard and wake-alarm dialogs. This
/// package is that shared copy.
///
/// Device flow needs only a public `client_id` (no client secret), which is
/// what makes it safe for a distributed app; the resulting access token is
/// then used exactly like a PAT.
///
/// Deliberately **not** part of `sync_settings_ui`: that package is
/// Firebase-only by an explicit 2026-08-12 decision, and folding a GitHub
/// flow into it would reverse that. The GitHub mirror in these apps is
/// legacy-but-load-bearing code, so it gets its own home rather than being
/// merged into the Firebase path or deleted.
library;
export 'src/device_auth.dart'
show DeviceAuthException, DeviceCodeResponse, GitHubDeviceAuth;
export 'src/device_code_dialog.dart' show DeviceCodeDialog;