mirror of
https://github.com/kuhyx/utils.git
synced 2026-11-10 22:47:14 +01:00
connectWithPassword() had no try/catch around firebaseFactory(), unlike
connectWithGoogle() right next to it. A thrown FirebaseAuthError (wrong
password, 400 from identitytoolkit) escaped uncaught out of the button's
async onPressed, so _busy/_status never updated and the screen sat on
"Signing in..." forever with no error shown -- reproduced live via the
browser console (confirmed "Uncaught Error" immediately after the 400,
not a hung Future).
Also reports real progress stages ("Saving account...", "Signing in to
Firebase...") instead of one static string, clears the bad password on a
confirmed rejection (previously only the null-client branch did, letting a
background sync tick keep retrying it), and surfaces the actual failure
reason in the status text instead of a generic "rejected" message.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XATAXuMzpYggWyTBPGyiSN
250 lines
7.9 KiB
Dart
250 lines
7.9 KiB
Dart
import 'dart:async';
|
|
|
|
import 'package:crdt_sync/crdt_sync.dart';
|
|
import 'package:flutter/material.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
import 'package:sync_settings_ui/sync_settings_ui.dart';
|
|
|
|
FirebaseRestClient _fakeClient() => FirebaseRestClient(
|
|
databaseUrl: 'https://example.firebasedatabase.app',
|
|
auth: FirebaseTokenProvider(
|
|
apiKey: 'test-key',
|
|
store: InMemoryCredentialStore(),
|
|
),
|
|
);
|
|
|
|
Widget _wrap(Widget child) => MaterialApp(home: child);
|
|
|
|
void main() {
|
|
// Every test expands the Google/password ExpansionTile, which pushes the
|
|
// form fields well past the default 800x600 test surface. A taller
|
|
// surface keeps every button reachable without scrolling -- scrolling a
|
|
// plain (non-.builder) ListView far enough still unmounts sliver children
|
|
// beyond its cache extent, which made an early version of these tests
|
|
// lose the Firebase section from the tree entirely.
|
|
setUp(() {
|
|
final binding = TestWidgetsFlutterBinding.ensureInitialized();
|
|
binding.platformDispatcher.views.first.physicalSize = const Size(
|
|
800,
|
|
2000,
|
|
);
|
|
binding.platformDispatcher.views.first.devicePixelRatio = 1.0;
|
|
addTearDown(binding.platformDispatcher.views.first.resetPhysicalSize);
|
|
addTearDown(binding.platformDispatcher.views.first.resetDevicePixelRatio);
|
|
});
|
|
|
|
group('Firebase section', () {
|
|
testWidgets('shows connected state with email and Disconnect', (
|
|
tester,
|
|
) async {
|
|
await tester.pumpWidget(
|
|
_wrap(
|
|
SyncSettingsScreen(
|
|
accountLoader: () async =>
|
|
const FirebaseAccount(email: 'a@b.com', password: 'x'),
|
|
accountSaver: (_) async {},
|
|
accountClearer: () async {},
|
|
sessionProbe: () async => true,
|
|
firebaseFactory: () async => null,
|
|
),
|
|
),
|
|
);
|
|
await tester.pumpAndSettle();
|
|
|
|
expect(find.text('a@b.com'), findsOneWidget);
|
|
expect(find.text('Disconnect'), findsOneWidget);
|
|
});
|
|
|
|
testWidgets('disconnect clears the account and shows status', (
|
|
tester,
|
|
) async {
|
|
var cleared = false;
|
|
await tester.pumpWidget(
|
|
_wrap(
|
|
SyncSettingsScreen(
|
|
accountLoader: () async =>
|
|
const FirebaseAccount(email: 'a@b.com', password: 'x'),
|
|
accountSaver: (_) async {},
|
|
accountClearer: () async => cleared = true,
|
|
sessionProbe: () async => true,
|
|
firebaseFactory: () async => null,
|
|
),
|
|
),
|
|
);
|
|
await tester.pumpAndSettle();
|
|
|
|
await tester.tap(find.text('Disconnect'));
|
|
await tester.pumpAndSettle();
|
|
|
|
expect(cleared, isTrue);
|
|
expect(find.text('Firebase disconnected.'), findsOneWidget);
|
|
expect(find.text('Connect Firebase'), findsOneWidget);
|
|
});
|
|
|
|
testWidgets('connect with password shows an error when empty', (
|
|
tester,
|
|
) async {
|
|
await tester.pumpWidget(
|
|
_wrap(
|
|
SyncSettingsScreen(
|
|
accountLoader: () async => null,
|
|
accountSaver: (_) async {},
|
|
accountClearer: () async {},
|
|
sessionProbe: () async => false,
|
|
firebaseFactory: () async => null,
|
|
),
|
|
),
|
|
);
|
|
await tester.pumpAndSettle();
|
|
|
|
// Google unavailable by default -> password form starts expanded.
|
|
await tester.tap(find.text('Connect Firebase'));
|
|
await tester.pumpAndSettle();
|
|
|
|
expect(
|
|
find.text('Enter the sync account email and password.'),
|
|
findsOneWidget,
|
|
);
|
|
});
|
|
|
|
testWidgets('connect with password succeeds and shows Connected', (
|
|
tester,
|
|
) async {
|
|
await tester.pumpWidget(
|
|
_wrap(
|
|
SyncSettingsScreen(
|
|
accountLoader: () async => null,
|
|
accountSaver: (_) async {},
|
|
accountClearer: () async {},
|
|
sessionProbe: () async => false,
|
|
firebaseFactory: () async => _fakeClient(),
|
|
),
|
|
),
|
|
);
|
|
await tester.pumpAndSettle();
|
|
|
|
await tester.enterText(
|
|
find.widgetWithText(TextField, 'Sync account email'),
|
|
'a@b.com',
|
|
);
|
|
await tester.enterText(
|
|
find.widgetWithText(TextField, 'Sync account password'),
|
|
'pw',
|
|
);
|
|
await tester.tap(find.text('Connect Firebase'));
|
|
await tester.pumpAndSettle();
|
|
|
|
expect(find.text('Connected to Firebase.'), findsOneWidget);
|
|
expect(find.text('a@b.com'), findsOneWidget);
|
|
});
|
|
|
|
testWidgets('connect with password reports rejection', (tester) async {
|
|
await tester.pumpWidget(
|
|
_wrap(
|
|
SyncSettingsScreen(
|
|
accountLoader: () async => null,
|
|
accountSaver: (_) async {},
|
|
accountClearer: () async {},
|
|
sessionProbe: () async => false,
|
|
firebaseFactory: () async => null,
|
|
),
|
|
),
|
|
);
|
|
await tester.pumpAndSettle();
|
|
|
|
await tester.enterText(
|
|
find.widgetWithText(TextField, 'Sync account email'),
|
|
'a@b.com',
|
|
);
|
|
await tester.enterText(
|
|
find.widgetWithText(TextField, 'Sync account password'),
|
|
'wrong',
|
|
);
|
|
await tester.tap(find.text('Connect Firebase'));
|
|
await tester.pumpAndSettle();
|
|
|
|
expect(find.text('Firebase rejected that account.'), findsOneWidget);
|
|
});
|
|
|
|
testWidgets(
|
|
'connect with password does not get stuck on "Signing in..." when '
|
|
'the factory throws -- reproduces the reported hang, where the '
|
|
'button stayed disabled and the status text never changed',
|
|
(tester) async {
|
|
await tester.pumpWidget(
|
|
_wrap(
|
|
SyncSettingsScreen(
|
|
accountLoader: () async => null,
|
|
accountSaver: (_) async {},
|
|
accountClearer: () async {},
|
|
sessionProbe: () async => false,
|
|
firebaseFactory: () async =>
|
|
throw FirebaseAuthError('bad creds'),
|
|
),
|
|
),
|
|
);
|
|
await tester.pumpAndSettle();
|
|
|
|
await tester.enterText(
|
|
find.widgetWithText(TextField, 'Sync account email'),
|
|
'a@b.com',
|
|
);
|
|
await tester.enterText(
|
|
find.widgetWithText(TextField, 'Sync account password'),
|
|
'wrong',
|
|
);
|
|
await tester.tap(find.text('Connect Firebase'));
|
|
await tester.pumpAndSettle();
|
|
|
|
expect(find.text('Signing in to Firebase…'), findsNothing);
|
|
expect(
|
|
find.text('Firebase rejected that account: bad creds'),
|
|
findsOneWidget,
|
|
);
|
|
final button = tester.widget<FilledButton>(
|
|
find.widgetWithText(FilledButton, 'Connect Firebase'),
|
|
);
|
|
expect(button.onPressed, isNotNull);
|
|
},
|
|
);
|
|
|
|
testWidgets(
|
|
'shows the Google button when googleAvailable, and connecting '
|
|
'succeeds',
|
|
(tester) async {
|
|
var sessionStored = false;
|
|
await tester.pumpWidget(
|
|
_wrap(
|
|
SyncSettingsScreen(
|
|
accountLoader: () async => null,
|
|
accountSaver: (_) async {},
|
|
accountClearer: () async {},
|
|
sessionProbe: () async => sessionStored,
|
|
firebaseFactory: () async => null,
|
|
googleFirebaseFactory: () async {
|
|
sessionStored = true;
|
|
return _fakeClient();
|
|
},
|
|
googleAvailable: true,
|
|
),
|
|
),
|
|
);
|
|
await tester.pumpAndSettle();
|
|
|
|
expect(find.text('Sign in with Google'), findsOneWidget);
|
|
// The password form is collapsed behind its ExpansionTile when
|
|
// Google is offered -- only the field labels prove that; the tile's
|
|
// own title text is present either way.
|
|
expect(
|
|
find.widgetWithText(TextField, 'Sync account email'),
|
|
findsNothing,
|
|
);
|
|
await tester.tap(find.text('Sign in with Google'));
|
|
await tester.pumpAndSettle();
|
|
|
|
expect(find.text('Connected to Firebase.'), findsOneWidget);
|
|
},
|
|
);
|
|
});
|
|
}
|