mirror of
https://github.com/kuhyx/utils.git
synced 2026-11-10 22:27:13 +01:00
Krzysztof kuhy Rudnicki
f902bbe0aa
MirrorSyncClient promised that reads consult both backends "so the cutover order is irrelevant", but every read called self.primary unguarded. A Firebase outage therefore produced no data at all and the GitHub mirror was never consulted -- the union read silently degraded to nothing, precisely when the fallback existed to help. This is not hypothetical: screen-locker's workout sync hit it on 2026-08-10, where a DNS failure reading the primary took down the whole locker rather than falling back. Reads (list_directory, get_file_text, get_string_map) now degrade to the mirror when the primary raises, and only fail when NEITHER backend can answer -- returning an empty result would be indistinguishable from "no data", which callers act on. Writes keep the old asymmetry on purpose: a write the primary did not accept has not happened, so it must still fail the tick. A mirror that cannot bulk-read (GitHub) contributes nothing but is not a failure, so it cannot by itself make a revision-map read raise. Both language ports agree on that. Same fix in the Dart port, which had all three read paths wrong too and runs on the phone. Two older tests asserted the buggy read-fail-closed behaviour and are renamed to describe what they actually exercise: the both-sides-failed case. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JS5V44jkHZiH1wC7BH5h5n |
||
|---|---|---|
| .. | ||
| device_test.dart | ||
| firebase_account_provisioning_test.dart | ||
| firebase_auth_rest_test.dart | ||
| firebase_client_test.dart | ||
| firebase_config_test.dart | ||
| firebase_settings_test.dart | ||
| github_client_test.dart | ||
| hlc_test.dart | ||
| log_test.dart | ||
| mirror_store_test.dart | ||
| record_test.dart | ||
| secure_credential_store_test.dart | ||
| store_test.dart | ||
| sync_revisions_test.dart | ||
| sync_test.dart | ||