mirror of
https://github.com/kuhyx/utils.git
synced 2026-11-10 22:27:13 +01:00
Krzysztof kuhy Rudnicki
6154dc09bf
The three Python packages pinned ruff twice at different versions: requirements.txt at 0.16.7, .pre-commit-config.yaml at v0.15.2. Only the older one ever ran, so `select = ["ALL"]` was enforced two minor versions behind. Measured before aligning: v0.15.2 reports 0 findings, every 0.16.x reports CPY001 on each file -- 70 crdt-sync, 23 freedays, 71 gatelock, and no other rule. Resolved by adding the notice rather than ignoring the rule, so the gate keeps its teeth. Two gatelock modules sat at exactly the 250-line cap, so a one-line header tipped them to 251. Both are split along a real seam rather than shaved: _widget_fills.py colour arithmetic over LockConfig, no tkinter import _surfaces_focus.py selects among existing surfaces, never mutates them The focus split keeps _surfaces.py's documented containment (it stays the only module that creates, moves or destroys windows), and the static guard in test_recovery_invariants.py globs _surfaces*.py, so the new sibling is covered with no list to extend. widgets.py re-exports the fills helpers, which keeps gatelock.widgets the single public surface its tests import. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019kMvSMtsVMB3d2uoZ56pbp
98 lines
3.0 KiB
Python
98 lines
3.0 KiB
Python
# Copyright (c) 2026 Krzysztof Rudnicki
|
|
"""Tests for local Log persistence (dump/load and atomic file read/write)."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import json
|
|
from typing import TYPE_CHECKING
|
|
|
|
import pytest
|
|
|
|
from crdt_sync import (
|
|
Record,
|
|
dump_log,
|
|
load_log,
|
|
read_log,
|
|
write_log,
|
|
)
|
|
|
|
if TYPE_CHECKING:
|
|
from collections.abc import Callable
|
|
from pathlib import Path
|
|
|
|
from crdt_sync import Hlc, Log
|
|
|
|
|
|
def _sample_log(make_hlc: Callable[..., Hlc]) -> Log:
|
|
return {
|
|
"a": Record(id="a", fields={"text": ("alpha", make_hlc(100))}),
|
|
"b": Record(id="b", fields={}, deleted=True, deleted_hlc=make_hlc(200)),
|
|
}
|
|
|
|
|
|
class TestDumpLoad:
|
|
"""Dump load."""
|
|
|
|
def test_round_trips_a_log(self, make_hlc: Callable[..., Hlc]) -> None:
|
|
"""Round trips a log."""
|
|
log = _sample_log(make_hlc)
|
|
assert load_log(dump_log(log)) == log
|
|
|
|
def test_load_raises_on_non_json(self) -> None:
|
|
# json.loads raises JSONDecodeError (a ValueError subclass).
|
|
"""Load raises on non JSON."""
|
|
with pytest.raises(json.JSONDecodeError):
|
|
load_log("{not json")
|
|
|
|
def test_load_raises_typeerror_on_wrong_shape(self) -> None:
|
|
# Valid JSON, but a list where an id->record map is expected.
|
|
"""Load raises typeerror on wrong shape."""
|
|
with pytest.raises(TypeError):
|
|
load_log("[]")
|
|
|
|
|
|
class TestReadWrite:
|
|
"""Read write."""
|
|
|
|
def test_write_then_read_round_trips(
|
|
self, tmp_path: Path, make_hlc: Callable[..., Hlc]
|
|
) -> None:
|
|
"""Write then read round trips."""
|
|
log = _sample_log(make_hlc)
|
|
path = tmp_path / "nested" / "log.json"
|
|
write_log(path, log)
|
|
assert read_log(path) == log
|
|
|
|
def test_write_creates_parent_directories(
|
|
self, tmp_path: Path, make_hlc: Callable[..., Hlc]
|
|
) -> None:
|
|
"""Write creates parent directories."""
|
|
path = tmp_path / "deep" / "nested" / "log.json"
|
|
write_log(path, _sample_log(make_hlc))
|
|
assert path.exists()
|
|
|
|
def test_write_overwrites_atomically(
|
|
self, tmp_path: Path, make_hlc: Callable[..., Hlc]
|
|
) -> None:
|
|
"""Write overwrites atomically."""
|
|
path = tmp_path / "log.json"
|
|
write_log(path, {"a": Record(id="a", fields={})})
|
|
write_log(path, _sample_log(make_hlc))
|
|
assert set(read_log(path)) == {"a", "b"}
|
|
|
|
def test_read_of_missing_file_is_empty(self, tmp_path: Path) -> None:
|
|
"""Read of missing file is empty."""
|
|
assert read_log(tmp_path / "nope.json") == {}
|
|
|
|
def test_read_of_corrupt_file_is_empty(self, tmp_path: Path) -> None:
|
|
"""Read of corrupt file is empty."""
|
|
path = tmp_path / "log.json"
|
|
path.write_text("{not json", encoding="utf-8")
|
|
assert read_log(path) == {}
|
|
|
|
def test_read_of_wrong_shape_file_is_empty(self, tmp_path: Path) -> None:
|
|
"""Read of wrong shape file is empty."""
|
|
path = tmp_path / "log.json"
|
|
path.write_text("[]", encoding="utf-8")
|
|
assert read_log(path) == {}
|