mirror of
https://github.com/kuhyx/wake-alarm.git
synced 2026-11-11 16:33:48 +01:00
Krzysztof kuhy Rudnicki
9e0cd123ff
Item 14: the fan ramp is gone entirely. It caused anxiety without helping anyone wake up. Deletes _max_fans/_restore_fans/_find_fan_hwmon, the _AlarmHardware.fan_state field, both call sites, and their tests. wake-alarm-fans.sh and its NOPASSWD sudoers entry come out in the install.sh pass -- dropping a passwordless root helper is a bonus. _alarm.py was 478 lines and the 250-line gate fires on any commit that stages it, so this carries the split it has owed for a while. New modules, each a real seam rather than an arbitrary cut: _gating should-it-run-today + CLI (no time gate; that is _trigger's) _beep_loop the sounding thread, now driving _escalation's planner _alarm_timers self-rescheduling challenge refresh / skip window (mixin) _alarm_state the progress + hardware dataclasses _rounds challenge presentation, re-exporting the view helpers _countdown skip-window arithmetic and demo/production intervals _dismiss_view the post-dismissal banner _screen_flash the ~1.3 Hz attention flash (kept under the 3 Hz threshold) _lock_setup gatelock config + arbiter claim _startup wake display, brightness, plug _tone tone synthesis and cache (out of _audio) _brightness xrandr brightness (was in _audio, never belonged there) main() deliberately stays in _alarm.py: morning_routine/_orchestrator.py:39 hardcodes "wake_alarm._alarm", and moving it is the exact mistake that caused a month-long silent production failure once already. Verified after the split that the module still resolves and accepts --production. Also fixes the plug pre-roll found while researching speakers: main() fired turn_on_plug() and the first beep in the same instant, so an amplifier's soft-start relay swallowed the opening of the alarm. PLUG_PREROLL_SECONDS=4 now sits between them. Two bugs found by running the code rather than by lint: - ruff stripped `struct` from the extracted _tone.py because the import landed before its first usage; only executing it caught the NameError. - test fixtures patched _play_on_all_sinks/_set_max_brightness at wake_alarm._alarm, which silently stopped intercepting once those moved. 404 tests, 100% branch coverage, no new noqa/type-ignore suppressions. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EckWmyfetYq3Mi8MAnUudh
41 lines
1.2 KiB
Python
41 lines
1.2 KiB
Python
"""Tests for the PC-speaker fallback beep."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
from wake_alarm._audio import (
|
|
_beep_pcspkr,
|
|
)
|
|
|
|
|
|
class TestBeepPcspkr:
|
|
"""Tests for _beep_pcspkr (evdev PC speaker)."""
|
|
|
|
def test_writes_tone_then_zero_to_device(self) -> None:
|
|
"""Successful path writes start-frequency then stop event."""
|
|
|
|
mock_dev = MagicMock()
|
|
mock_open_ctx = MagicMock()
|
|
mock_open_ctx.__enter__.return_value = mock_dev
|
|
mock_open_ctx.__exit__.return_value = False
|
|
with (
|
|
patch(
|
|
"wake_alarm._tone.Path.open",
|
|
return_value=mock_open_ctx,
|
|
),
|
|
patch("wake_alarm._audio.time.sleep"),
|
|
):
|
|
_beep_pcspkr(1000, 0.05)
|
|
# First write carries the frequency, second write carries 0 (stop).
|
|
assert mock_dev.write.call_count == 2
|
|
|
|
def test_oserror_is_swallowed(self) -> None:
|
|
"""OSError opening the device must not raise."""
|
|
|
|
with patch(
|
|
"wake_alarm._tone.Path.open",
|
|
side_effect=OSError("no device"),
|
|
):
|
|
_beep_pcspkr(1000, 0.05) # must not raise
|