mirror of
https://github.com/kuhyx/wake-alarm.git
synced 2026-11-11 13:47:31 +01:00
Krzysztof kuhy Rudnicki
9e0cd123ff
Item 14: the fan ramp is gone entirely. It caused anxiety without helping anyone wake up. Deletes _max_fans/_restore_fans/_find_fan_hwmon, the _AlarmHardware.fan_state field, both call sites, and their tests. wake-alarm-fans.sh and its NOPASSWD sudoers entry come out in the install.sh pass -- dropping a passwordless root helper is a bonus. _alarm.py was 478 lines and the 250-line gate fires on any commit that stages it, so this carries the split it has owed for a while. New modules, each a real seam rather than an arbitrary cut: _gating should-it-run-today + CLI (no time gate; that is _trigger's) _beep_loop the sounding thread, now driving _escalation's planner _alarm_timers self-rescheduling challenge refresh / skip window (mixin) _alarm_state the progress + hardware dataclasses _rounds challenge presentation, re-exporting the view helpers _countdown skip-window arithmetic and demo/production intervals _dismiss_view the post-dismissal banner _screen_flash the ~1.3 Hz attention flash (kept under the 3 Hz threshold) _lock_setup gatelock config + arbiter claim _startup wake display, brightness, plug _tone tone synthesis and cache (out of _audio) _brightness xrandr brightness (was in _audio, never belonged there) main() deliberately stays in _alarm.py: morning_routine/_orchestrator.py:39 hardcodes "wake_alarm._alarm", and moving it is the exact mistake that caused a month-long silent production failure once already. Verified after the split that the module still resolves and accepts --production. Also fixes the plug pre-roll found while researching speakers: main() fired turn_on_plug() and the first beep in the same instant, so an amplifier's soft-start relay swallowed the opening of the alarm. PLUG_PREROLL_SECONDS=4 now sits between them. Two bugs found by running the code rather than by lint: - ruff stripped `struct` from the extracted _tone.py because the import landed before its first usage; only executing it caught the NameError. - test fixtures patched _play_on_all_sinks/_set_max_brightness at wake_alarm._alarm, which silently stopped intercepting once those moved. 404 tests, 100% branch coverage, no new noqa/type-ignore suppressions. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EckWmyfetYq3Mi8MAnUudh
54 lines
1.6 KiB
Python
54 lines
1.6 KiB
Python
"""Tests for alarm tone synthesis and caching."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from typing import TYPE_CHECKING
|
|
from unittest.mock import patch
|
|
|
|
if TYPE_CHECKING:
|
|
import pathlib
|
|
|
|
from wake_alarm._tone import _ensure_tone_wav
|
|
|
|
|
|
class TestEnsureToneWav:
|
|
"""Tests for _ensure_tone_wav (sine WAV generator + cache)."""
|
|
|
|
def test_generates_and_caches(self, tmp_path: pathlib.Path) -> None:
|
|
"""First call generates the WAV; second call returns the cached path."""
|
|
from wake_alarm import _tone as tone_mod
|
|
|
|
tone_mod._TONE_CACHE.clear()
|
|
with patch(
|
|
"wake_alarm._tone.tempfile.gettempdir",
|
|
return_value=str(tmp_path),
|
|
):
|
|
path1 = _ensure_tone_wav(440)
|
|
assert path1.exists()
|
|
size = path1.stat().st_size
|
|
assert size > 0
|
|
# Second call must hit the cache (no regeneration).
|
|
with patch("wake_alarm._tone.wave.open") as mock_open:
|
|
path2 = _ensure_tone_wav(440)
|
|
mock_open.assert_not_called()
|
|
assert path2 == path1
|
|
tone_mod._TONE_CACHE.clear()
|
|
|
|
def test_regenerates_when_cached_file_missing(
|
|
self,
|
|
tmp_path: pathlib.Path,
|
|
) -> None:
|
|
"""If the cached file was deleted, regenerate it."""
|
|
from wake_alarm._tone import _TONE_CACHE
|
|
|
|
_TONE_CACHE.clear()
|
|
with patch(
|
|
"wake_alarm._tone.tempfile.gettempdir",
|
|
return_value=str(tmp_path),
|
|
):
|
|
path1 = _ensure_tone_wav(880)
|
|
path1.unlink()
|
|
path2 = _ensure_tone_wav(880)
|
|
assert path2.exists()
|
|
_TONE_CACHE.clear()
|