mirror of
https://github.com/kuhyx/wake-alarm.git
synced 2026-11-11 17:13:49 +01:00
Krzysztof kuhy Rudnicki
9e0cd123ff
Item 14: the fan ramp is gone entirely. It caused anxiety without helping anyone wake up. Deletes _max_fans/_restore_fans/_find_fan_hwmon, the _AlarmHardware.fan_state field, both call sites, and their tests. wake-alarm-fans.sh and its NOPASSWD sudoers entry come out in the install.sh pass -- dropping a passwordless root helper is a bonus. _alarm.py was 478 lines and the 250-line gate fires on any commit that stages it, so this carries the split it has owed for a while. New modules, each a real seam rather than an arbitrary cut: _gating should-it-run-today + CLI (no time gate; that is _trigger's) _beep_loop the sounding thread, now driving _escalation's planner _alarm_timers self-rescheduling challenge refresh / skip window (mixin) _alarm_state the progress + hardware dataclasses _rounds challenge presentation, re-exporting the view helpers _countdown skip-window arithmetic and demo/production intervals _dismiss_view the post-dismissal banner _screen_flash the ~1.3 Hz attention flash (kept under the 3 Hz threshold) _lock_setup gatelock config + arbiter claim _startup wake display, brightness, plug _tone tone synthesis and cache (out of _audio) _brightness xrandr brightness (was in _audio, never belonged there) main() deliberately stays in _alarm.py: morning_routine/_orchestrator.py:39 hardcodes "wake_alarm._alarm", and moving it is the exact mistake that caused a month-long silent production failure once already. Verified after the split that the module still resolves and accepts --production. Also fixes the plug pre-roll found while researching speakers: main() fired turn_on_plug() and the first beep in the same instant, so an amplifier's soft-start relay swallowed the opening of the alarm. PLUG_PREROLL_SECONDS=4 now sits between them. Two bugs found by running the code rather than by lint: - ruff stripped `struct` from the extracted _tone.py because the import landed before its first usage; only executing it caught the NameError. - test fixtures patched _play_on_all_sinks/_set_max_brightness at wake_alarm._alarm, which silently stopped intercepting once those moved. 404 tests, 100% branch coverage, no new noqa/type-ignore suppressions. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EckWmyfetYq3Mi8MAnUudh
82 lines
2.5 KiB
Python
82 lines
2.5 KiB
Python
"""Decide whether the alarm should run, and parse its CLI.
|
|
|
|
Split out of ``_alarm.py`` so the gate is testable without constructing a
|
|
window, and to keep that module under the 250-line cap.
|
|
|
|
Note ``_should_run_alarm`` has deliberately **no time gate**: the trigger owns
|
|
"is it time?", and this owns "should it run at all today?". That separation is
|
|
why ``wake-alarm.service`` must never get an ``[Install]`` section -- with no
|
|
time gate, a ``WantedBy=`` would fire the alarm at login.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import argparse
|
|
from datetime import datetime, timezone
|
|
import logging
|
|
|
|
from wake_alarm._constants import ALARM_DAYS
|
|
from wake_alarm._state import was_alarm_dismissed_today, was_workout_logged_today
|
|
|
|
_logger = logging.getLogger(__name__)
|
|
|
|
|
|
def is_alarm_day(*, now: datetime | None = None) -> bool:
|
|
"""Report whether today is configured as an alarm day.
|
|
|
|
Args:
|
|
now: Instant to test; defaults to the current local time.
|
|
|
|
Returns:
|
|
True when today's weekday is in ``ALARM_DAYS``.
|
|
"""
|
|
moment = now if now is not None else datetime.now(tz=timezone.utc).astimezone()
|
|
return moment.weekday() in ALARM_DAYS
|
|
|
|
|
|
def should_run_alarm() -> bool:
|
|
"""Decide whether the alarm should sound at all today.
|
|
|
|
Returns:
|
|
True unless today is not an alarm day, the alarm was already
|
|
dismissed, or the workout was already logged.
|
|
"""
|
|
if not is_alarm_day():
|
|
_logger.info("Not an alarm day. Exiting.")
|
|
return False
|
|
if was_alarm_dismissed_today():
|
|
_logger.info("Alarm already dismissed today. Exiting.")
|
|
return False
|
|
if was_workout_logged_today():
|
|
_logger.info("Workout already logged today. Skipping alarm.")
|
|
return False
|
|
return True
|
|
|
|
|
|
def parse_args(argv: list[str]) -> argparse.Namespace:
|
|
"""Parse CLI arguments for the alarm daemon.
|
|
|
|
Args:
|
|
argv: Argument list without the program name.
|
|
|
|
Returns:
|
|
The parsed namespace.
|
|
"""
|
|
parser = argparse.ArgumentParser(description="Wake alarm daemon.")
|
|
parser.add_argument(
|
|
"--production",
|
|
action="store_true",
|
|
help="Production mode (default; kept for systemd compatibility).",
|
|
)
|
|
parser.add_argument(
|
|
"--demo",
|
|
action="store_true",
|
|
help="Run with a smaller window and shorter timers.",
|
|
)
|
|
parser.add_argument(
|
|
"--trigger-now",
|
|
action="store_true",
|
|
help="Bypass the day/dismiss gate and fire the alarm immediately.",
|
|
)
|
|
return parser.parse_args(argv)
|