mirror of
https://github.com/kuhyx/wake-alarm.git
synced 2026-11-10 18:07:05 +01:00
Krzysztof kuhy Rudnicki
e67cef0c54
The PC no longer wakes anyone -- the phone does. This deletes the alarm window, the audio escalation, the sink/reactivation machinery, the power-key inhibitor, the escape hatch, the curtains, the smart plug, the brightness and DDC/CI control, the hibernate path (shutdown wrapper + rtcwake + sleep hook) and the challenge set: 30 modules, 34 test files, ~5k lines. What stays is the part that still earns its keep: the per-minute trigger reads the alarm the phone published and starts morning-routine.service, so the workout lock still runs at the right time. THE ONE LOAD-BEARING BEHAVIOUR CHANGE. Deleting _alarm.py orphaned the only writer of wake_state.json, and _trigger gated on it via was_alarm_dismissed_today(). With that gone -- and was_workout_logged_today() already permanently False, since WORKOUT_LOG_FILE does not exist -- both gates would have been dead and the routine restarted on every tick for the rest of the 60-minute catch-up window. The unit is Type=simple, so a start while it runs is a no-op, but the moment the workout lock finished the next tick would relaunch it on top of the user. So _trigger now writes its own once-per-day latch (save_trigger_fired / was_trigger_fired_today) and gates on that. Collapsing the catch-up window instead was rejected: that window is the entire reason a suspended or just-booted machine still fires. It also replaces the deleted sleep hook, via Persistent=true. _trigger also imported should_refire from _alarm_session, which was on the delete list. Since start_session lived only in _alarm.py, no session record is ever written again and the branch was unreachable, not merely unused. WAKE_STATE_FILE is now redirected in tests/conftest.py rather than per-file. The trigger tests never redirected it, because until this commit nothing on that path wrote anything -- and a per-file redirect is exactly the kind that gets forgotten when a new writer appears, with a silent failure: a green suite that quietly stamped the live state file. Verified by mtime that it did not. Cross-repo, same change: morning_routine._orchestrator loses its alarm leg and its --with-alarm flag. Leaving an orchestrator pointing at a deleted module caused a month-long silent failure once already. uninstall.sh is new, and matters more than it looks. /usr/local/bin/shutdown is root-owned and shadows /usr/bin/shutdown; deleting this repo would leave it in place, and with the alarm cache gone it falls through to rtcwake + hibernate -- so "shutdown now" would silently stop being a poweroff, every day, forever. /etc/sudoers.d/wake-alarm is deliberately NOT removed: screen-locker's own _wake_alarm.py still needs passwordless rtcwake. 159 tests pass at 100% branch coverage; all 26 pre-commit hooks green. Verified by running it: _sync --show and _trigger --dry-run both resolve. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PcdngP688mW6rJye3LRkSN
80 lines
2.1 KiB
Python
80 lines
2.1 KiB
Python
"""Tests for _state.py's read-side queries — the workout skip, and the two
|
|
'already done today' gates the trigger consults.
|
|
|
|
Split out of test_state.py for the 250-line gate; that file keeps the
|
|
UTC day key and the save/load round-trip."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import json
|
|
from typing import TYPE_CHECKING
|
|
from unittest.mock import patch
|
|
|
|
import pytest
|
|
|
|
from wake_alarm._state import (
|
|
_today_str,
|
|
was_trigger_fired_today,
|
|
)
|
|
|
|
if TYPE_CHECKING:
|
|
from pathlib import Path
|
|
|
|
|
|
@pytest.fixture
|
|
def wake_state_file(tmp_path: Path) -> Path:
|
|
"""Provide a temporary wake state file path."""
|
|
return tmp_path / "wake_state.json"
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _patch_wake_state_file(wake_state_file: Path) -> None:
|
|
"""Redirect WAKE_STATE_FILE to tmp_path for all tests."""
|
|
with patch(
|
|
"wake_alarm._state.WAKE_STATE_FILE",
|
|
wake_state_file,
|
|
):
|
|
yield
|
|
|
|
|
|
class TestWasTriggerFiredToday:
|
|
"""Tests for the trigger's once-per-day latch."""
|
|
|
|
def test_returns_false_when_no_state(self) -> None:
|
|
"""Return False when no state file exists."""
|
|
assert was_trigger_fired_today() is False
|
|
|
|
def test_returns_true_once_fired(
|
|
self,
|
|
wake_state_file: Path,
|
|
) -> None:
|
|
"""Return True when the routine already started today."""
|
|
state = {
|
|
"date": _today_str(),
|
|
"fired_at": "07:04",
|
|
"hmac": "sig",
|
|
}
|
|
wake_state_file.write_text(json.dumps(state))
|
|
with patch(
|
|
"wake_alarm._state.verify_entry_hmac",
|
|
return_value=True,
|
|
):
|
|
assert was_trigger_fired_today() is True
|
|
|
|
def test_returns_false_before_firing(
|
|
self,
|
|
wake_state_file: Path,
|
|
) -> None:
|
|
"""Return False when it has not started yet."""
|
|
state = {
|
|
"date": _today_str(),
|
|
"fired_at": None,
|
|
"hmac": "sig",
|
|
}
|
|
wake_state_file.write_text(json.dumps(state))
|
|
with patch(
|
|
"wake_alarm._state.verify_entry_hmac",
|
|
return_value=True,
|
|
):
|
|
assert was_trigger_fired_today() is False
|