mirror of
https://github.com/kuhyx/wake-alarm.git
synced 2026-11-10 18:07:05 +01:00
Krzysztof kuhy Rudnicki
e67cef0c54
The PC no longer wakes anyone -- the phone does. This deletes the alarm window, the audio escalation, the sink/reactivation machinery, the power-key inhibitor, the escape hatch, the curtains, the smart plug, the brightness and DDC/CI control, the hibernate path (shutdown wrapper + rtcwake + sleep hook) and the challenge set: 30 modules, 34 test files, ~5k lines. What stays is the part that still earns its keep: the per-minute trigger reads the alarm the phone published and starts morning-routine.service, so the workout lock still runs at the right time. THE ONE LOAD-BEARING BEHAVIOUR CHANGE. Deleting _alarm.py orphaned the only writer of wake_state.json, and _trigger gated on it via was_alarm_dismissed_today(). With that gone -- and was_workout_logged_today() already permanently False, since WORKOUT_LOG_FILE does not exist -- both gates would have been dead and the routine restarted on every tick for the rest of the 60-minute catch-up window. The unit is Type=simple, so a start while it runs is a no-op, but the moment the workout lock finished the next tick would relaunch it on top of the user. So _trigger now writes its own once-per-day latch (save_trigger_fired / was_trigger_fired_today) and gates on that. Collapsing the catch-up window instead was rejected: that window is the entire reason a suspended or just-booted machine still fires. It also replaces the deleted sleep hook, via Persistent=true. _trigger also imported should_refire from _alarm_session, which was on the delete list. Since start_session lived only in _alarm.py, no session record is ever written again and the branch was unreachable, not merely unused. WAKE_STATE_FILE is now redirected in tests/conftest.py rather than per-file. The trigger tests never redirected it, because until this commit nothing on that path wrote anything -- and a per-file redirect is exactly the kind that gets forgotten when a new writer appears, with a silent failure: a green suite that quietly stamped the live state file. Verified by mtime that it did not. Cross-repo, same change: morning_routine._orchestrator loses its alarm leg and its --with-alarm flag. Leaving an orchestrator pointing at a deleted module caused a month-long silent failure once already. uninstall.sh is new, and matters more than it looks. /usr/local/bin/shutdown is root-owned and shadows /usr/bin/shutdown; deleting this repo would leave it in place, and with the alarm cache gone it falls through to rtcwake + hibernate -- so "shutdown now" would silently stop being a poweroff, every day, forever. /etc/sudoers.d/wake-alarm is deliberately NOT removed: screen-locker's own _wake_alarm.py still needs passwordless rtcwake. 159 tests pass at 100% branch coverage; all 26 pre-commit hooks green. Verified by running it: _sync --show and _trigger --dry-run both resolve. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PcdngP688mW6rJye3LRkSN
65 lines
2.4 KiB
Python
65 lines
2.4 KiB
Python
"""Tests for the PC-side clamp — a synced alarm may never land later."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from datetime import datetime
|
|
from unittest.mock import patch
|
|
|
|
import pytest
|
|
|
|
from wake_alarm._constants import FALLBACK_ALARM_HOUR
|
|
from wake_alarm._sync import Alarm
|
|
from wake_alarm._trigger import (
|
|
_clamp_to_baseline,
|
|
)
|
|
|
|
|
|
def _at(hour: int, minute: int) -> datetime:
|
|
"""Return a Sunday at the given local wall-clock time, timezone-aware.
|
|
|
|
Built the same way production does — naive wall clock, then astimezone()
|
|
to attach the system offset — so the tests exercise the real comparison
|
|
semantics rather than a hand-picked fixed offset.
|
|
"""
|
|
return datetime(2026, 7, 19, hour, minute, tzinfo=None).astimezone()
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _ungated() -> None:
|
|
"""Open every gate unless a test closes one.
|
|
|
|
The once-per-day latch is stubbed: unstubbed it reads the *real*
|
|
session record on the host, so a test run started while an alarm was
|
|
actually ringing would silently invert half these assertions.
|
|
"""
|
|
with (
|
|
patch("wake_alarm._trigger.was_trigger_fired_today", return_value=False),
|
|
):
|
|
yield
|
|
|
|
|
|
class TestClampToBaseline:
|
|
"""The PC-side watchdog: a synced alarm may never land later than 08:00."""
|
|
|
|
def test_an_earlier_alarm_passes_through_untouched(self) -> None:
|
|
"""The phone ratchets earlier, so earlier values are legitimate."""
|
|
alarm = Alarm(6, 30, "remote")
|
|
assert _clamp_to_baseline(alarm) == alarm
|
|
|
|
def test_the_baseline_itself_passes_through(self) -> None:
|
|
"""Equal to the baseline is not later than it."""
|
|
alarm = Alarm(FALLBACK_ALARM_HOUR, 0, "remote")
|
|
assert _clamp_to_baseline(alarm) == alarm
|
|
|
|
def test_a_later_alarm_is_clamped_to_the_baseline(self) -> None:
|
|
"""The one direction the design forbids must not be reachable."""
|
|
clamped = _clamp_to_baseline(Alarm(13, 0, "remote"))
|
|
assert (clamped.hour, clamped.minute) == (FALLBACK_ALARM_HOUR, 0)
|
|
assert clamped.source == "clamped-remote"
|
|
|
|
def test_a_later_minute_within_the_baseline_hour_is_clamped(self) -> None:
|
|
"""08:30 is later than 08:00, so the minute matters too."""
|
|
clamped = _clamp_to_baseline(Alarm(FALLBACK_ALARM_HOUR, 30, "cache"))
|
|
assert (clamped.hour, clamped.minute) == (FALLBACK_ALARM_HOUR, 0)
|
|
assert clamped.source == "clamped-cache"
|