mirror of
https://github.com/kuhyx/wake-alarm.git
synced 2026-11-10 19:27:02 +01:00
Item 14: the fan ramp is gone entirely. It caused anxiety without helping anyone wake up. Deletes _max_fans/_restore_fans/_find_fan_hwmon, the _AlarmHardware.fan_state field, both call sites, and their tests. wake-alarm-fans.sh and its NOPASSWD sudoers entry come out in the install.sh pass -- dropping a passwordless root helper is a bonus. _alarm.py was 478 lines and the 250-line gate fires on any commit that stages it, so this carries the split it has owed for a while. New modules, each a real seam rather than an arbitrary cut: _gating should-it-run-today + CLI (no time gate; that is _trigger's) _beep_loop the sounding thread, now driving _escalation's planner _alarm_timers self-rescheduling challenge refresh / skip window (mixin) _alarm_state the progress + hardware dataclasses _rounds challenge presentation, re-exporting the view helpers _countdown skip-window arithmetic and demo/production intervals _dismiss_view the post-dismissal banner _screen_flash the ~1.3 Hz attention flash (kept under the 3 Hz threshold) _lock_setup gatelock config + arbiter claim _startup wake display, brightness, plug _tone tone synthesis and cache (out of _audio) _brightness xrandr brightness (was in _audio, never belonged there) main() deliberately stays in _alarm.py: morning_routine/_orchestrator.py:39 hardcodes "wake_alarm._alarm", and moving it is the exact mistake that caused a month-long silent production failure once already. Verified after the split that the module still resolves and accepts --production. Also fixes the plug pre-roll found while researching speakers: main() fired turn_on_plug() and the first beep in the same instant, so an amplifier's soft-start relay swallowed the opening of the alarm. PLUG_PREROLL_SECONDS=4 now sits between them. Two bugs found by running the code rather than by lint: - ruff stripped `struct` from the extracted _tone.py because the import landed before its first usage; only executing it caught the NameError. - test fixtures patched _play_on_all_sinks/_set_max_brightness at wake_alarm._alarm, which silently stopped intercepting once those moved. 404 tests, 100% branch coverage, no new noqa/type-ignore suppressions. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EckWmyfetYq3Mi8MAnUudh
150 lines
4.7 KiB
Python
150 lines
4.7 KiB
Python
"""Tests for the alarm daemon entry point."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import tkinter as tk
|
|
from typing import TYPE_CHECKING
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
import pytest
|
|
|
|
if TYPE_CHECKING:
|
|
from collections.abc import Generator
|
|
|
|
from wake_alarm._alarm import (
|
|
WakeAlarm,
|
|
main,
|
|
)
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Helpers (duplicated from part 1 so this file is self-contained)
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
# Helpers (duplicated from part 1 so this file is self-contained)
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
def _make_mock_tk() -> MagicMock:
|
|
"""Build a MagicMock that stands in for the tkinter module."""
|
|
mock = MagicMock()
|
|
mock_root = MagicMock()
|
|
mock_root.winfo_screenwidth.return_value = 1920
|
|
mock_root.winfo_screenheight.return_value = 1080
|
|
mock.Tk.return_value = mock_root
|
|
# Distinct frames and buttons per call: a shared return_value would make
|
|
# "every monitor got one" indistinguishable from "one monitor got two".
|
|
mock.Frame.side_effect = lambda *_args, **_kwargs: MagicMock()
|
|
mock.Button.side_effect = lambda *_args, **_kwargs: MagicMock()
|
|
mock.Label.return_value = MagicMock()
|
|
mock.Entry.return_value = MagicMock()
|
|
mock.TclError = tk.TclError
|
|
mock.END = tk.END
|
|
return mock
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _block_real_tk() -> Generator[MagicMock]:
|
|
"""Prevent any real Tk windows in tests."""
|
|
mock = _make_mock_tk()
|
|
with (
|
|
patch("wake_alarm._alarm.tk", mock),
|
|
patch("wake_alarm._dismiss_view.tk", mock),
|
|
patch("wake_alarm._alarm_view.tk", mock),
|
|
patch(
|
|
"wake_alarm._alarm.GateRoot",
|
|
return_value=mock.Tk.return_value,
|
|
),
|
|
):
|
|
yield mock
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _block_extra_devices() -> Generator[MagicMock]:
|
|
"""Prevent real subprocess.Popen calls for extra ALSA devices."""
|
|
with (
|
|
patch("wake_alarm._beep_loop._play_on_all_sinks") as mock,
|
|
patch("wake_alarm._startup._set_max_brightness"),
|
|
patch("wake_alarm._startup._wake_display"),
|
|
patch("wake_alarm._alarm._restore_display"),
|
|
patch("wake_alarm._startup._warn_if_no_real_sink"),
|
|
patch("wake_alarm._alarm._activate_all_outputs", return_value=None),
|
|
patch("wake_alarm._alarm._restore_audio_state"),
|
|
patch("wake_alarm._startup.turn_on_plug"),
|
|
patch("wake_alarm._alarm.turn_off_plug"),
|
|
):
|
|
yield mock
|
|
|
|
|
|
@pytest.fixture
|
|
def mock_tk_module() -> Generator[MagicMock]:
|
|
"""Provide explicit access to the mocked tk module."""
|
|
mock = _make_mock_tk()
|
|
with (
|
|
patch("wake_alarm._alarm.tk", mock),
|
|
patch("wake_alarm._dismiss_view.tk", mock),
|
|
patch("wake_alarm._alarm_view.tk", mock),
|
|
patch(
|
|
"wake_alarm._alarm.GateRoot",
|
|
return_value=mock.Tk.return_value,
|
|
),
|
|
):
|
|
yield mock
|
|
|
|
|
|
class TestMain:
|
|
"""Tests for the main() entry point."""
|
|
|
|
def test_exits_when_not_alarm_day(self) -> None:
|
|
"""main() returns early when not an alarm day."""
|
|
with (
|
|
patch(
|
|
"wake_alarm._alarm.should_run_alarm",
|
|
return_value=False,
|
|
),
|
|
patch("wake_alarm._alarm.sys") as mock_sys,
|
|
):
|
|
mock_sys.argv = ["alarm"]
|
|
main() # Should just return without error
|
|
|
|
def test_creates_alarm_when_should_run(
|
|
self,
|
|
mock_tk_module: MagicMock,
|
|
) -> None:
|
|
"""main() creates a WakeAlarm when conditions are met."""
|
|
del mock_tk_module
|
|
with (
|
|
patch(
|
|
"wake_alarm._alarm.should_run_alarm",
|
|
return_value=True,
|
|
),
|
|
patch(
|
|
"wake_alarm._alarm.sys",
|
|
) as mock_sys,
|
|
patch.object(WakeAlarm, "run") as mock_run,
|
|
patch.object(WakeAlarm, "__init__", return_value=None),
|
|
):
|
|
mock_sys.argv = ["alarm"]
|
|
main()
|
|
mock_run.assert_called_once()
|
|
|
|
def test_trigger_now_bypasses_gate(
|
|
self,
|
|
mock_tk_module: MagicMock,
|
|
) -> None:
|
|
"""--trigger-now bypasses _should_run_alarm."""
|
|
del mock_tk_module
|
|
with (
|
|
patch(
|
|
"wake_alarm._alarm.should_run_alarm",
|
|
return_value=False,
|
|
) as mock_gate,
|
|
patch("wake_alarm._alarm.sys") as mock_sys,
|
|
patch.object(WakeAlarm, "run") as mock_run,
|
|
patch.object(WakeAlarm, "__init__", return_value=None),
|
|
):
|
|
mock_sys.argv = ["alarm", "--trigger-now"]
|
|
main()
|
|
mock_gate.assert_not_called()
|
|
mock_run.assert_called_once()
|