mirror of
https://github.com/kuhyx/wake-alarm.git
synced 2026-11-10 19:27:02 +01:00
Krzysztof kuhy Rudnicki
9e0cd123ff
Item 14: the fan ramp is gone entirely. It caused anxiety without helping anyone wake up. Deletes _max_fans/_restore_fans/_find_fan_hwmon, the _AlarmHardware.fan_state field, both call sites, and their tests. wake-alarm-fans.sh and its NOPASSWD sudoers entry come out in the install.sh pass -- dropping a passwordless root helper is a bonus. _alarm.py was 478 lines and the 250-line gate fires on any commit that stages it, so this carries the split it has owed for a while. New modules, each a real seam rather than an arbitrary cut: _gating should-it-run-today + CLI (no time gate; that is _trigger's) _beep_loop the sounding thread, now driving _escalation's planner _alarm_timers self-rescheduling challenge refresh / skip window (mixin) _alarm_state the progress + hardware dataclasses _rounds challenge presentation, re-exporting the view helpers _countdown skip-window arithmetic and demo/production intervals _dismiss_view the post-dismissal banner _screen_flash the ~1.3 Hz attention flash (kept under the 3 Hz threshold) _lock_setup gatelock config + arbiter claim _startup wake display, brightness, plug _tone tone synthesis and cache (out of _audio) _brightness xrandr brightness (was in _audio, never belonged there) main() deliberately stays in _alarm.py: morning_routine/_orchestrator.py:39 hardcodes "wake_alarm._alarm", and moving it is the exact mistake that caused a month-long silent production failure once already. Verified after the split that the module still resolves and accepts --production. Also fixes the plug pre-roll found while researching speakers: main() fired turn_on_plug() and the first beep in the same instant, so an amplifier's soft-start relay swallowed the opening of the alarm. PLUG_PREROLL_SECONDS=4 now sits between them. Two bugs found by running the code rather than by lint: - ruff stripped `struct` from the extracted _tone.py because the import landed before its first usage; only executing it caught the NameError. - test fixtures patched _play_on_all_sinks/_set_max_brightness at wake_alarm._alarm, which silently stopped intercepting once those moved. 404 tests, 100% branch coverage, no new noqa/type-ignore suppressions. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EckWmyfetYq3Mi8MAnUudh
119 lines
4.0 KiB
Python
119 lines
4.0 KiB
Python
"""Tests for raising every monitor to full brightness."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import subprocess
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
from wake_alarm._brightness import _set_max_brightness
|
|
|
|
|
|
class TestSetMaxBrightness:
|
|
"""Tests for _set_max_brightness."""
|
|
|
|
def test_noop_when_xrandr_missing(self) -> None:
|
|
"""No xrandr on PATH → subprocess.run never called."""
|
|
with (
|
|
patch("wake_alarm._audio.shutil.which", return_value=None),
|
|
patch("wake_alarm._audio.subprocess.run") as mock_run,
|
|
):
|
|
_set_max_brightness()
|
|
mock_run.assert_not_called()
|
|
|
|
def test_noop_on_oserror_from_query(self) -> None:
|
|
"""OSError from xrandr --query is suppressed."""
|
|
with (
|
|
patch(
|
|
"wake_alarm._audio.shutil.which",
|
|
return_value="/usr/bin/xrandr",
|
|
),
|
|
patch(
|
|
"wake_alarm._audio.subprocess.run",
|
|
side_effect=OSError("no display"),
|
|
),
|
|
):
|
|
_set_max_brightness() # must not raise
|
|
|
|
def test_noop_on_timeout_from_query(self) -> None:
|
|
"""TimeoutExpired from xrandr --query is suppressed."""
|
|
with (
|
|
patch(
|
|
"wake_alarm._audio.shutil.which",
|
|
return_value="/usr/bin/xrandr",
|
|
),
|
|
patch(
|
|
"wake_alarm._audio.subprocess.run",
|
|
side_effect=subprocess.TimeoutExpired("xrandr", 5),
|
|
),
|
|
):
|
|
_set_max_brightness() # must not raise
|
|
|
|
def test_sets_brightness_for_connected_displays(self) -> None:
|
|
"""Connected displays each get an --output --brightness call."""
|
|
mock_query_result = MagicMock()
|
|
mock_query_result.stdout = (
|
|
"HDMI-0 connected 2560x1440+0+0\nDP-0 connected primary\n"
|
|
)
|
|
call_args_list: list[list[str]] = []
|
|
|
|
def fake_run(args: list[str], **_kwargs: object) -> MagicMock:
|
|
call_args_list.append(args)
|
|
return mock_query_result
|
|
|
|
with (
|
|
patch(
|
|
"wake_alarm._audio.shutil.which",
|
|
return_value="/usr/bin/xrandr",
|
|
),
|
|
patch("wake_alarm._audio.subprocess.run", side_effect=fake_run),
|
|
):
|
|
_set_max_brightness()
|
|
|
|
# First call is --query; subsequent calls set brightness for each output.
|
|
brightness_calls = [a for a in call_args_list if "--brightness" in a]
|
|
expected_brightness_calls = 2
|
|
assert len(brightness_calls) == expected_brightness_calls
|
|
|
|
def test_skips_disconnected_outputs(self) -> None:
|
|
"""Disconnected outputs do NOT get a brightness call."""
|
|
mock_result = MagicMock()
|
|
mock_result.stdout = "Screen 0: minimum 320\nHDMI-0 disconnected\n"
|
|
with (
|
|
patch(
|
|
"wake_alarm._audio.shutil.which",
|
|
return_value="/usr/bin/xrandr",
|
|
),
|
|
patch(
|
|
"wake_alarm._audio.subprocess.run",
|
|
return_value=mock_result,
|
|
) as mock_run,
|
|
):
|
|
_set_max_brightness()
|
|
# Only the --query call, no brightness calls.
|
|
assert mock_run.call_count == 1
|
|
|
|
def test_warns_when_brightness_call_fails(self) -> None:
|
|
"""OSError on per-output --brightness call is logged but swallowed."""
|
|
query_result = MagicMock()
|
|
query_result.stdout = (
|
|
"Screen 0: minimum 320\nHDMI-0 connected primary 1920x1080\n"
|
|
)
|
|
|
|
def _run_side_effect(args: list[str], **_kwargs: object) -> MagicMock:
|
|
if "--query" in args:
|
|
return query_result
|
|
msg = "permission denied"
|
|
raise OSError(msg)
|
|
|
|
with (
|
|
patch(
|
|
"wake_alarm._audio.shutil.which",
|
|
return_value="/usr/bin/xrandr",
|
|
),
|
|
patch(
|
|
"wake_alarm._audio.subprocess.run",
|
|
side_effect=_run_side_effect,
|
|
),
|
|
):
|
|
_set_max_brightness() # must not raise
|