mirror of
https://github.com/kuhyx/wake-alarm.git
synced 2026-11-10 18:07:05 +01:00
Krzysztof kuhy Rudnicki
9e0cd123ff
Item 14: the fan ramp is gone entirely. It caused anxiety without helping anyone wake up. Deletes _max_fans/_restore_fans/_find_fan_hwmon, the _AlarmHardware.fan_state field, both call sites, and their tests. wake-alarm-fans.sh and its NOPASSWD sudoers entry come out in the install.sh pass -- dropping a passwordless root helper is a bonus. _alarm.py was 478 lines and the 250-line gate fires on any commit that stages it, so this carries the split it has owed for a while. New modules, each a real seam rather than an arbitrary cut: _gating should-it-run-today + CLI (no time gate; that is _trigger's) _beep_loop the sounding thread, now driving _escalation's planner _alarm_timers self-rescheduling challenge refresh / skip window (mixin) _alarm_state the progress + hardware dataclasses _rounds challenge presentation, re-exporting the view helpers _countdown skip-window arithmetic and demo/production intervals _dismiss_view the post-dismissal banner _screen_flash the ~1.3 Hz attention flash (kept under the 3 Hz threshold) _lock_setup gatelock config + arbiter claim _startup wake display, brightness, plug _tone tone synthesis and cache (out of _audio) _brightness xrandr brightness (was in _audio, never belonged there) main() deliberately stays in _alarm.py: morning_routine/_orchestrator.py:39 hardcodes "wake_alarm._alarm", and moving it is the exact mistake that caused a month-long silent production failure once already. Verified after the split that the module still resolves and accepts --production. Also fixes the plug pre-roll found while researching speakers: main() fired turn_on_plug() and the first beep in the same instant, so an amplifier's soft-start relay swallowed the opening of the alarm. PLUG_PREROLL_SECONDS=4 now sits between them. Two bugs found by running the code rather than by lint: - ruff stripped `struct` from the extracted _tone.py because the import landed before its first usage; only executing it caught the NameError. - test fixtures patched _play_on_all_sinks/_set_max_brightness at wake_alarm._alarm, which silently stopped intercepting once those moved. 404 tests, 100% branch coverage, no new noqa/type-ignore suppressions. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EckWmyfetYq3Mi8MAnUudh
84 lines
2.7 KiB
Python
84 lines
2.7 KiB
Python
"""Tests for the no-real-sink warning."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from unittest.mock import patch
|
|
|
|
from wake_alarm._sinks import (
|
|
_warn_if_no_real_sink,
|
|
)
|
|
|
|
# A representative `pactl list cards` block covering every parse branch:
|
|
# an HDMI card (off, with an available stereo output profile), an input-only
|
|
# card (no output profile), a card block with no Name line (must be skipped).
|
|
_CARDS_TEXT = """Card #54
|
|
\tName: alsa_card.hdmi
|
|
\tDriver: module-alsa-card.c
|
|
\tProfiles:
|
|
\t\toff: Off (sinks: 0, sources: 0, priority: 0, available: yes)
|
|
\t\toutput:hdmi-stereo: Stereo (sinks: 1, priority: 5900, available: yes)
|
|
\t\toutput:hdmi-surround: Surround (sinks: 1, priority: 600, available: no)
|
|
\t\tbroken (available: yes)
|
|
\tActive Profile: off
|
|
Card #55
|
|
\tName: alsa_card.mic
|
|
\tProfiles:
|
|
\t\toff: Off (sinks: 0, sources: 0, priority: 0, available: yes)
|
|
\tActive Profile: off
|
|
Card #56
|
|
\tProfiles:
|
|
\t\toutput:noname: NoName (available: yes)
|
|
\tActive Profile: off
|
|
"""
|
|
|
|
# A `pactl list sinks` block: a normal sink, plus one whose Volume line has
|
|
# no integer (to cover the "no digit" branch), plus a leading non-Name line.
|
|
_SINKS_TEXT = """Sink #62
|
|
\tState: SUSPENDED
|
|
\tName: alsa_output.analog
|
|
\tMute: no
|
|
\tVolume: front-left: 65536 / 100%
|
|
\tDescription: Built-in Analog
|
|
Sink #63
|
|
\tName: alsa_output.weird
|
|
\tMute: yes
|
|
\tVolume: n/a
|
|
"""
|
|
|
|
|
|
class TestWarnIfNoRealSink:
|
|
"""Tests for _warn_if_no_real_sink."""
|
|
|
|
def test_logs_when_pactl_missing(self) -> None:
|
|
"""No pactl on PATH → warns and returns (no sink lookup)."""
|
|
with (
|
|
patch("wake_alarm._sinks._pactl_path", return_value=None),
|
|
patch("wake_alarm._sinks._list_real_sinks") as mock_list,
|
|
):
|
|
_warn_if_no_real_sink()
|
|
mock_list.assert_not_called()
|
|
|
|
def test_warns_when_no_real_sink(self) -> None:
|
|
"""No real sink → warning is emitted."""
|
|
with (
|
|
patch("wake_alarm._sinks._pactl_path", return_value="/usr/bin/pactl"),
|
|
patch("wake_alarm._sinks._list_real_sinks", return_value=[]),
|
|
patch("wake_alarm._sinks._logger") as mock_log,
|
|
):
|
|
_warn_if_no_real_sink()
|
|
mock_log.warning.assert_called()
|
|
|
|
def test_info_when_real_sink_present(self) -> None:
|
|
"""A real sink → info log, no warning."""
|
|
with (
|
|
patch("wake_alarm._sinks._pactl_path", return_value="/usr/bin/pactl"),
|
|
patch(
|
|
"wake_alarm._sinks._list_real_sinks",
|
|
return_value=["alsa_output.analog"],
|
|
),
|
|
patch("wake_alarm._sinks._logger") as mock_log,
|
|
):
|
|
_warn_if_no_real_sink()
|
|
mock_log.info.assert_called()
|
|
mock_log.warning.assert_not_called()
|