wake-alarm/phone_app/lib/services
Krzysztof kuhy Rudnicki a845cac883 Remove the flash challenge; revert the MethodChannel split that regressed NFC
Two things, one of them an undo of my own change.

The flash challenge is gone from the phone's rotation. It hides the code after
kDismissFlashSeconds, and on the phone that is unsolvable in practice: the ring
screen is reached by walking to another room and tapping a tag, so the code has
already vanished by the time the user is looking at it. Reported from the phone
as "invisible - impossible to actually do". Every challenge the alarm shows now
stays on screen until it is answered, and a test asserts next() never returns
one that hides itself. The constructor stays for the PC half's parity tests;
nothing routes to it.

The two-channel split is reverted. I introduced it to fix a tag reaching Kotlin
but not Dart, and pointed the push channel at the call channel — which broke
NFC *and* the step counter, both of which had been confirmed working on the
phone one build earlier. The user caught it: "they worked previously so your
changes regressed it". The split was a theory that was never shown to be
necessary; the single channel from 08b44b4 is restored unchanged.

Lesson worth keeping: when hardware has just confirmed a path works, the next
change should be the smallest possible delta on top of that exact state, not a
restructure bundled with a fix.

flutter test: 70 pass. dart analyze lib/ test/: clean.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EckWmyfetYq3Mi8MAnUudh
2026-08-27 22:45:35 +02:00
..
alarm_arming.dart Bring the two files this change grew back under the 250-line gate 2026-08-27 21:43:16 +02:00
alarm_scheduler.dart Phase 4/3: close the ring screen on dismiss, and make NFC registerable 2026-08-27 21:39:01 +02:00
alarm_sync_service.dart Discover alarm device directories instead of reading a fixed phone path 2026-08-09 17:06:43 +02:00
challenge.dart Remove the flash challenge; revert the MethodChannel split that regressed NFC 2026-08-27 22:45:35 +02:00
firebase_backend.dart phone_app: add Google sign-in support for the Firebase sync account 2026-08-14 11:26:33 +02:00
google_platform_io.dart phone_app: add Google sign-in support for the Firebase sync account 2026-08-14 11:26:33 +02:00
google_platform_web.dart phone_app: add Google sign-in support for the Firebase sync account 2026-08-14 11:26:33 +02:00
google_platform.dart phone_app: add Google sign-in support for the Firebase sync account 2026-08-14 11:26:33 +02:00
google_sign_in_backend.dart phone_app: add Google sign-in support for the Firebase sync account 2026-08-14 11:26:33 +02:00
room_proof_settings.dart Phase 4/3: NFC room proof, runtime permissions, non-blocking step reads 2026-08-27 21:28:24 +02:00
room_proof.dart Phase 4/3: the phone's Dart half — ring screen, challenges, room proofs 2026-08-27 21:22:07 +02:00
sync_settings.dart Migrate phone_app alarm sync from GitHub Gist to crdt_sync 2026-07-11 22:45:14 +02:00