Stop passing --skip-steamcmd to the installer

steam-game-installer drops the flag (no alias): it always writes the
manifest itself now, so the argv no longer passes it. The progress
tracker drops the "Reconciling with steamcmd" marker, which the
installer no longer prints, and names the phase after the DLC check
"writing manifest".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Krzysztof Rudnicki 2026-11-22 14:42:45 +01:00
parent 550e702b7a
commit a3c7c279a5
5 changed files with 6 additions and 11 deletions

View File

@ -61,9 +61,6 @@ def build_cmd(installer: Path, app_id: int, user: str | None) -> list[str]:
"--yes",
"--language",
_LANGUAGE,
# Finishes the manifest from depotdownloader's own data, under the same
# fail-closed checks: no second login, no 70 GB re-hash by steamcmd.
"--skip-steamcmd",
]
account = steam_account_name()
if account:

View File

@ -10,7 +10,7 @@ endings, from the pty). Its markers, verbatim from a real run:
* ``Processing depot 1086941`` once per depot, then ``Downloading depot 1086941``
as each one starts
* `` 46.90% /path/of/finished/file (657.13 Mbit/s)`` per finished file
* ``Checking for owned DLC ...``, then the manifest is finished
* ``Checking for owned DLC ...``, then the installer writes the manifest itself
* ``Restarting the Steam client...``
The percentage is depotdownloader's progress through the *current depot*: it
@ -51,8 +51,7 @@ _MARKERS: Final = (
("Shutting down the Steam client", "shutting Steam down"),
("Steam already staged", "adopting Steam's partial download"),
("Downloading via depotdownloader", "connecting to Steam"),
("Checking for owned DLC", "finishing manifest"),
("Reconciling with steamcmd", "finishing manifest"),
("Checking for owned DLC", "writing manifest"),
("Restarting the Steam client", "restarting Steam"),
)
_PLANNED_DEPOT: Final = re.compile(r"Processing depot \d+$")

View File

@ -114,7 +114,6 @@ class TestBuildCmd:
"--yes",
"--language",
"english",
"--skip-steamcmd",
"--username",
"krzys",
]

View File

@ -83,10 +83,10 @@ class TestPhases:
assert snap.phase == "downloading depot 3/8"
assert snap.percent == pytest.approx(92.49)
def test_finishing_after_the_download(self, tmp_path: Path) -> None:
"""The DLC check after the download reads as finishing manifest."""
def test_writing_manifest_after_the_download(self, tmp_path: Path) -> None:
"""The DLC check after the download reads as writing the manifest."""
snap = _tracker(tmp_path, upto("Checking for owned DLC")).snapshot(now=0)
assert snap.phase == "finishing manifest"
assert snap.phase == "writing manifest"
assert snap.percent is None
assert not snap.downloading

View File

@ -168,7 +168,7 @@ export type DaemonState = 'running' | 'restarting' | 'unreachable'
export interface FastInstallRun {
app_id: number
name: string
/** e.g. `shutting Steam down`, `downloading depot 3/8`, `finishing manifest`. */
/** e.g. `shutting Steam down`, `downloading depot 3/8`, `writing manifest`. */
phase: string
/** The current depot's percent; null until depotdownloader reports one. */
percent: number | null