steam-backlog-enforcer/steam_backlog_enforcer/tests/test_library_hider.py
Krzysztof kuhy Rudnicki d54df3a1ad
Some checks are pending
pre-commit / pre-commit (push) Waiting to run
Tests / test (3.10) (push) Waiting to run
Tests / test (3.11) (push) Waiting to run
Tests / test (3.12) (push) Waiting to run
fix(enforcer): idle when Steam is absent instead of crash-looping
A total gaming block on 2026-07-04 purged the Steam client (packages and
all data dirs, per total_block_purge_log.json) and it was never
reinstalled. The enforcer kept trying to drive it anyway: every start
called ensure_steam_debug_port() -> _launch_steam_with_debug(), waited
45s for a CDP port no process would ever open, raised, and exited 1 into
Restart=always. That ran to 1050+ restarts.

Each attempt also left a zombie behind: _run_as_user() launches
fire-and-forget via Popen and never reaps, so a launch that dies on exec
lingers as a dead process still named "steam". The focus-mode daemon
scans /proc for process names and read that zombie as a live Steam,
entering GAMING mode and killing the user's browsers every few seconds.

- steam_is_installed(): probe the real /usr/bin/steam. Deliberately not
  shutil.which("steam") - a launcher wrapper on $PATH keeps `which`
  truthy long after the package is gone, which is precisely how a
  deleted Steam went on looking installed.
- SteamUnavailableError (a RuntimeError, so existing handlers still
  catch it) raised on both "not installed" and CDP timeout, and caught
  at the _enforce_hide_games boundary: no library to hide is not fatal,
  the store block and install guard still work.
- Guard _enforce_loop_iteration and game_install._ensure_steam_running,
  whose 15s sleep was the source of the observed flapping interval.
- do_enforce falls through to the idle loop rather than returning:
  returning exits the process, which under Restart=always is the same
  crash loop by another name.
- _reap_spawned() retires exited launches so no zombie named "steam"
  outlives them.

Verified live: NRestarts 1050 -> 0, service active/running for 60s+ with
zero errors and zero steam zombies, logging "Steam is not installed -
nothing to enforce."

Also removed the orphaned /usr/local/bin/steam wrapper, a leftover of
the purge that pointed at the deleted binary. Its body was:
  #!/bin/sh
  exec /usr/bin/steam -cef-disable-gpu -cef-disable-gpu-compositing "$@"
Restore those flags if a Steam reinstall brings back GPU trouble.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013rN2usTS3pYLJqeVg2ZpgR
2026-07-17 13:53:24 +02:00

469 lines
14 KiB
Python

"""Tests for library_hider module."""
from __future__ import annotations
import asyncio
import json
from typing import TYPE_CHECKING
from unittest.mock import AsyncMock, MagicMock, patch
import pytest
from steam_backlog_enforcer.library_hider import (
SteamUnavailableError,
_cdp_result_value,
_evaluate_js,
_evaluate_js_async,
_get_shared_js_ws_url,
_is_steam_running,
_launch_steam_with_debug,
_shutdown_steam,
_steam_has_debug_port,
_wait_for_cdp_ready,
_wait_for_collections_ready,
ensure_steam_debug_port,
)
if TYPE_CHECKING:
from collections.abc import Iterator
class TestGetSharedJsWsUrl:
"""Tests for _get_shared_js_ws_url."""
def test_finds_url(self) -> None:
targets = [
{
"title": "SharedJSContext",
"webSocketDebuggerUrl": "ws://127.0.0.1:8080/x",
},
{"title": "Other", "webSocketDebuggerUrl": "ws://other"},
]
mock_resp = MagicMock()
mock_resp.json.return_value = targets
with patch(
"steam_backlog_enforcer.library_hider.requests.get",
return_value=mock_resp,
):
result = _get_shared_js_ws_url()
assert result == "ws://127.0.0.1:8080/x"
def test_no_shared_context(self) -> None:
targets = [{"title": "Other", "webSocketDebuggerUrl": "ws://other"}]
mock_resp = MagicMock()
mock_resp.json.return_value = targets
with patch(
"steam_backlog_enforcer.library_hider.requests.get",
return_value=mock_resp,
):
assert _get_shared_js_ws_url() is None
def test_connection_error(self) -> None:
with patch(
"steam_backlog_enforcer.library_hider.requests.get",
side_effect=OSError,
):
assert _get_shared_js_ws_url() is None
class TestEvaluateJsAsync:
"""Tests for _evaluate_js_async."""
def test_success(self) -> None:
mock_ws = AsyncMock()
mock_ws.send = AsyncMock()
mock_ws.recv = AsyncMock(
return_value=json.dumps({"result": {"result": {"value": "ok"}}})
)
mock_ws.__aenter__ = AsyncMock(return_value=mock_ws)
mock_ws.__aexit__ = AsyncMock(return_value=False)
with patch(
"steam_backlog_enforcer.library_hider.websockets.connect",
return_value=mock_ws,
):
result = asyncio.run(_evaluate_js_async("ws://test", "1+1"))
assert result["result"]["result"]["value"] == "ok"
class TestEvaluateJs:
"""Tests for _evaluate_js."""
def test_success(self) -> None:
with (
patch(
"steam_backlog_enforcer.library_hider._get_shared_js_ws_url",
return_value="ws://test",
),
patch(
"steam_backlog_enforcer.library_hider.asyncio.run",
return_value={"result": {"result": {"value": "ok"}}},
),
):
result = _evaluate_js("1+1")
assert result["result"]["result"]["value"] == "ok"
def test_no_ws_url(self) -> None:
with (
patch(
"steam_backlog_enforcer.library_hider._get_shared_js_ws_url",
return_value=None,
),
pytest.raises(RuntimeError, match="SharedJSContext not found"),
):
_evaluate_js("1+1")
class TestCdpResultValue:
"""Tests for _cdp_result_value."""
def test_extracts_value(self) -> None:
result = {"result": {"result": {"value": "hello"}}}
assert _cdp_result_value(result) == "hello"
def test_exception(self) -> None:
result = {
"result": {
"result": {"description": "Error!"},
"exceptionDetails": {},
}
}
with pytest.raises(RuntimeError, match="JS evaluation error"):
_cdp_result_value(result)
def test_empty(self) -> None:
assert _cdp_result_value({}) == ""
class TestIsSteamRunning:
"""Tests for _is_steam_running."""
def test_running(self) -> None:
mock_result = MagicMock(returncode=0)
with patch(
"steam_backlog_enforcer.library_hider.subprocess.run",
return_value=mock_result,
):
assert _is_steam_running() is True
def test_not_running(self) -> None:
mock_result = MagicMock(returncode=1)
with patch(
"steam_backlog_enforcer.library_hider.subprocess.run",
return_value=mock_result,
):
assert _is_steam_running() is False
class TestSteamHasDebugPort:
"""Tests for _steam_has_debug_port."""
def test_has_port(self) -> None:
with patch(
"steam_backlog_enforcer.library_hider._get_shared_js_ws_url",
return_value="ws://test",
):
assert _steam_has_debug_port() is True
def test_no_port(self) -> None:
with patch(
"steam_backlog_enforcer.library_hider._get_shared_js_ws_url",
return_value=None,
):
assert _steam_has_debug_port() is False
class TestWaitForCdpReady:
"""Tests for _wait_for_cdp_ready."""
def test_ready_immediately(self) -> None:
with patch(
"steam_backlog_enforcer.library_hider._get_shared_js_ws_url",
return_value="ws://test",
):
assert _wait_for_cdp_ready() is True
def test_timeout(self) -> None:
with (
patch(
"steam_backlog_enforcer.library_hider._get_shared_js_ws_url",
return_value=None,
),
patch(
"steam_backlog_enforcer.library_hider.time.sleep",
),
patch(
"steam_backlog_enforcer.library_hider._STEAM_STARTUP_WAIT",
2,
),
):
assert _wait_for_cdp_ready() is False
class TestWaitForCollectionsReady:
"""Tests for _wait_for_collections_ready."""
def test_ready(self) -> None:
with (
patch(
"steam_backlog_enforcer.library_hider._evaluate_js",
return_value={"result": {"result": {"value": "ok"}}},
),
patch(
"steam_backlog_enforcer.library_hider._cdp_result_value",
return_value="ok",
),
):
assert _wait_for_collections_ready() is True
def test_not_ready_then_ready(self) -> None:
with (
patch(
"steam_backlog_enforcer.library_hider._evaluate_js",
return_value={"result": {"result": {"value": "not_ready"}}},
),
patch(
"steam_backlog_enforcer.library_hider._cdp_result_value",
side_effect=["not_ready", "ok"],
),
patch(
"steam_backlog_enforcer.library_hider.time.sleep",
),
patch(
"steam_backlog_enforcer.library_hider._STEAM_STARTUP_WAIT",
2,
),
):
assert _wait_for_collections_ready() is True
def test_timeout(self) -> None:
with (
patch(
"steam_backlog_enforcer.library_hider._evaluate_js",
side_effect=RuntimeError,
),
patch(
"steam_backlog_enforcer.library_hider.time.sleep",
),
patch(
"steam_backlog_enforcer.library_hider._STEAM_STARTUP_WAIT",
2,
),
):
assert _wait_for_collections_ready() is False
class TestShutdownSteam:
"""Tests for _shutdown_steam."""
def test_exits_immediately(self) -> None:
mock_result = MagicMock(returncode=1) # Not running
with (
patch(
"steam_backlog_enforcer.library_hider._run_as_user",
),
patch(
"steam_backlog_enforcer.library_hider.subprocess.run",
return_value=mock_result,
),
):
_shutdown_steam()
def test_waits_for_exit(self) -> None:
results = [MagicMock(returncode=0), MagicMock(returncode=1)]
with (
patch(
"steam_backlog_enforcer.library_hider._run_as_user",
),
patch(
"steam_backlog_enforcer.library_hider.subprocess.run",
side_effect=results,
),
patch(
"steam_backlog_enforcer.library_hider.time.sleep",
),
):
_shutdown_steam()
def test_file_not_found(self) -> None:
with patch(
"steam_backlog_enforcer.library_hider._run_as_user",
side_effect=FileNotFoundError,
):
_shutdown_steam() # Should not raise
def test_timeout(self) -> None:
mock_result = MagicMock(returncode=0) # Still running
with (
patch(
"steam_backlog_enforcer.library_hider._run_as_user",
),
patch(
"steam_backlog_enforcer.library_hider.subprocess.run",
return_value=mock_result,
),
patch(
"steam_backlog_enforcer.library_hider.time.sleep",
),
):
_shutdown_steam() # Should complete loop without raising
class TestLaunchSteamWithDebug:
"""Tests for _launch_steam_with_debug."""
def test_launches(self) -> None:
with patch(
"steam_backlog_enforcer.library_hider._run_as_user",
) as mock_run:
_launch_steam_with_debug()
mock_run.assert_called_once()
class TestEnsureSteamDebugPort:
"""Tests for ensure_steam_debug_port."""
@pytest.fixture(autouse=True)
def _steam_present(self) -> Iterator[None]:
"""Pretend Steam is installed for every test in this class.
Without it the function raises before reaching any launch logic,
which on a test machine without Steam would make the cases below
vacuous. The absent case has its own test.
"""
with patch(
"steam_backlog_enforcer.library_hider.steam_is_installed",
return_value=True,
):
yield
def test_raises_when_steam_absent(self) -> None:
"""An uninstalled Steam must fail fast, before any launch attempt.
Regression guard: without this the caller spent ~45s waiting on a
CDP port that no process was ever going to open.
"""
with (
patch(
"steam_backlog_enforcer.library_hider._steam_has_debug_port",
return_value=False,
),
patch(
"steam_backlog_enforcer.library_hider.steam_is_installed",
return_value=False,
),
patch(
"steam_backlog_enforcer.library_hider._launch_steam_with_debug",
) as mock_launch,
pytest.raises(SteamUnavailableError, match="not installed"),
):
ensure_steam_debug_port()
mock_launch.assert_not_called()
def test_already_available(self) -> None:
with patch(
"steam_backlog_enforcer.library_hider._steam_has_debug_port",
return_value=True,
):
ensure_steam_debug_port()
def test_starts_fresh(self) -> None:
with (
patch(
"steam_backlog_enforcer.library_hider._steam_has_debug_port",
return_value=False,
),
patch(
"steam_backlog_enforcer.library_hider._is_steam_running",
return_value=False,
),
patch(
"steam_backlog_enforcer.library_hider._launch_steam_with_debug",
),
patch(
"steam_backlog_enforcer.library_hider._wait_for_cdp_ready",
return_value=True,
),
patch(
"steam_backlog_enforcer.library_hider._wait_for_collections_ready",
return_value=True,
),
):
ensure_steam_debug_port()
def test_restarts_running_steam(self) -> None:
with (
patch(
"steam_backlog_enforcer.library_hider._steam_has_debug_port",
return_value=False,
),
patch(
"steam_backlog_enforcer.library_hider._is_steam_running",
return_value=True,
),
patch(
"steam_backlog_enforcer.library_hider._shutdown_steam",
),
patch(
"steam_backlog_enforcer.library_hider._launch_steam_with_debug",
),
patch(
"steam_backlog_enforcer.library_hider._wait_for_cdp_ready",
return_value=True,
),
patch(
"steam_backlog_enforcer.library_hider._wait_for_collections_ready",
return_value=True,
),
):
ensure_steam_debug_port()
def test_cdp_timeout(self) -> None:
with (
patch(
"steam_backlog_enforcer.library_hider._steam_has_debug_port",
return_value=False,
),
patch(
"steam_backlog_enforcer.library_hider._is_steam_running",
return_value=False,
),
patch(
"steam_backlog_enforcer.library_hider._launch_steam_with_debug",
),
patch(
"steam_backlog_enforcer.library_hider._wait_for_cdp_ready",
return_value=False,
),
pytest.raises(RuntimeError, match="Timed out waiting for Steam CDP"),
):
ensure_steam_debug_port()
def test_collections_timeout(self) -> None:
with (
patch(
"steam_backlog_enforcer.library_hider._steam_has_debug_port",
return_value=False,
),
patch(
"steam_backlog_enforcer.library_hider._is_steam_running",
return_value=False,
),
patch(
"steam_backlog_enforcer.library_hider._launch_steam_with_debug",
),
patch(
"steam_backlog_enforcer.library_hider._wait_for_cdp_ready",
return_value=True,
),
patch(
"steam_backlog_enforcer.library_hider._wait_for_collections_ready",
return_value=False,
),
pytest.raises(
RuntimeError, match="Timed out waiting for Steam collections"
),
):
ensure_steam_debug_port()