mirror of
https://github.com/kuhyx/steam-backlog-enforcer.git
synced 2026-11-10 19:27:04 +01:00
The enforce service runs as root (no User=) but sets DISPLAY=:0, so any GUI
it starts lands on the desktop session. Two resolvers disagreed about who to
drop privileges to:
library_hider._resolve_desktop_user() read STEAM_ENFORCER_DESKTOP_USER
game_install._get_real_user() read only SUDO_USER or USER
systemd sets neither of the latter, so _get_real_user() returned None under
the service and every `geteuid() == 0 and real_user and ...` guard fell
through to running as root. Steam answered with a zenity modal ("Cannot run
as root user", /usr/lib/steam/steam:261) on screen.
Confirmed from the live process tree: root `bash /usr/lib/steam/steam
-cef-disable-gpu ... steam://install/618510` with a root zenity child. It
never reached the journal, because that text goes to zenity and _run_as_user
sends child output to DEVNULL.
- _desktop_env: add resolve_desktop_user/desktop_uid/desktop_user_cmd. Only
the argv builder is shared, never the spawn call: tests/_no_subprocess.py
patches subprocess per module by name, so a spawn site in an unpatched
module could fire a real `sudo -u kuhy steam`.
- game_install._get_real_user: delegate to the shared resolver. This alone
also fixes the root `steam -silent` in _ensure_steam_running and the
no-op os.chown on new appmanifests.
- _trigger_steam_install / enforcer.send_notification: drop privileges.
send_notification had no DBUS_SESSION_BUS_ADDRESS, so it silently reached
nobody for all six of its callers.
- _run_as_user: fail closed. Running unchanged as root when no desktop user
resolves is what put the modal on screen; refuse and log instead.
Also stop the retry storm behind it. steamapps does not exist (Steam has
never completed sign-in), so is_game_installed() was always False and the
loop re-triggered every allowed game every pass: 1656 attempts in 30
minutes, service RSS 1.5 GB (peak 4.3 GB), a FileNotFoundError traceback
each time. Guard install_game and _reinstall_missing_allowed on
steam_library_ready() -- a missing library means no install can succeed by
any route, so this is a correctness check rather than a tuned retry limit.
The module splits here are forced by the pre-commit 250-line gate, which
blocks any commit touching an over-cap file: game_install, library_hider and
_enforce_loop were already over before this change. They are split by
responsibility (_cdp transport, _steam_launch lifecycle, _steam_process
spawning, _steam_errors, _steam_client, _game_names, game_uninstall,
_enforce_steps, _owned_apps_cache, _echo, _protected_apps). game_install and
library_hider re-export their old public names, so the 15 modules that
import from them are untouched by this commit.
Verified as real root under the unit's environment: argv is now
`sudo -u kuhy env DISPLAY=:0 ... xdg-open steam://install/...` for both the
installer and notify-send; three enforce passes spawn no process and log
once; _run_as_user refuses with no desktop user. After restart: 0 retries,
0 tracebacks, 0 root-owned files under ~/.local/share/Steam, RSS 342 MB.
1311 tests pass. _desktop_env and _steam_state at 100% branch coverage.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016A1EYiv7e7HGhET84oa9M3
96 lines
3.3 KiB
Python
96 lines
3.3 KiB
Python
"""Chrome DevTools Protocol transport for Steam's embedded browser.
|
|
|
|
Modern Steam runs its UI in CEF, so collections can only be changed by
|
|
evaluating JS inside it. Split out of
|
|
:mod:`steam_backlog_enforcer.library_hider` to keep both files under the
|
|
250-line cap: this module is pure transport and knows nothing about
|
|
collections.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import asyncio
|
|
import json
|
|
import logging
|
|
|
|
import requests
|
|
import websockets
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
# NOTE: was 8080, which collided with a different local service (Open WebUI)
|
|
# already bound to 0.0.0.0:8080. requests to 127.0.0.1:8080 resolved to that
|
|
# service instead of steamwebhelper's CDP endpoint (which only bound
|
|
# [::1]:8080), so CDP detection silently never worked. 9222 is the
|
|
# conventional Chrome DevTools debug port and was confirmed free.
|
|
_CDP_PORT = 9222
|
|
_CDP_TIMEOUT = 120
|
|
|
|
|
|
# ──────────────────────────────────────────────────────────────
|
|
# CDP (Chrome DevTools Protocol) helpers
|
|
# ──────────────────────────────────────────────────────────────
|
|
|
|
|
|
def _get_shared_js_ws_url() -> str | None:
|
|
"""Query the CDP HTTP endpoint and return the SharedJSContext WS URL."""
|
|
try:
|
|
resp = requests.get(f"http://127.0.0.1:{_CDP_PORT}/json", timeout=5)
|
|
targets = resp.json()
|
|
except (OSError, ValueError):
|
|
return None
|
|
|
|
for target in targets:
|
|
if target.get("title") == "SharedJSContext":
|
|
ws_url: str = target["webSocketDebuggerUrl"]
|
|
return ws_url
|
|
return None
|
|
|
|
|
|
async def _evaluate_js_async(ws_url: str, expression: str) -> dict:
|
|
"""Connect to a CDP WebSocket target and evaluate *expression*."""
|
|
async with websockets.connect(ws_url) as ws:
|
|
msg = json.dumps(
|
|
{
|
|
"id": 1,
|
|
"method": "Runtime.evaluate",
|
|
"params": {
|
|
"expression": expression,
|
|
"returnByValue": True,
|
|
"awaitPromise": True,
|
|
},
|
|
}
|
|
)
|
|
await ws.send(msg)
|
|
resp = await asyncio.wait_for(ws.recv(), timeout=_CDP_TIMEOUT)
|
|
return json.loads(resp)
|
|
|
|
|
|
def _evaluate_js(expression: str) -> dict:
|
|
"""Synchronous wrapper around :func:`_evaluate_js_async`."""
|
|
ws_url = _get_shared_js_ws_url()
|
|
if ws_url is None:
|
|
msg = "SharedJSContext not found on CDP port"
|
|
raise RuntimeError(msg)
|
|
return asyncio.run(_evaluate_js_async(ws_url, expression))
|
|
|
|
|
|
def _cdp_result_value(result: dict) -> str:
|
|
"""Extract the return value from a CDP Runtime.evaluate response."""
|
|
outer = result.get("result", {})
|
|
inner = outer.get("result", {})
|
|
if "exceptionDetails" in outer:
|
|
exc_details = outer["exceptionDetails"]
|
|
exc = exc_details.get("exception", {})
|
|
desc = (
|
|
inner.get("description")
|
|
or exc.get("description")
|
|
or exc_details.get("text")
|
|
or repr(exc_details)
|
|
)
|
|
logger.debug("CDP exception details: %s", exc_details)
|
|
msg = f"JS evaluation error: {desc}"
|
|
raise RuntimeError(msg)
|
|
value: str = inner.get("value", "")
|
|
return value
|