mirror of
https://github.com/kuhyx/steam-backlog-enforcer.git
synced 2026-11-11 13:07:33 +01:00
Krzysztof kuhy Rudnicki
21fe2f7742
The enforce service runs as root (no User=) but sets DISPLAY=:0, so any GUI
it starts lands on the desktop session. Two resolvers disagreed about who to
drop privileges to:
library_hider._resolve_desktop_user() read STEAM_ENFORCER_DESKTOP_USER
game_install._get_real_user() read only SUDO_USER or USER
systemd sets neither of the latter, so _get_real_user() returned None under
the service and every `geteuid() == 0 and real_user and ...` guard fell
through to running as root. Steam answered with a zenity modal ("Cannot run
as root user", /usr/lib/steam/steam:261) on screen.
Confirmed from the live process tree: root `bash /usr/lib/steam/steam
-cef-disable-gpu ... steam://install/618510` with a root zenity child. It
never reached the journal, because that text goes to zenity and _run_as_user
sends child output to DEVNULL.
- _desktop_env: add resolve_desktop_user/desktop_uid/desktop_user_cmd. Only
the argv builder is shared, never the spawn call: tests/_no_subprocess.py
patches subprocess per module by name, so a spawn site in an unpatched
module could fire a real `sudo -u kuhy steam`.
- game_install._get_real_user: delegate to the shared resolver. This alone
also fixes the root `steam -silent` in _ensure_steam_running and the
no-op os.chown on new appmanifests.
- _trigger_steam_install / enforcer.send_notification: drop privileges.
send_notification had no DBUS_SESSION_BUS_ADDRESS, so it silently reached
nobody for all six of its callers.
- _run_as_user: fail closed. Running unchanged as root when no desktop user
resolves is what put the modal on screen; refuse and log instead.
Also stop the retry storm behind it. steamapps does not exist (Steam has
never completed sign-in), so is_game_installed() was always False and the
loop re-triggered every allowed game every pass: 1656 attempts in 30
minutes, service RSS 1.5 GB (peak 4.3 GB), a FileNotFoundError traceback
each time. Guard install_game and _reinstall_missing_allowed on
steam_library_ready() -- a missing library means no install can succeed by
any route, so this is a correctness check rather than a tuned retry limit.
The module splits here are forced by the pre-commit 250-line gate, which
blocks any commit touching an over-cap file: game_install, library_hider and
_enforce_loop were already over before this change. They are split by
responsibility (_cdp transport, _steam_launch lifecycle, _steam_process
spawning, _steam_errors, _steam_client, _game_names, game_uninstall,
_enforce_steps, _owned_apps_cache, _echo, _protected_apps). game_install and
library_hider re-export their old public names, so the 15 modules that
import from them are untouched by this commit.
Verified as real root under the unit's environment: argv is now
`sudo -u kuhy env DISPLAY=:0 ... xdg-open steam://install/...` for both the
installer and notify-send; three enforce passes spawn no process and log
once; _run_as_user refuses with no desktop user. After restart: 0 retries,
0 tracebacks, 0 root-owned files under ~/.local/share/Steam, RSS 342 MB.
1311 tests pass. _desktop_env and _steam_state at 100% branch coverage.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016A1EYiv7e7HGhET84oa9M3
|
||
|---|---|---|
| .. | ||
| __init__.py | ||
| _isolate_playtime.py | ||
| _main_helpers.py | ||
| _no_subprocess.py | ||
| _total_block_paths.py | ||
| conftest.py | ||
| test_actions.py | ||
| test_cmd_done_part2.py | ||
| test_cmd_playtime.py | ||
| test_config.py | ||
| test_desktop_env.py | ||
| test_desktop_session_gating.py | ||
| test_desktop_user_cmd.py | ||
| test_do_enforce.py | ||
| test_enforce_loop_part2.py | ||
| test_enforce_loop_part3.py | ||
| test_enforce_loop.py | ||
| test_enforce_steps.py | ||
| test_enforcer_part2.py | ||
| test_enforcer.py | ||
| test_ensure_debug_port.py | ||
| test_ensure_steam_running.py | ||
| test_game_install_guard.py | ||
| test_game_install_part2.py | ||
| test_game_install_part3.py | ||
| test_game_install.py | ||
| test_game_names.py | ||
| test_hltb_detail.py | ||
| test_hltb_part2.py | ||
| test_hltb_part3.py | ||
| test_hltb_search_part2.py | ||
| test_hltb_search.py | ||
| test_hltb.py | ||
| test_library_hider_ops.py | ||
| test_library_hider_part2.py | ||
| test_library_hider.py | ||
| test_main_abandon.py | ||
| test_main_dispatch_extra.py | ||
| test_main_dispatch.py | ||
| test_main_done.py | ||
| test_main_entrypoint.py | ||
| test_main_install.py | ||
| test_main_misc_gating.py | ||
| test_main_misc.py | ||
| test_main_part2.py | ||
| test_main_part2b.py | ||
| test_main_part2c.py | ||
| test_main_pick_cap.py | ||
| test_main_pick_manual.py | ||
| test_main_picks.py | ||
| test_main_shared.py | ||
| test_main_status.py | ||
| test_mcp_actions.py | ||
| test_mcp_gaming_time.py | ||
| test_mcp.py | ||
| test_pacman.py | ||
| test_playtime_block_part2.py | ||
| test_playtime_block.py | ||
| test_playtime_cutoff.py | ||
| test_playtime_kill.py | ||
| test_playtime_part2.py | ||
| test_playtime_procs.py | ||
| test_playtime_proctree.py | ||
| test_playtime_tick.py | ||
| test_playtime.py | ||
| test_polls_tracking_part2.py | ||
| test_polls_tracking.py | ||
| test_protondb.py | ||
| test_scanning_part2.py | ||
| test_scanning_part3.py | ||
| test_scanning_part4.py | ||
| test_scanning.py | ||
| test_stats.py | ||
| test_steam_api.py | ||
| test_steam_launch_lifecycle.py | ||
| test_steam_restart.py | ||
| test_store_blocker_part2.py | ||
| test_store_blocker.py | ||
| test_total_block_hosts.py | ||
| test_total_block_iptables.py | ||
| test_total_block_lifecycle.py | ||
| test_total_block_purge.py | ||
| test_total_block_remnants.py | ||
| test_total_block.py | ||
| test_update_restart_guard.py | ||
| test_web_dataset.py | ||
| test_web_server.py | ||
| test_whitelist.py | ||