mirror of https://github.com/kuhyx/testsAndMisc.git synced 2026-11-10 20:27:02 +01:00

Krzysztof kuhy Rudnicki 4f2b0ccdf7 Dissolve linux_configuration/scripts/ and single_use/

Two levels of pure taxonomy carrying no information, and a 2-directory
cap leaves no room for them. Categories now sit directly under
linux_configuration/: features, fixes, utils, misc, fresh-install,
installers, diagnostics, gaming, boot_recovery, periodic_background, lib,
meta, tests. A script's own lib/ and tests/ are exempt from the cap, so
those stay put.

Depth violations 248 -> 139; roughly 40 of the remainder are inside
digital_wellbeing and hosts, deferred until the guard-lib repoint.

The moves are the easy half. What breaks is every path that counted
levels, and three classes of it had to be found by resolving paths rather
than reading diffs:

  - 52 relative `source` lines for lib/common.sh and lib/android.sh. The
    correct prefix differs per file: 40 were ../../ and 12 were ../../../,
    so a blanket replace would have fixed one set and broken the other.
  - REPO_ROOT in 7 fixes/lib/tests harnesses and setup_syncyomi_guard.sh,
    each walking up four levels from a directory now two levels shallower.
    This caused a real regression -- the fixes suite went red with
    "log_warn: command not found" -- caught by running it and comparing
    against the pre-move baseline worktree.
  - conftest.py's sys.path entries, which took the pytest gate down with
    14 collection errors, and the `# shellcheck source=` directives, which
    took shellcheck down with SC1091.

16 symlinks in $HOME broke, including the entire i3blocks bar. All
repointed, and cpu_monitor/memory/disk/time/volume were run to confirm
they emit real output rather than merely resolving.

Verified: 1798 tests pass at 100% coverage, 8 of 9 lib/tests suites pass
(the ninth needs the coverage jail, identically at baseline), pre-commit
is clean, and the two untracked secret configs are still ignored after
their gitignore paths changed.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PJrqKERAo5QUeEHWS5Asgp

2026-08-23 18:53:30 +02:00

5.4 KiB

Raw Blame History

Refactor TODO — enforce the 250-line file cap

This file is a ready-to-use prompt. Paste it to Claude, or open this repo and say "do refactor_claude_todo". It is self-contained: everything needed to execute is below. Generated 2026-08-14 from a measured survey of every repo.

Goal

Every file in this repo must be at most 250 lines — source, tests, and prose (.md/.txt/.rst/.tex) alike — and must stay that way forever, enforced by a gate that fails the commit, not by a note anyone can ignore.

Why: a file that cannot be read in one piece forces re-reads and partial edits, which is the single largest avoidable cost in an LLM-assisted workflow. Aim by churn, not size alone — refactoring pays where code is read and changed often (Fowler, refactoring economic benefit).

Scope in this repo

197 files currently exceed 250 lines (of 801 eligible files).
87,393 lines sit in violation; longest file is 2053 lines.

Exempt (do NOT split these):

generated files — *.g.dart, *.freezed.dart, *.gr.dart, **/l10n/generated/**, anything with a GENERATED header
markup — .html, .css, .scss
data files — .json, .yaml, .csv, wordlists and other data-ish .txt (mean line length under 25 chars)

Violations, highest ROI first

ROI = lines x commits in the last year. Work top-down; a long file nobody edits has near-zero payoff and should not be first.

lines	commits/yr	kind	file
556	41	code	`phone_focus_mode/config.sh`
1734	9	code	`linux_configuration/periodic_background/digital_wellbeing/setup_midnight_shutdown.sh`
833	15	code	`phone_focus_mode/deploy.sh`
1337	8	code	`linux_configuration/periodic_background/check_and_enable_services.sh`
1091	9	code	`phone_focus_mode/focus_ctl.sh`
543	12	code	`phone_focus_mode/focus_daemon.sh`
929	6	code	`linux_configuration/periodic_background/digital_wellbeing/pacman/pacman_wrapper.sh`
564	9	code	`focus_owner/android/app/src/main/kotlin/com/kuhy/focus_owner/EnforcementRunner.kt`
918	5	code	`linux_configuration/periodic_background/digital_wellbeing/setup_night_lockdown.sh`
912	5	code	`linux_configuration/periodic_background/hosts/install.sh`
258	16	prose	`CLAUDE.md`
698	5	code	`reverse_survivors/src/core/sim.test.ts`
620	5	code	`linux_configuration/lib/common.sh`
415	7	code	`focus_owner/android/app/src/main/kotlin/com/kuhy/focus_owner/DevicePolicyBridge.kt`
912	3	code	`linux_configuration/features/setup_searxng.sh`

(182 further files over 250 lines not listed — re-run the survey for the full set.)

How to split

Python — extract cohesive helpers into sibling modules; keep the public API and imports stable.
Shell — split into lib/*.sh sourced by a thin entry script. Keep set -euo pipefail in each.
Dart / TypeScript — extract widgets/components into their own files.
Tests — split by test-group into sibling files (foo.test.ts -> foo.parsing.test.ts, foo.render.test.ts). Coverage must not drop.
Docs — split into topic files under docs/ with an index. For an oversized CLAUDE.md, move detail into referenced docs so the always-loaded part shrinks.

Do not game the cap: no one-lining, no deleting tests, no moving code into an exempt extension, no # noqa-style suppressions.

Make it permanent (required — this is the point)

A refactor without a gate silently regrows. Before this task is done:

Wire the shared gate ~/utils/scripts/check_file_length.sh into this repo's .pre-commit-config.yaml as a local hook. If the repo has no pre-commit config, add a minimal one.
The hook checks files in the commit (not the whole tree), so unrelated commits never break, and it fails — exit 1, not a warning.
No baseline file and no allowlist. Those are suppressions.
If this repo has CI (.github/workflows), add the same check there so it also fails on push.

Done condition

bash ~/utils/scripts/check_file_length.sh --all from this repo root exits 0.
The repo's own test suite and coverage bar are still green.
pre-commit run --files <changed files> passes.
A deliberately over-250-line test file, staged, makes git commit fail.
For a deployed daemon/app: the entry point still actually runs.

Verify

Many scripts here run from systemd timers and the working tree. After splitting a script, run it directly and confirm the timer unit still resolves its path.

5.4 KiB Raw Blame History