testsAndMisc/NEXT_SESSION_RESTRUCTURE.md
Krzysztof kuhy Rudnicki 60a7fb38f4 Update restructure status: 7 units out, 3 subsystems left
Also records that syncyomi-guard has been red since 00:00 today for
reasons unrelated to this work -- the library collapsed to 8 manga and
the guard is correctly refusing to let it pass.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PJrqKERAo5QUeEHWS5Asgp
2026-08-23 18:03:30 +02:00

91 lines
4.7 KiB
Markdown

# testsAndMisc restructure — where it stands
Plan: `~/.claude/plans/after-refactor-of-testsandmisc-modular-wigderson.md`
Live-state checklist: `docs/restructure-live-state.md`
(regenerate with `./meta/scripts/report_live_state.sh`)
## Done
**Archived** to `github.com/kuhyx/testsAndMisc-archive`, full history:
`bucket_catch`, `poker-stakes`, `billsplit` (+ `python_pkg/billsplit_coverage`,
its CI workflow, the `app_icons` registry entry, and the paired
`.binary-allowlist` / `.gitignore` icon rules — `.binary-allowlist` now has no
patterns at all).
**Extracted** to public repos, full history, each with CI it did not have here:
`reverse-survivors`, `kcd2-dice-solver` (cloned to `~/kcd2-dice-solver`),
`focus-owner`, `mtk-root` (took the four `mtk_*` libs and three suites that
lived in `scripts/lib/`).
**Gates written, deliberately NOT wired**: `meta/scripts/check_directory_depth.sh`
(cap 2; exempts `third_party/`, `docs/superpowers/`, `.github/skills/` by prefix
and `lib/` / `tests/` by path segment). Violations 556 → 294.
Depth, tests and pre-commit verified green at every commit; nothing used
`--no-verify`.
## Decisions taken this session
- **Depth cap is 2**, with `lib/` and `tests/` exempt — so the ~118 single_use
lib files stay put and step D only flattens entry scripts.
- **`meta/` is in scope** for the cap.
- **`scripts/lib/common.sh` STAYS.** Measured: 55 consumers, 51 of which remain
here. The `.githooks` use a _separate_ `common.sh`, so the ">2 units" rule
selects nothing worth moving. Deviation from the original instruction,
agreed after measurement.
- **`periodic_background/lib/` STAYS** — 9 files, one consumer
(`check_and_enable_services.sh`), not a shared library.
- New repos are **public**; vmbox pass required for **all four** subsystems.
## Remaining, in order
1. `hosts` — owns `/etc/guard-lib/targets/{resolved,nsswitch}.conf` plugin
paths. Confirm `guardctl status` after, not just that files moved.
2. `phone_focus_mode` + `python_pkg/focus_policy` — must come after `hosts`:
`deploy_phases.sh:73` executes hosts' `generate_hosts_file.sh`.
3. `digital_wellbeing` **last** — pacman wrapper, `chattr +i`, the 12
hardcoded orchestrator paths in `check_and_enable_services.sh:61-74` /
`setup_periodic_system.sh:20-23`, and now `heavy_job_lock.sh`, which moved
in with it. It also owns `test_shutdown_timer_monitor.sh`, the pair test
left behind here.
4. Step D: flatten the 207 remaining entry-script violations
(`single_use/**` is ~130 of them). Deduplicate the two Nextcloud
implementations first — ~2,780 lines for one capability.
5. Step E: wire both gates, close the `boot-repair` hole (756 lines, escapes
the 250-line cap because `is_source_file()` needs a dot in the filename),
prune `docs/superpowers/` churn.
## Traps already paid for
- **Run the thing, don't read it.** Repointing kcd2 surfaced three failures no
grep would have found: pnpm ignoring the `package.json` "pnpm" field, pnpm
refusing to purge `node_modules` without a TTY, and the Docker container
still bind-mounting the deleted monorepo path.
- **`/usr/local/bin` holds copies that name repo paths** — invisible to a repo
grep, and `periodic-system-maintenance.sh` runs hourly with three such paths
into digital_wellbeing and hosts. Any extraction of those two must
_reinstall_ it, not just edit the repo copy.
- **Removing a file can break a suite that stays.** Deleting `mtk_harness.sh`
broke `test_common_datetime.sh`, which sources it. Check both directions.
- **pre-commit's patch restore can silently revert an edit** made before the
commit — the `app_icons` change had to be applied twice. Re-grep after
committing.
- `shell-tests.yml` discovers _some_ suites by glob and names others in an
explicit list. A removal breaks the list (CI fails on the missing file) and
silently shrinks the glob. Check both.
- **Never let a test fall back to `/usr/local/bin`.** The installed copy can be
older than source — `shutdown-timer-monitor.sh` is, on this machine — so the
test compares an installer template against a binary it never generated. It
hung. Prefer a sibling checkout and SKIP when absent.
- Extractions keep surfacing pre-existing bugs. `update_android_hosts.sh`
pointed `GUARDIAN_MODULE_DIR` at a sibling that never existed. Fix them
rather than carrying them forward, and guard at the single funnel.
## Unrelated: syncyomi-guard is red
Failing since 00:00 on 2026-08-23, ~17h before this session — nothing to do
with the restructure. It is working as designed: the library collapsed from
2185 manga / 68902 chapters to 8 / 895. See the `syncyomi-restore-silent-partial`
memory; do NOT checkpoint the WAL before recovering. Newest snapshot in
`~/syncyomi/snapshots/` is 2026-08-15.