kuhyx/utils
1
0
Fork 0
mirror of https://github.com/kuhyx/utils.git synced 2026-11-10 19:07:17 +01:00
Code Issues Actions 14 Packages Projects Releases Wiki Activity
fd013abf67
utils/crdt_sync_dart/TODO-fix-file-log-persistence-shared-tmp.md
Krzysztof kuhy Rudnicki fe1f4a22ab
Some checks failed
crdt_sync_dart tests / test (push) Waiting to run
Details
crdt_sync_flutter tests / test (push) Waiting to run
Details
dependency freshness / dependencies on newest stable (push) Waiting to run
Details
file length / file-length (push) Waiting to run
Details
md-naming / markdown naming convention (push) Waiting to run
Details
palette drift / palette (push) Waiting to run
Details
repo-contract / repo contract (push) Waiting to run
Details
shared gate tests / gate unit tests (push) Waiting to run
Details
sickdays pre-commit / pre-commit (push) Waiting to run
Details
sickdays tests / test (push) Waiting to run
Details
crdt-sync pre-commit / pre-commit (push) Has been cancelled
Details
crdt-sync tests / test (push) Has been cancelled
Details
google_account_token tests / test (push) Has been cancelled
Details
TODO: FileLogPersistence shared tmp race 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WzxdWY1k4muZfdVJfb7YGJ
2026-11-02 10:34:58 +01:00

1.1 KiB
Raw Blame History

Make FileLogPersistence.write safe under concurrent calls

what

FileLogPersistence.write (lib/src/io_store.dart) writes to a tmp file named <file>.<pid>.tmp and renames it over the target. The name is per process, not per call, so two overlapping writes in one process (per-keystroke upserts in the todo app) share one tmp path: the first rename moves it away and the second throws an unhandled PathNotFoundException on rename of todo_notes.json.<pid>.tmp. Seen in the todo app during concurrent per-keystroke upserts. Fix by serializing writes (a chained Future per instance, last write wins) or by using a unique tmp name per call; keep the atomic rename.

done

A regression test in test/ fires 50 overlapping write() calls on one instance, all complete without error, and the file then holds the text of a call that was issued (not a torn mix). dart test in this package exits 0 with coverage still 100%.

verify

cd ~/src/utils/crdt_sync_dart && dart test --coverage=coverage; then bump the todo app's crdt_sync ref and run its full suite.

read first

  • lib/src/io_store.dart

REMOVE ME AFTER FINISH