wake-alarm/wake_alarm
Krzysztof kuhy Rudnicki e8f50828e6 Phase 5: the power button no longer ends the alarm (item 2)
Two defences, because one press and one held press are different problems.

**Prevention — _inhibit.py.** A logind block-mode inhibitor on
handle-power-key:shutdown:idle, taken while the alarm is audible and released
in on_close(). Confirmed on the host before writing it that
PowerKeyIgnoreInhibited=no is in force, so no logind.conf drop-in is needed --
and none is added: a drop-in changes the machine permanently, an inhibitor is
scoped to the alarm.

Verified live: the inhibitor appears in `systemd-inhibit --list` as
`wake-alarm ... shutdown:idle:handle-power-key ... block` and disappears on
release.

The child runs `sleep 7200`, never `sleep infinity`. An orphaned block-mode
inhibitor would hold the power button down until reboot -- worse than the bug
being fixed -- so it self-terminates, and a stale one is cleared at startup.

That cleanup was wrong on the first attempt and the host run caught it:
`pkill -f "--who=wake-alarm"` matched the *shell that had just typed the
pattern* and killed it, leaving the real inhibitor alive (`killed 0`, one
inhibitor still listed). Substring matching is inherently self-matching. Now
it lists `pgrep -x systemd-inhibit` and confirms each pid via
/proc/<pid>/cmdline. Re-verified: orphan reaped, exactly one live inhibitor,
zero remaining after release.

**Consequence — _alarm_session.py.** The real gap was that nothing on disk
ever said "ringing, not yet dismissed": wake_state.json is written only on
dismissal, so a hard power-off left no trace and the catch-up window closed
while the machine was down. A signed record is now written at fire time, and
_trigger re-fires on one still marked ringing, ignoring the window.

Deliberately no date field. _state.py keys by UTC and
screen_locker/_wake_state.py mirrors that helper to read the very same file
from another repo, so the UTC basis there is load-bearing. The plan's
_today_str() flip is therefore NOT done -- it would have made any dismissal
between 00:00-02:00 local read as yesterday's in screen-locker and silently
lose an earned workout skip. This record carries only an aware fired_at and
compares elapsed time, so the midnight question never arises.

Age-bounded at 5400 s: an alarm that dies before dismissal leaves a record
nothing ever clears, and unbounded this would restart the alarm every minute
forever.

Two bugs the unit tests could not see, both found by running it:

- A future-stamped record returned None, i.e. "not ringing". But a backward
  clock jump is routine on a machine that hibernates nightly (NTP correcting
  after resume), so that failed *open* on exactly the escape it closes: ring
  on a fast clock, clock corrects, power-off works again. Now clamped to zero
  within a 900 s tolerance and logged.
- _alarm.py derived the correlation id from the alarm's *start* instant. On a
  catch-up or re-fire the PC would write wake-...-0735 while the phone wrote
  wake-...-0700 and the two log streams stop joining. Now
  correlation_id_for_today() derives it from the resolved alarm time, which is
  what _correlation.py always specified.

Every trigger test patched should_refire, so _decide against a real record was
untested -- which is why only the manual run found the first one. There is now
an end-to-end test that writes a real session and asserts the decision.

Splits carried: test_trigger.py 294 -> 197 + test_trigger_main.py,
test_alarm_part2.py 266 -> 170 + test_alarm_timers_flash.py. The inhibitor
handle moved into _AlarmHardware, which also settles pylint's attribute count
and puts it beside the other thing on_close() gives back.

No new suppressions: the one inline pylint disable was redundant, since
consider-using-with is already disabled repo-wide in pyproject.toml.

452 tests pass, 100% branch coverage.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EckWmyfetYq3Mi8MAnUudh
2026-08-27 20:26:37 +02:00
..
tests Phase 5: the power button no longer ends the alarm (item 2) 2026-08-27 20:26:37 +02:00
__init__.py Add tests and fix pre-commit issues across all projects 2026-04-12 20:45:24 +02:00
_alarm_display.py feat: split oversized modules for 500-line limit, fix kasa coverage gap 2026-06-14 07:19:37 +02:00
_alarm_flash.py Phase 4: wire sink reactivation into the alarm (finishes item 6) 2026-08-27 20:14:00 +02:00
_alarm_payload.py Discover alarm device directories instead of reading a fixed phone path 2026-08-09 17:06:43 +02:00
_alarm_session.py Phase 5: the power button no longer ends the alarm (item 2) 2026-08-27 20:26:37 +02:00
_alarm_state.py Phase 5: the power button no longer ends the alarm (item 2) 2026-08-27 20:26:37 +02:00
_alarm_timers.py Phase 4: wire sink reactivation into the alarm (finishes item 6) 2026-08-27 20:14:00 +02:00
_alarm_view.py Size the alarm's type in pixels, and gate every screen on fitting 768px 2026-08-03 16:04:27 +02:00
_alarm.py Phase 5: the power button no longer ends the alarm (item 2) 2026-08-27 20:26:37 +02:00
_audio.py Phase 3: remove the max-fan ramp, split _alarm.py, wire the new modules 2026-08-26 23:46:10 +02:00
_beep_loop.py Phase 3: remove the max-fan ramp, split _alarm.py, wire the new modules 2026-08-26 23:46:10 +02:00
_brightness.py Phase 3: remove the max-fan ramp, split _alarm.py, wire the new modules 2026-08-26 23:46:10 +02:00
_challenges.py Fire alarm daily, harden dismissal challenge; ignore wake_state.json 2026-07-10 23:14:40 +02:00
_constants.py Phase 5: the power button no longer ends the alarm (item 2) 2026-08-27 20:26:37 +02:00
_correlation.py Phase 5: the power button no longer ends the alarm (item 2) 2026-08-27 20:26:37 +02:00
_countdown.py Phase 3: remove the max-fan ramp, split _alarm.py, wire the new modules 2026-08-26 23:46:10 +02:00
_dismiss_view.py Phase 3: remove the max-fan ramp, split _alarm.py, wire the new modules 2026-08-26 23:46:10 +02:00
_escalation.py Phase 2b: add the 5-minute audio failsafe, and retune escalation to fit it 2026-08-26 23:17:41 +02:00
_escape_flow.py Size the alarm's type in pixels, and gate every screen on fitting 768px 2026-08-03 16:04:27 +02:00
_gating.py Phase 3: remove the max-fan ramp, split _alarm.py, wire the new modules 2026-08-26 23:46:10 +02:00
_inhibit.py Phase 5: the power button no longer ends the alarm (item 2) 2026-08-27 20:26:37 +02:00
_lock_setup.py Phase 3: remove the max-fan ramp, split _alarm.py, wire the new modules 2026-08-26 23:46:10 +02:00
_log_dedupe.py Phase 1: structured JSONL logging with cross-process dedupe 2026-08-26 23:00:08 +02:00
_log_sink.py Phase 1: structured JSONL logging with cross-process dedupe 2026-08-26 23:00:08 +02:00
_logging_setup.py Phase 1: structured JSONL logging with cross-process dedupe 2026-08-26 23:00:08 +02:00
_reactivate.py Phase 4: wire sink reactivation into the alarm (finishes item 6) 2026-08-27 20:14:00 +02:00
_rounds.py Phase 3: remove the max-fan ramp, split _alarm.py, wire the new modules 2026-08-26 23:46:10 +02:00
_screen_flash.py Phase 3: remove the max-fan ramp, split _alarm.py, wire the new modules 2026-08-26 23:46:10 +02:00
_sinks.py Replace sleep-and-hope audio waits with per-cycle presence checks 2026-07-11 18:51:03 +02:00
_smart_plug.py Extract wake_alarm from testsAndMisc as a standalone repo 2026-06-22 12:31:40 +02:00
_startup.py Phase 3: remove the max-fan ramp, split _alarm.py, wire the new modules 2026-08-26 23:46:10 +02:00
_state.py Extract wake_alarm from testsAndMisc as a standalone repo 2026-06-22 12:31:40 +02:00
_sync.py Discover alarm device directories instead of reading a fixed phone path 2026-08-09 17:06:43 +02:00
_tone.py Phase 3: remove the max-fan ramp, split _alarm.py, wire the new modules 2026-08-26 23:46:10 +02:00
_trigger.py Phase 5: the power button no longer ends the alarm (item 2) 2026-08-27 20:26:37 +02:00